dinhquan / dqalertview Goto Github PK

Hey, nice library you got here~
But I am facing a small problem, while using ipad2 in landscape mode, the alert is showing in portrait mode

When I rotate ipad to portrait mode, alert stays same in portrait mode.

Any clue why this might be happening ?

Not support long title. The re is no setting for multilines title and line break mode

why use strong ? maybe the object cannot be released?

// Delegate
@Property (nonatomic, strong) id delegate;

if have not setupViews method in setCustomFrame method , the cancel button or otherButton can not rechange the frame when setCustomFrame method will be call

hi, I found that in iOS 8.x, when touch the blackOpaqueView to dismiss the alertView, it crashed.
I finally found that in - (void)dismiss method, the last else if remove self from superView, and then access the blackOpaqueView property by self.blackOpaqueView.That leads to BAD_ACCESS.
I fixed it by moving remove subviews code before self remove from superView.

code before: crash

• (void)dismiss {
  ...
  else if (self.disappearAnimationType == DQAlertViewAnimationTypeNone)
  {
  [self removeFromSuperview];
  }

  if (self.blackOpaqueView) {
  [UIView animateWithDuration:timeDisappear animations:^{
  self.blackOpaqueView.alpha = 0;
  } completion:^(BOOL finished) {
  [self.blackOpaqueView removeFromSuperview];
  }];
  }
  }
  code after: ok

• (void)dismiss {
  if (self.blackOpaqueView) {
  [UIView animateWithDuration:timeDisappear animations:^{
  self.blackOpaqueView.alpha = 0;
  } completion:^(BOOL finished) {
  [self.blackOpaqueView removeFromSuperview];
  }];
  }

...
else if (self.disappearAnimationType == DQAlertViewAnimationTypeNone)
{
[self removeFromSuperview];
}
}

there is no provision for adding more than 2 buttons .

This hampers this repo from being universally used as a replacement for UIAlertView it if depends on being shown from a UIViewController.

Touch every row of the cell in the demo project but the view shows up for only a very shot time. Xcode version:6.4