diracgrid / webappdirac Goto Github PK

Pressing "return" or "enter" in the dialog box with the name of the state should save the new state.

1. If many things are selected the submit, reset and refresh buttons dissapear and there's no scroll to get to them. A scroll bar has to be added somehow. Also, it'd be useful if these buttons were on the top of the selections instead of at the bottom.
2. The grid refresh button should be the same as the selection panel submit button. It's confusing to change selection and when clicking refresh, the selection is ignored.
3. Maybe it's better to place the grid toolbar at the top instead of at the bottom.

Changing group or setup via menu in the bottom-right part of the page ends up in a blank page that does not have the new group/setup selected.

when overwriting an existing State, a confirmation message should appear

Save as, does not consider an existing StateName as valid value, but the reason is not clear. I would suggest to:

• Display existing Names
• Allow to select them
• Allow to overwrite States with a confirmation

Currently:

It should be like:

CSV data can stay as a link for now.

There's looooots of code like:

def web_doSomething( self ):
  RPC = RPCClient("WorkloadManagement/JobMonitoring")      
  data = RPC.doSomething()
  ...

whereas it should be:

@asyncGen
def web_doSomething( self ):
  RPC = RPCClient("WorkloadManagement/JobMonitoring")      
  data = yield self.threadTask( RPC.doSomething )
  ...

When clicking a "New" to generate a new window with the plot, the selection data is not taken into account

In the screenshot, the bottom app has been created by clicking new on the top one. The bottom one doesn't have the selection applied (missing Site)

Should we rename it?

Refresh: Icon plus Text
Stretch: Icon plus Text (move by Refresh)
(to make them consistent with other Applications)

There should be no space left at the botom/right margins of the images

AutoRefresh/Stretch State is not saved

Restore of the Windows triggers a Refresh of the plot????

AutoRefresh/Stretch State should be kept when "New" plot is created

How do we recover the selection of a given plot?, I propose that issuing New goes back to original selection.

I am using volhcb25 machine with compiled js code. I am getting the following error:
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMHistory.pushState]
[Break On This Error]

...ls:c.cols,rows:c.rows});return a},afterRender:function(){var a=this;a.callParent...

Probably all cases are not covered:

File "/Users/adria/Devel/diracRoot/WebAppDIRAC/WebApp/handler/JobMonitorHandler.py", line 28, in web_getJobData
  result = result["Value"]
KeyError: 'Value'

Check that result[ 'OK' ] is true before getting the value.

If I click on site nothing shows even if the selector buttons turn blue. Data received from the server is:

Sometimes just selecting the type gets the accounting stuck:

Data is properly received

Request URL:https://localhost:8443/DIRAC/s:LHCb-Production/g:diracAdmin/AccountingPlot/getSelectionData
Request Method:POST
Status Code:200 OK

...

Replace all

self.finish( WErr.fromSERROR( result ) )

for

raise WErr.fromSERROR( result )

• When a path is selected from the FC Browser, the "compatible" metadata has to be updated. The selection should not be changed. It can produced an empty match (this is not a problem).
• When a new query is submitted the "page" should be reset to 1
• When a query returns nothing, the display grid should be updated accordingly.
• We need to define a mechanism for refreshing the info (in case new files have been registered).

When there's an error in an ajax request:

• Blank the grid (currenty it just does this)
• Show an error informing the user that there's an error

Would be nice if a click in "Anonymous" raised an option to go to the https web site

How to reproduce:

1. Open JobManager
2. Make some selections (sites...)
3. Save state
4. Close JobManager
5. Open a new JobManager with the save state
6. <- Selection is not recovered

To reproduce

1.- Create state A
2.- Load Link
3.- URL still has url_state=1|A

If there are no jobs to be shown this exception is raised:

File "/Users/adria/Devel/diracRoot/WebAppDIRAC/WebApp/handler/JobMonitorHandler.py", line 43, in web_getJobData
  if not (len(result["ParameterNames"]) > 0):
KeyError: 'ParameterNames'

BTW: What are all those <pass> in the JobMonitor. Shouldn't the be <return> or something?

Try to get a JobManager window non-maximized and non-pinned

I just realised when I change the setup from development to production then we still use the development UserProfile while we must use the production one. It is because we create the UserProfile:
def __getUP( self ):
try:
obj = self.request.arguments[ 'obj' ][-1]
app = self.request.arguments[ 'app' ][-1]
except KeyError as excp:
raise WErr( 400, "Missing %s" % excp )
return UserProfileClient( "Web/%s/%s" % ( obj, app ))
We have to provide the RPC client to the UserProfileClinet in order to get the proper setup.

buttons should have a context Help message:
Close, Pin, Unpin, Save State, ...

It would be nice that the Sites menu of the Accounting Allows extra keywords "Tier1", "Tier2",... The tier level is no used to sort the list of Sites but a explicit way to select all of them at a given level.

Raja from LHCb has found a bug in the accounting app.

When I go to "Accounting Plot" and select category "Pilot", the window/frame goes into an eternal "Wait ..."

Looking in the dev console:

Uncaught TypeError: Cannot read property 'length' of undefined AccountingPlot.js:21

• Set 100 as the default entries in the JobMonitor
• Save the number of entries per page in the state
• Save the "hide" state of the selection panel
• By default order the jobs by descending Job ID
• When retrieving a Pilot output from a job. Server responded with a status of 500 (Internal Server Error). And the js gets stuck in waiting.

Make use of groups to reduce the number of items in the Status Bar

When loading a new Desktop State, the user is asked if he wants to save the current state, if yes is answered, the corresponding dialog should be opened and when closed (with save or cancel) the requested state should be loaded.

If I access the webpage using the full URL static paths aren't properly calculated:

/DIRAC/s:Integration/g:dirac_admin/static/DIRAC/JobMonitor/images/failed.gif

should always be

/DIRAC/static/DIRAC/JobMonitor/images/failed.gif

When unpin, the application should recover the same location and dimensions it had when pinned.

When uppin the header should have a "hide header" button.

Example sorting by JobID

That's it :P

That allows to have a 2x2, 3x3 and 12x12 layouts for apps :)

When there are few items to be selected the size is 1 item too small.
1 Items, Nothing is seen
2 items, 1 it is seen, no scroll is displayed, if you have a mouse with wheel you are able to see both of them
3 items, 2 are displayed and the scroll is shown (but it looks ridiculous)
...

This is a feature request: please implement keyboard shortcuts for moving between the different applications.

When opening the job manager if return gets an S_ERROR an exception is raised in the web server:

Traceback (most recent call last):
  File "/Users/adria/Devel/diracRoot/Darwin_x86_64_10.7/lib/python2.6/site-packages/tornado/web.py", line 1115, in _stack_context_handle_exception
    raise_exc_info((type, value, traceback))
  File "/Users/adria/Devel/diracRoot/Darwin_x86_64_10.7/lib/python2.6/site-packages/tornado/stack_context.py", line 302, in wrapped
    ret = fn(*args, **kwargs)
  File "/Users/adria/Devel/diracRoot/Darwin_x86_64_10.7/lib/python2.6/site-packages/tornado/gen.py", line 550, in inner
    self.set_result(key, result)
  File "/Users/adria/Devel/diracRoot/Darwin_x86_64_10.7/lib/python2.6/site-packages/tornado/gen.py", line 476, in set_result
    self.run()
  File "/Users/adria/Devel/diracRoot/Darwin_x86_64_10.7/lib/python2.6/site-packages/tornado/gen.py", line 507, in run
    yielded = self.gen.send(next)
  File "/Users/adria/Devel/diracRoot/WebAppDIRAC/WebApp/handler/JobMonitorHandler.py", line 29, in web_getJobData
    result = result["Value"]
KeyError: 'Value'

It would be nice if accounting windows could resize their plots without maintaining the aspect ratio to maximize space usage.

Currently:

And it would be nice if we could have (even if the aspect ratio is not ok):

Maybe place a checkbox next to CSV with (keep aspect ratio) or something like that.

Typo: diffrence -> difference
Better: Show diff. (to reduce the text)

When inserting a multiline value:
te
tet
after the Submit one gets:
te,tet
in the Value box.
A second Submit produces:
tetet
as Value.

commas and new lines should be proper "read" in the Value and after submit the Value should be properly reformatted

Under "user" there's more values. If you look at the scroll bar it is also cut.

Either users via:

• HTTP
• HTTPS with an unauthorized certificate

Should not try to list/save... states. UP access should be disabled for them

At least disable then when there's no console.log available

Set the initial accounting window to a square size (NxN where N is min( desktop.witdh, desktop.height ) / 2 ) so the fist plot is not too deformed.