dirkfabisch / mediator Goto Github PK

This is more a question rather than an issue report. What is the best strategy to migrate from an existing theme (e.g., lanyon) to mediator? I followed the Jekyll doc but it didn't work. Thanks in advance!

I get the following error when running jekyll serve

$ jekyll serve
Configuration file: /Users/joesankey/Source/github/mediator/_config.yml
            Source: /Users/joesankey/Source/github/mediator
       Destination: /Users/joesankey/Source/github/mediator/_site
      Generating... 
  Conversion error: Jekyll::Converters::Sass encountered an error converting 'css/main.sass'.
  Conversion error: Invalid CSS after " webkit-image": expected ")", was ": -webkit- + $p..."
jekyll 2.5.1 | Error:  Invalid CSS after "      webkit-image": expected ")", was ": -webkit- + $p..."

When visiting the blog in explorer, the main container doesn't work and the content is pushed to the edges of the windows and looks bad without any borders or padding.

Thanks

The first time I tried to embed an image using redcarpet markdown, the page in which the image was embedded broke and I received the following error in the console:

Uncaught TypeError: this.hasClass is not a function

It was coming from index.js, line 22. .hasClass() is a jQuery method, and it turns out you forgot the dollar sign in your conditional.

I had problems with celluloid 0.16.1 but I have changed in Gemfile.lock celluloid (0.16.1) and celluloid (~> 0.16.1) (line 98) to 0.17.2 (current version).

So, when I run jekyll with the command: bundle exec jekyll serve

Generating... 
                    done.
/Library/Ruby/Gems/2.0.0/gems/celluloid-0.17.2/lib/celluloid.rb:483:in `require': cannot load such file -- celluloid/essentials (LoadError)
    from /Library/Ruby/Gems/2.0.0/gems/celluloid-0.17.2/lib/celluloid.rb:483:in `<top (required)>'
    from /Library/Ruby/Gems/2.0.0/gems/listen-2.10.1/lib/listen.rb:1:in `require'
    from /Library/Ruby/Gems/2.0.0/gems/listen-2.10.1/lib/listen.rb:1:in `<top (required)>'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-watch-1.2.1/lib/jekyll/watcher.rb:26:in `require'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-watch-1.2.1/lib/jekyll/watcher.rb:26:in `build_listener'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-watch-1.2.1/lib/jekyll/watcher.rb:7:in `watch'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-2.4.0/lib/jekyll/commands/build.rb:67:in `watch'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-2.4.0/lib/jekyll/commands/build.rb:37:in `process'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-2.4.0/lib/jekyll/commands/serve.rb:25:in `block (2 levels) in init_with_program'
    from /Library/Ruby/Gems/2.0.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `call'
    from /Library/Ruby/Gems/2.0.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `block in execute'
    from /Library/Ruby/Gems/2.0.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `each'
    from /Library/Ruby/Gems/2.0.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `execute'
    from /Library/Ruby/Gems/2.0.0/gems/mercenary-0.3.5/lib/mercenary/program.rb:42:in `go'
    from /Library/Ruby/Gems/2.0.0/gems/mercenary-0.3.5/lib/mercenary.rb:19:in `program'
    from /Library/Ruby/Gems/2.0.0/gems/jekyll-2.4.0/bin/jekyll:18:in `<top (required)>'
    from /usr/bin/jekyll:23:in `load'
    from /usr/bin/jekyll:23:in `<main>'

I don't know what is happening.

Thanks you! awesome theme!

First of all, thank you for such a beautiful theme! I'm getting back into blogging and I'm looking forward to using more photos as a part of my posts.

One thing I'm noticing: when you load this page, the article image sometimes obscures part of the article http://blog.jlleblanc.com/first-pot-of-jambalaya/ It's usually fine after refreshing, but I'm unsure of why it sometimes happens on that first page load. I've attached some images.

Broken:

After refresh:

My repo is here: https://github.com/jlleblanc/blog.jlleblanc.com

Love this theme - any plans for adding support for dark mode? Dark Reader works great on this theme and it looks really great in dark mode!

I forked your repo, but ended up copying it to my own. I noticed that the favicon didn't work when I added a .ico file to the assets/images/ dir.

I think I fixed it by changing the line in _includes/head.html:

  <link rel="shortcut icon" href="{{ "/assets/images/favicon.ico" | prepend: site.baseurl }}">

to including a '?':

  <link rel="shortcut icon" href="{{ "/assets/images/favicon.ico?" | prepend: site.baseurl }}">

My header icon not cover the header properly.
After checking the _includes/header.html and css/main.sass,I find that deleting attributes top and left in main.sass will make things right.(deleting attribute position:absolute is also useful)
Hope to help others.

It will be good if you can add a dropdown menu like this: http://mmistakes.github.io/hpstr-jekyll-theme/
and a search buton like this: https://mmistakes.github.io/so-simple-theme/

without them it will be hard to find posts. Thank you.

I am trying to figure out if it would be possible to dynamically resize the main image displayed with the post just like the header and footer.

When a window size is reduced or if the viewing environment is mobile, the theme correctly resizes the footer (default image: typewriter) but the main image associated with the post is cropped.

Hi,

Was wondering if there is a way to fix the issue I have when running jekyll serve. Keep getting a lot of "Liquid Warning: Liquid syntax error"
Site still works but am concerned that it would break at some point. Am I missing something?

Thank and love the theme!!

Hey bro! I'm just a regular user without any knowledge of coding. I saw your theme, loved it and decided to give it a try. And it's really awesome!! I translated the whole project into Greek - except one little part: I can't figure out how to localize dates. I'd like to translate them into Greek too! Could you please help?

It would be good if Quora is added in the social icons. Font Awesome does not have a font for Quora yet. I followed this: http://qr.ae/ROW5Zh

When I want to compile the main.sass file I got an error on Atom and on sassmeister.com with 2 differents errors

Sassmeister : Invalid CSS after "...padding-left: 0": expected "{", was ""
Atom : ```
{
"status": 1,
"file": "/Users/KEJ/GitHub/kejoff.github.io/css/main.sass",
"line": 1,
"column": 1,
"message": "Invalid CSS after "-": expected 1 selector or at-rule, was "--- {}"",
"formatted": "Error: Invalid CSS after "-": expected 1 selector or at-rule, was "--- {}"
on line 1 of Users/KEJ/GitHub/kejoff.github.io/css/main.sass>> --- {}"
}

Do you have any idea why ?

Thanks,

There is a problem with post images on mobile. If I want to use background image with real data, the image is cropped (see screenshots from example blog)

mobile
desktop

You can see that image content is different between those two...

Trying this out on Windows 10 with the newest Ruby 32 bit. No issues when installing the bundle but I can't run jekyll serve.

> bundle exec jekyll serve
Configuration file: E:/Work/github-blog/_config.yml
C:/Ruby23/lib/ruby/gems/2.3.0/gems/nokogiri-1.6.6.2-x86-mingw32/lib/nokogiri.rb:29:in `require': cannot load such file -- nokogiri/nokogiri (LoadError)
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/nokogiri-1.6.6.2-x86-mingw32/lib/nokogiri.rb:29:in `rescue in <top (required)>'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/nokogiri-1.6.6.2-x86-mingw32/lib/nokogiri.rb:25:in `<top (required)>'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/html-pipeline-1.9.0/lib/html/pipeline.rb:1:in `require'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/html-pipeline-1.9.0/lib/html/pipeline.rb:1:in `<top (required)>'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jemoji-0.5.0/lib/jemoji.rb:3:in `require'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jemoji-0.5.0/lib/jemoji.rb:3:in `<top (required)>'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/plugin_manager.rb:28:in `require'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/plugin_manager.rb:28:in `block in require_gems'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/plugin_manager.rb:26:in `each'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/plugin_manager.rb:26:in `require_gems'

        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/plugin_manager.rb:19:in `conscientious_require'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/site.rb:74:in `setup'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/site.rb:36:in `initialize'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/commands/build.rb:28:in `new'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/commands/build.rb:28:in `process'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/lib/jekyll/commands/serve.rb:25:in `block (2 levels) in init_with_program'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `block in execute'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `each'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/mercenary-0.3.5/lib/mercenary/command.rb:220:in `execute'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/mercenary-0.3.5/lib/mercenary/program.rb:42:in `go'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/mercenary-0.3.5/lib/mercenary.rb:19:in `program'
        from C:/Ruby23/lib/ruby/gems/2.3.0/gems/jekyll-2.4.0/bin/jekyll:18:in `<top (required)>'
        from C:/Ruby23/bin/jekyll:22:in `load'
        from C:/Ruby23/bin/jekyll:22:in `<main>'

Since now we are using Gemfile, README.md should be updated to reflect the same

It seems that having a list in a blockquote makes presentation look funny, as its only the paragraph getting the special attention and nothing else in there.

If I knew enough CSS to fix this properly I'd have a go, but I don't. 😨

It would be easy to have a Gemfile in the project itself, so that required gems like bourbon can be added.

This makes easy for user as he/she has to only run bundle install, Having a Gemfile will make things easy for future development.

this would enable

• fingerprinting/caching
• minification
• compression

of css and javascript content and result in faster loading time.
Here is my source code, based on your template.
I can put this together and send you an merge request, if you are interested.
Thanks for this awesome theme.

Hi @dirkfabisch , I am thinking on adapt your theme to easy install with jekyll bootstrap, I already did this with lanyon theme, so I think I will try to do this with yours if you allow of course. What do you think about?

Hello Dirk!

First of all, congratulations for your template, I find it amazing. I'm having some issued with it, though. I've been trying to fix Facebook's sharing button, the one that appears on the bottom of every page. When I try to share a page with it, it doesn't show the title of the post, nor the blog description. I have no idea what's wrong.

My blog repository can be seen here.

Thanks!

Couldn't commit to a branch so I am suggesting these two changes:

--- a/_includes/javascripts.html
+++ b/_includes/javascripts.html
@@ -1,4 +1,4 @@
-<script src="https://code.jquery.com/jquery-1.11.1.min.js"></script>
+<script src="https://ajax.googleapis.com/ajax/libs/jquery/1/jquery.min.js"></script>
 <script type="text/javascript" src="{{ "/assets/js/jquery.fitvids.js" | prepend: site.baseurl  }}"></script>
 <script type="text/javascript" src="{{ "/assets/js/index.js" | prepend: site.baseurl  }}"></script>
 <script type="text/javascript" src="{{ "/assets/js/readingTime.min.js" | prepend: site.baseurl  }}"></script>
@@ -23,7 +23,7 @@
       var height = $('.article-image').height();
       $('.post-content').css('padding-top', height + 'px');

-      $('a[href*=#]:not([href=#])').click(function() {
+      $('a[href*=\\#]:not([href=\\#])').click(function() {
         if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'')
          && location.hostname == this.hostname) {
           var target = $(this.hash);

First one just as it is quite likely users will have that file.
Second one because it is what made jQuery 3.2.1 (latest) fail when I loaded it.

Cheers!
Nikos

Hi,

It would seem that there is tagging functionality started but not working properly. If I add to the post:

tags: featured

Then it works as expected. But that is all. I can't add custom tags which could be later shown in post and there are no tagging subpages. It would be a great option to have. On line 49 of index.html there is this snippet:

<!-- <span class="post-tags-set">on {{#foreach tags}}<span class="post-tag-{{slug}}">{{#if @first}}{{else}}, {{/if}}<a href="/tag/{{slug}}">{{name}}</a></span>{{/foreach}}</span>-->

But uncommenting it doesn't help.

Thanks and regards,
Michał

I'm new to this jekyll thing and i don't have much information about css or sass etc. But i think there is unused css files, for example screen.css. When i add something in it, it's not effect my site. BTW, thank you for this great theme, i'm using jekyll because of this theme. :)

Hi! Love your theme and all the work you've done creating it. I've noticed that this theme hasn't implemented the external_url property for linking to external blog posts. Would you be open to accepting PRs that implement this? I'm thinking of using a strategy mentioned here: https://robots.thoughtbot.com/external-posts-in-jekyll

It would be awesome to have support for not only Disqus (which works great already) but something like Isso (a simple commenting system, similar to disqus, SQLite backend, self-hosted)

I saw some examples in other themes, e.g., scotte/jekyll-clean@67774ed

This theme is using an older version of font awesome (4.0.3). Latest version is 4.2.0

Should be updated to latest CDN reference http://fortawesome.github.io/Font-Awesome/get-started/#bootstrapcdn

Do you plan for tag support in your template? Other than that, I really like it!

Your theme has been listed on http://jekyllthemes.ru