distantmagic / resonance Goto Github PK

In https://resonance.distantmagic.com/docs/getting-started/installation-and-requirements.html, I think it would make more sense to explicitly say that a SSL certificate is needed to run the HTTP server successfully.

Also, there's a typo at the very beginning of that page - see the attached screenshot.

An issue I've discovered is that when loading translations, only the last file (in alphabetical order) gets loaded. If previously loaded data existed it will be replaced every time a new translation file is loaded. As an example, assume the following file structure.

# lang/en/website.ini
[error]
bad_request = "Bad request"

# lang/en/z.ini
# this is empty on purpose

Now because the letter z obviously comes after the letter w, it will be loaded after website.ini. Which because of this issue means that there are no translations at all.

// website.ini gets loaded

object(Ds\Map)#298 (1) {
  [0]=>
  object(Ds\Pair)#755 (2) {
    ["key"]=>
    string(2) "en"
    ["value"]=>
    object(Ds\Map)#757 (1) {
      [0]=>
      object(Ds\Pair)#763 (2) {
        ["key"]=>
        string(17) "error.bad_request"
        ["value"]=>
        string(11) "Bad request"
      }
    }
  }
}

// z.ini gets loaded

object(Ds\Map)#298 (1) {
  [0]=>
  object(Ds\Pair)#757 (2) {
    ["key"]=>
    string(2) "en"
    ["value"]=>
    object(Ds\Map)#763 (0) {
    }
  }
}

I've also noticed that in the documentation for translations, each file gets their own kind of "namespace" of translations. So with this file:

# lang/en/website.ini
greeting = "Hello"

You should translate greeting by doing TranslatorBridge::trans($request, 'website.greeting'); however this does not work, the translation is simply stored as 'greeting' without any reference to the original website "namespace".

The reason I included this in the issue, is because this "namespacing" could be a solution to both problems.