Giter VIP home page Giter VIP logo

bootstrap3_upgrader's People

Contributors

collin avatar jeffgabhart avatar mbleigh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bootstrap3_upgrader's Issues

Batch

Improvement:

Upload several files to batch convert.
Or make a local command tool version.

Ability to diable code-fixing?

I have header.php, footer.php and sidebar.php, that means some tags have their endtags in another file.
By pasting, let's say header.php content in to the converter it will then add more div, html +more endtags at the bottom of the output. It also changes to ?-->.

So far I've have only tested with header.php and footer.php where footer.php don't output anything despite 'Helper Class Specificity' says '2 replaced'. By removing two of the div-tags on top of the footer-file the converer will then work.

This is just a little bagatelle, but would be a nice feature to have. :)

Upgrade php file

Hey

Iam using Bootstrap 2 and want to upgrade it. When I copy my Code into the upgrader it comments every php tag out

like

countModules('google')) : ?>

gets to

countModules('google')) : ?>

Is this a known Issue?

<?php change

sorry to tell you but evry php tag you have in your code ore get commented out or it wil be replaced with the sintax for the < key

django template regex "Search" %}" --> " search"="" %}"=""

wrongly converts django translation marker

"Search" %}" --> " search"="" %}"=""

{% load url from future %}
{% load i18n %}

<form method="get" action="{% url 'search:search' %}" class="navbar-form pull-right">
    {{ search_form.q }}
    <input type="submit" value="{% trans "Search" %}" class="btn" />
</form>

to

{% load url from future %}
{% load i18n %}

<form method="get" action="{% url 'search:search' %}" class="navbar-form pull-right">
    {{ search_form.q }}
    <input type="submit" value="{% trans " search"="" %}"="" class="btn form-control btn-default">
</form>

thanks..

Small error, I believe

"Upgrade Button, Pagination, and Well sizes. 6 Replaced
Change sizes from [button|pagination|well]-[mini|small|large] to [button|pagination|well]-[xs|sm|lg]"

I believe there should be btn instead of button in the code.

PHP tags changing to html

The conversion script is changing < to (&)lt; and > to (&)gt;

This messes up all code in doc where you have php tags
eg:
becomes
(&)lt;?=$value?(&)gt;

[I put ampersand code in brackets or it just converts to < and > here!]

AND
it converts to ?-->

ruby tags

Hey!

My <%= ... %> tags have been replaced with
> < & ...

Maybe, if that'll work, that would be great :-)

old de-emphasis helper class

The old de-emphasis helper class maps to text-muted

old <p class="de-emphasis"></p>
new <p class="text-muted"></p>

Ampersands are munged

test: hale & hearty
becomes: hale &amp; hearty

This is rather bad when the ampersand is seen inside javascript

input with addons

I noticed these were missing:

input-prepend -> input-group

and

add-on -> input-group-addon

Process Panel Incorrectly Shows Code Changes When Nothing Was Changed

When the original source code contains an element with both the "btn" and "btn-default" classes assigned to it, the converted output section correctly leaves it unchanged (since having "btn" and "btn-default" on an element is correct in Bootstrap 3). However, the Process panel on the left side of the screen, in the "Changes to Button Color Classes" section, it incorrectly says that there has been a replacement. I am including a screenshot that shows a simple example. You can see the input source code and output source code are the exact same, which is correct, but the Process panel shows that 1 replacement was made, which is incorrect (I added a large red arrow to the screenshot pointing to the element exhibiting the bug for emphasis).

screenshot1

This problem only occurs with "btn-default". When the input source code has another button color specified (e.g. btn-info, btn-primary, btn-danger, etc.), the program functions correctly and the Process panel correctly shows that no replacements have been made.

Nested grids are not context sensitive

This

<div class="row">
  <div class="span8">
    <div class="row">
      <div class="span4"></div>
      <div class="span4"></div>
    </div>
  </div>
  <div class="span4"></div>
</div>

is converted to

<div class="row">
  <div class="col-sm-8 col-md-8">
    <div class="row">
      <div class="col-sm-4 col-md-4"></div>
      <div class="col-sm-4 col-md-4"></div>
    </div>
  </div>
  <div class="col-sm-4 col-md-4"></div>
</div>

but should be converted to

<div class="row">
  <div class="col-sm-8 col-md-8">
    <div class="row">
      <div class="col-sm-6 col-md-6"></div>
      <div class="col-sm-6 col-md-6"></div>
    </div>
  </div>
  <div class="col-sm-4 col-md-4"></div>
</div>

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.