dj-techtools / midi_fighter_twister_open_source Goto Github PK

Hi! First off, thx so much for sharing the source on this. I've been missing higher res on the midi fighter (127 vals is often not enough) and having access to the source allowed me to increase the res of the knobs by sending encoder values not through regular midi packets, but through sysex msgs. (See https://github.com/armadillu/Midi_Fighter_Twister_Open_Source/tree/feature/14BitEncoder).

The current midifighter utility allows you to set the encoder action behavior, letting you chose between CC and SEND_NOTE. I would like to add a 3rd mode wich sends data through sysEx (I currently hijacked the SEND_NOTE mode to send sysEX). I would also like to add one extra global setting to be able to set how much higher the res is in the encoders when in this HIGH_RES mode (ie how many turns of the knob it takes to travel the whole value spectrum). To do so, I think I would also need access to the source of the midi fighter utility.

Have you guys thought about sharing that too?

thanks for publishing the source code. i'm wondering if anyone has built this on macos/linux and could share their steps. i can probably port the makefile given enough time, but it would be wonderful if someone already figured it out!

Using the 20191002 release code, banks don't work anymore i.e. banks 2-4 use/affect bank 1.

I believe it is due to the removal of this line.

I want to recompile the firmware of atmega32u4 can you upload the source code?

Hi y'all,
I've been enjoying my Twister immensely. In putting it through its paces, I've found either a firmware bug, or a bug with the MacOs MidiFighter Utility.

Here's how to duplicate: When an encoder's "Switch Action Type" is configured as Note Hold, it is no longer possible to set the LED color via MIDI (ie CC for the knob #-1, like 0 for knob 1, channel 2, values 1-126. The color simply stays on the "On Color." All of the other knob configuration via MIDI seems to work fine, just the LED color is unresponsive.

I'm hoping you'll patch this in an updated firmware release. It is preventing me from coloring my knob sets though midi.

fwiw, I'm on macos 10.12 (sierra), on a mac book pro late 2013, 2.3ghz, running v2.75 of the MidiFighter Utility, with the 09 Mar 29018 Firmware.

Thanks for looking into this!
Best,
Dave

ps. wishlist... I wish I could set all of the settings in the utility via midi. This would allow me to use a tool to expand the number of available knob sets. Any chance you'd publish the sysex format to make these settings? Thanks!

The license text reads:

Permission is hereby granted, free of charge, to any person owning or possessing
a DJ Tech-Tools MIDI Fighter Twister Hardware Device to view and modify this source
code for personal use. Person may not publish, distribute, sublicense, or sell
the source code (modified or un-modified). Person may not use this source code
or any diminutive works for commercial purposes.

From the Open Source Initiative's page:

Open source licenses are licenses that comply with the Open Source Definition — in brief, they allow software to be freely used, modified, and shared.

The license included here seems to allow none of that. Without owning a Twister I'm not granted permission to modify the source code. Even if I do own one it seems I wouldn't be able to contribute in the normal way (a pull request) since that would involve distributing my modifications. Finally, not being a lawyer I'm not sure if the commercial restriction prevents me from using the modified source code in any kind of performance I might make money from.

Could you re-license this project with a proper open source license like the GPL?

Old firmware(2014) would respect the CCs and Channels defined in the "Press Encoder" area. Newer firmwares(2016) ignore this for the encoder turning, but send what seems to be an On/Off message for the CC/Channel described in the "Press encoder"area, then channel 5 for the original encoder CC.

Why was this regression made? Similar functionality can be achieved in the older firmware by defining the midi channel in the "Encoder" area.

First, I just want to say I really appreciate this being open-source.

My first question is: is the midi_fighter_twister_20230608.hex a stable release?

Second, is the only way to flash a new build through the bootloader and MF Utility? Or can it be flashed/debugged with Microchip Studio? In other words, can a bad firmware brick the device forever or can it be reflashed with the right tool?

Is this source code up to date? I wanted to fork it and update a few piece of functionality.

Hi there,
I would get way more mileage out of my twister if it was able to send midi notes and not just gates in sequencer mode.
Being able to sequence a synth with the twister would make it an indispensable component of my workflow.
No commits to this repo for 2 years so I hope this project is not dead in the water.
Cheers,
Stephen

Program Change is just a standard MIDI message!

Status Byte
1100NNNN (where NNNN is Channel in binary)

Data Byte
0PPPPPPP (0 + the new program number)

New to the codebase. Anyone familiar know where this would need to be added?

Sending a colour override value of 126 results in the LED being set to the active colour state instead of the override colour.

According to the manual, this is how colour override works.

0 = inactive colour state
127 = active colour state
1 to 126 = override colours

This line appears to be the source of the issue. It should be < 127 or <= 126 in order to operate as described in the manual.