Giter VIP home page Giter VIP logo

Comments (12)

jezdez avatar jezdez commented on June 1, 2024

AWSOME!!!

I've worked on this a bit more and just merged it with the develop branch. Thank you!

from django-compressor.

jezdez avatar jezdez commented on June 1, 2024

I've also worked on tests a bit, see the results here: http://dpaste.de/UI8t/ \o/

from django-compressor.

ulope avatar ulope commented on June 1, 2024

Cool :)

I noticed that you removed the COMPRESS_OFFLINE setting. In my use-case I wanted to make aboslutely sure that no compression occurs "online" (i.e. I'd rather have the users download the uncompressed files than to spend processing time on compression). How do you feel about this?

from django-compressor.

jezdez avatar jezdez commented on June 1, 2024

Nah, no worries, I've actually re-added it here: e4fba59

from django-compressor.

rizumu avatar rizumu commented on June 1, 2024

I need to compress offline generating both the minified and a gzipped version.
cache/css/66c5c8dd8334.css
cache/css/66c5c8dd8334.gz
cache/js/05ca8f5045b6.js
cache/js/05ca8f5045b6.js.gz

The idea is also to save processing, by manually gzipping at compress time, instead of turning it on in nginx. I'd be happy to work on it if this a feature that may be desired in django_compressor. Thoughts?

./manage.py compress --gzip

http://developer.yahoo.com/performance/rules.html

from django-compressor.

jezdez avatar jezdez commented on June 1, 2024

This isn't different to any other compressing, so you can use an own storage backend to gzip the results. In fact the tests actually contain a working example: https://github.com/jezdez/django_compressor/blob/master/compressor/tests/storage.py No idea if this should be blessed and put directly in the compressor.storage module. What do you think?

from django-compressor.

rizumu avatar rizumu commented on June 1, 2024

I didn't get to reading into a custom storage backend, maybe that is the right approach for this app.

I don't have a strong opinion on if it needs to be in the options by default, though gzipping is a best practice, I think most people turn in on in their webserver. Maybe this is an edge case for high traffic sites.

from django-compressor.

jezdez avatar jezdez commented on June 1, 2024

Well, let's move the storage backend from the tests module to the compressor.storage module so you'll be able to set COMPRESS_STORAGE_BACKEND = 'compressor.storage.GzipCompressorFileStorage'

from django-compressor.

jezdez avatar jezdez commented on June 1, 2024

Ok, moved the storage backend in bcf1efe

from django-compressor.

rizumu avatar rizumu commented on June 1, 2024

Nice, works perfect. Though it is COMPRESS_STORAGE not COMPRESS_STORAGE_BACKEND

from django-compressor.

rizumu avatar rizumu commented on June 1, 2024

Just read the default compression level of the gzip library is 9 (slowest but best compression). Awesome, because the bash tool defaults to 6.

from django-compressor.

jezdez avatar jezdez commented on June 1, 2024

Awesome :)

from django-compressor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.