Giter VIP home page Giter VIP logo

Comments (4)

djcb avatar djcb commented on August 27, 2024

I won't be working on this, but if you have very small change to mu4e-modeline to this, we can consider it.

from mu.

nbarrientos avatar nbarrientos commented on August 27, 2024

Would you be happy with simply not registering it during mu4e--start?

@@ -132,7 +132,8 @@ defun mu4e--start
     (add-hook 'mu4e-query-items-updated-hook #'mu4e--notification))
   ;; modeline support
   (when mu4e-modeline-support
-    (mu4e--modeline-register #'mu4e--bookmarks-modeline-item 'global)
+    (when mu4e-modeline-global
+      (mu4e--modeline-register #'mu4e--bookmarks-modeline-item 'global))
     (mu4e-modeline-mode)
     (add-hook 'mu4e-query-items-updated-hook #'mu4e--modeline-update))
   (mu4e-modeline-mode (if mu4e-modeline-support 1 -1))

The patch would be the hunk above, the new defcustom in mu4e-modeline (default t) and a line in the documentation in section 13.2 explaining that the global mode-line can be disabled.

from mu.

djcb avatar djcb commented on August 27, 2024

Sure, thanks, guess that should work. Did you test it? :-)

from mu.

nbarrientos avatar nbarrientos commented on August 27, 2024

Sure, thanks, guess that should work. Did you test it? :-)

Thanks. I've decided to take another (better, IMO) path, please take a look at the PR. The order of magnitude of the patch hasn't changed much 😄

from mu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.