djlink / hqx Goto Github PK

What steps will reproduce the problem?
0. Do not have libmng-dev installed
1. ./configure
2. make
3. Observe that linking fails

What is the expected output? What do you see instead?
Error during ./configure explaining that libmng is required.

What version of the product are you using? On what operating system?
1.0, ubuntu linux 64-bit

Please provide any additional information below.
Not a big deal by any means.  But it would help.

What steps will reproduce the problem?
1. wish that rowbytes could be explicitly specified
2. become disappointed
3. open a new issue on the project page

What is the expected output? 
that the rows align properly

What do you see instead?
they severely misalign if your rowbytes != columns * pixelsize

What version of the product are you using? On what operating system?
latest, darwin

Please provide any additional information below.
i fiddled for a bit trying to pass in source and dest rowbytes, but got a bit 
lost.  i could probably figure it out, but perhaps someone with better domain 
knowledge could do a better job?

the point here is to avoid 2 extra bitmap copies.  currently, i have my pic in 
a bitmap, my code goes like this:

1) copy from bitmap to pixel vector (squeezes out extra space at the end of 
rows)
2) perform upconvert
3) copy from output pixel vector to output bitmap
4) blit bitmap

i'd sure like to skip steps 1 and 3!

See:

HQX_API void HQX_CALLCONV hqxInit(void)
{
    /* Initalize RGB to YUV lookup table */
    uint32_t c, r, g, b, y, u, v;
    for (c = 0; c < 16777215; c++)


The last value "16777215" is *not* initialized!

What steps will reproduce the problem?

Scale an image that has color and full transparency adjacent on a diagonal 
edges.

Expected output is a gradient from the color to transparent.
Currently, there's a gradient towards the color value of the transparent pixel 
at the same time, wich creates noticeable artifacts when the alpha channel is 
removed later.

Attachment info: 'In' is scaled 800%. 'Out' is HQ4X scaled 400%.

Ambiguous call:

/* Test if there is difference in color */
static inline int yuv_diff(uint32_t yuv1, uint32_t yuv2) {
    return (( abs((yuv1 & Ymask) - (yuv2 & Ymask)) > trY ) ||
            ( abs((yuv1 & Umask) - (yuv2 & Umask)) > trU ) ||
            ( abs((yuv1 & Vmask) - (yuv2 & Vmask)) > trV ) );
}

Error:
    10  IntelliSense: more than one instance of overloaded function "abs" matches the argument list:
            function "abs(int _X)"
            function "abs(long _X)"
            function "abs(long long _X)"
            argument types are: (unsigned int)  c:\Program Files\C++\Projects\HqxMAME\ScalerTest\hqx\common.h   51  15  ScalerTest

Solution: Explicitly cast value before calling "abs"

Hi there,

I made a small gui for the windows version. Ist supports simple drag  & drop 
and checks the image format also.

Maybe you can use it.

Greetings,
spyro

Current:
    HQX_API void HQX_CALLCONV hq2x_32_rb(uint32_t* src, uint32_t src_rowBytes, uint32_t* dest, uint32_t dest_rowBytes, int width, int height );
    HQX_API void HQX_CALLCONV hq3x_32_rb(uint32_t* src, uint32_t src_rowBytes, uint32_t* dest, uint32_t dest_rowBytes, int width, int height );
    HQX_API void HQX_CALLCONV hq4x_32_rb(uint32_t* src, uint32_t src_rowBytes, uint32_t* dest, uint32_t dest_rowBytes, int width, int height );

This should be:
    HQX_API void HQX_CALLCONV hq2x_32_rb(const uint32_t* src, uint32_t src_rowBytes, uint32_t* dest, uint32_t dest_rowBytes, int width, int height );
    HQX_API void HQX_CALLCONV hq3x_32_rb(const uint32_t* src, uint32_t src_rowBytes, uint32_t* dest, uint32_t dest_rowBytes, int width, int height );
    HQX_API void HQX_CALLCONV hq4x_32_rb(const uint32_t* src, uint32_t src_rowBytes, uint32_t* dest, uint32_t dest_rowBytes, int width, int height );

Regards

What steps will reproduce the problem?
1. have a png image with transparency (say a round emoticons face)
2. hqx -s 2 input output

What is the expected output? What do you see instead?
I expected the image scaled with transparency preserved
transparent area of input is now white


What version of the product are you using? On what operating system?
kubuntu 10.4
devil 1.7.8 (from source)
hqx 1.0 (source package)


Please provide any additional information below.

What steps will reproduce the problem?
1. Install hqx 1.1 via Homebrew on Mac OS X.
2. Issue a `hqx -s 4 <infile.*> <outfile.*>` command (see transcript below).

What is the expected output? What do you see instead?

~$ hqx -s 4 /Users/thatsme/Pictures/Pixel/bit-pirate.png 
/Users/thatsme/Pictures/Pixel/bit-pirate-4x.png
ERROR: can't load '/Users/thatsme/Pictures/Pixel/bit-pirate.png'
~$ sudo !!
sudo hqx -s 4 /Users/thatsme/Pictures/Pixel/bit-pirate.png 
/Users/thatsme/Pictures/Pixel/bit-pirate-4x.png
ERROR: can't load '/Users/thatsme/Pictures/Pixel/bit-pirate.png'
~$ hqx -s 4 /Users/thatsme/Pictures/Pixel/bit-pirate.gif 
/Users/thatsme/Pictures/Pixel/bit-pirate-4x.gif
ERROR: can't save '/Users/thatsme/Pictures/Pixel/bit-pirate-4x.gif'
~$ sudo !!
sudo hqx -s 4 /Users/thatsme/Pictures/Pixel/bit-pirate.gif 
/Users/thatsme/Pictures/Pixel/bit-pirate-4x.gif
ERROR: can't save '/Users/thatsme/Pictures/Pixel/bit-pirate-4x.gif'


What version of the product are you using? On what operating system?

hqx 1.1 installed sucessfully via Homebrew package manager (including devil 
library 1.7.8).

Mac OS X 10.7.3, 2,66 GHz Intel Core 2 Duo, 4 GB 1067 Mhz DDR3 RAM.

Please provide any additional information below.

To the extent possible (i.e. if there's something I've done wrong on my end) it 
would be nice if StdErr was a little more verbose/helpful to me. :)