Track number of actions used during combat?

Tried in fresh world, no other mods. Refresh, restart world, etc. do not fix it. Hero points remain at 3 dots on sheet regardless of number saved in mod configuration.

Also thank you so much for making this, I do hope you're able to get it working again, it's the best PF2 mod!

Problem

I know it's not exactly a big thing, but I was originally confused as to how the Scale NPC functionality worked due to the labelling on the dialogue box that pops up upon usage, and there being no error message when I was using it incorrectly.

So I originally read it as what the 'start level' of the NPC was, and then what you wanted to scale it to. And I was always trying to reduce the level of an NPC, so I was inputting something like Start 4/End 1; and then nothing would happen because that's not what it's asking.

Suggestions

1. Put a tiny explanation as to what the 2 entry boxes represent and/or potentially re-word what the 2 entry boxes are labelled, perhaps something like:

• Scaled Level Range Start
• Scaled Level Range End

2. Potentially produce an error if someone tries to enter a negative range like I was doing, to explain why nothing happens.

Addendum

Just as an addendum, it's not exactly clear upon first looking what the 'flatten NPC' functionality does. I'm assuming it's a function to set the NPC values to what they roughly should be for their level, but it's not exactly clear, but it's not really described in the GitHub readme section, so it might be worth putting a little explanation in there somewhere.

Thanks for your time and hard-work! :)

Describe the bug
So it does roll saves as normal however when you try to apply damage it does nothing.

To Reproduce
Steps to reproduce the behavior:
Import Group Saving Throw Macro.
Select a token, add in a DC and damage.
Pick one of the buttons that deals damage to the target.

Expected behavior
Should be able to subtract damage using the buttons after using the macro.

Screenshots
Here is the screenshot of what happens when you try to apply damage:

Version Information:
Foundry 0.8.6
PF2E 2.0.2.5814
Toolbox 1.7.2

Additional context

https://i.imgur.com/eS4DcZq.png

Even with the option to hide it enabled, the PFS tab is still visible. This persists in multiple worlds and through refreshes.

Hey man, thanks so much for your work on the PF2e Toolbox. Hoping you can help me out use a particular part of your module/troubleshoot this with me.
It seems that the hero points are bugged and won't populate beyond 3 (and on some of my actors straight up disappeared). We normally play with 7 Hero points (we hand them out in increments of .5)

https://discord.com/channels/170995199584108546/722566083499786352/852083653990547466

The problem it's that when you use the chat buttons to apply damage it generates a chat card that says the name and damage roll of the creature generating a excess of metagame.

The weapon/armor creator takes values for special materials from the tables on page 578-579, which are the values of a "simple
non-magical item made of that material." These prices do not apply to weapons and armor.

"Prices for armor, shields, and weapons made of precious material are in the Armor (page 555), Shields (page 586), and Weapons (page 599) sections of this chapter."

Describe the bug
When I use the groupSave macro to roll saves for NPCs, I input a damage value. The resulting chat box output doesn't show any damage value or buttons to apply that damage.

To Reproduce
Steps to reproduce the behavior:

1. Select 1 or more NPCs
2. Click on the Group Saving Throw macro provided in the compendium for PF2e Toolbox
3. Fill in the dialog box with Save type, DC and Damage
4. See chat message with Save rolls and interpreted results (Fail, Critical Success, etc...) but no damage values/buttons

Expected behavior
At step 4, to see a chat message with both saves and damage values/buttons.

Version Information:

• Browser: Chrome version 88.0.4324.150
• FoundryVTT version 0.7.9
• System: Pathfinder 2nd Edition version 1.11.5.3707
• PF2E Toolbox version 1.6.0
• No other modules active

Additional context
Add any other context about the problem here.

This behavior occurs even when PF2e Toolbox is the only active module.

I am planning to play using the proficiency without level rule variant and I belive that your module comes in handy.
If I set a monster at level 0, the level bonus disappears from armor class, attack rolls and so on. It's cool and easy to use. I only have to restore the base hp to get the creature I need, I think and hope.
I haven't look in to the code or the scaling rules, but my understanding is that your module also changes the strike damage and ability scores, if I don't manually restore them I risk to have weaker creatures. It's not a real problem, I am lazy and I would rather have a weaker creature than to manually correct all bonuses of all creatures in the compendium. So, thanks for the module. However if someday you put a checkbox in the settings to remove the hp, ability and damage dice scaling to support the variant rule, I would much appreciate.

Cheers,
A non-english speaker and Pathfinder 2e player.

Foundry version: 0.8.6.
PF2 system version: 2.2.0.6097

When I roll for a new treasure, the item always get the minimal value of that option. On the screenshot, I press roll 1 from the rectangle red, then I get one "Porcelain vase inlaid with gold" on loot sheet with value of 25gp then go to chat and click on the "Porcelain vase inlaid with gold" item from the chat to open the item info sheet and the value's 75gp

Describe the bug
The flatten functionality does not edit / adjust spell DC and attack.

Expected behavior
Spell DC and Attack should be adjusted the same way as skills.

Version Information:

• FoundryVTT 0.7.9
• PF2E Toolbox 1.5.8

Since there is now webp as a good image format for web, which is in many ways equal or better than png, it would be nice if it was supported by the token setup.
Obviously other popular formats would be nice to have too.

Dice Tray 1.0.0 was released today with many changes and 0.8.8 support, but it is in conflict with PF2 Toolbox.

When both mods are on, Dice Tray buttons no longer roll any dice.

The issue is also reported on Dice Tray tracker: https://gitlab.com/asacolips-projects/foundry-mods/foundry-vtt-dice-calculator/-/issues/26

This happened after updating to the latest PF2 ver 1.11.4.3626

Describe the bug
Enabling the remove default art doesn't seem to do anything. When I look at the monsters after a import them they still have the default art tokens even after a reload. No errors appear in the log as far as I can see.

To Reproduce
Steps to reproduce the behavior:

1. Create a fresh game, load only Toolbox as a module.
2. Turn on the Remove Default Art.
3. Reload the program.
4. Import the Goblin Warrior and check the Prototype Token page.

Expected behavior
I assume this should set it to "icons/svg/mystery-man.svg" unless I am misunderstanding what this part of the module is supposed to do.

Screenshots

Version Information:

• FoundryVTT [e.g. 0.7.9]
• PF2E Toolbox [e.g. 1.7.1]
• Pathfinder 2e [1.13.2.5430]

Additional context
Add any other context about the problem here.

Add setting to enable a notification reminder to GMs to award hero points.

Describe the bug
Sheets of Loot actors with the assigned sheet pf2e-toolbox.LootApp cannot be opened.

To Reproduce
Set an actor's sheet to pf2e-toolbox.LootApp in PF2E 1.14.0

Expected behavior
The sheet should open when double-clicking the actor on the canvas or clicking the actor in the Actors directory.

Additional context
Probably related to the updates of the PF2E system recently. Maybe also related to issue #37 ?

I'm really annoyed by the fact that the players can't take the loot when the sheet is with a limited permission.

• Create a button under the avatar image to take all the loot of the Loot Sheet.
• Create a button in each item to take the loot of that row.

fvtt-Actor-Abberton_Ruffian.zip

Issue caused by GUID instead of integer as key of damageRolls entry.

damageRolls: {
   brd1fpcpdjp1sun7tj43pw: {
      damage: "1d4+3"
      damageType: "piercing"
   }
}

I've recently updated from 0.7.10 to 0.8.8 and found that all items created by the loot sheet completely break automation for characters.

I've reached out in discord and there seem to be lots of changes in the item structure. Here's a link to the first reply, a few follow after: https://discord.com/channels/170995199584108546/697845559435853865/862754778203291669
(Some notes: range is "" instead of "melee" no price, some null <--> "" mismatches)

I tested it with a newly created item, and that has the same issues. So it seems to me an update to the new item structure is in order? And a macro that "fixes" old items?

Your "Loot generator" promises very well, is it possible to make it a separate module to make it work with other systems besides pf2 for example D&D5th ?

This error is displayed when trying to open PF2e toolbox settings
PF2e vs 2.10
foundry 0.8.8
PF2e toolbox 1.7.12

Toolbox wont work on new Pathfinder 2e Version[2.9.1.6656], doesnt show modules options and not showing Loot, macros none of 3 are working.

• Browser: Google Chrome [91.0.4472.124]
• FoundryVTT [0.8.8]
• PF2E Toolbox [1.7.8]
• Only Find The Culprit

Describe the bug
When creating a suit of armor via the loot sheet create item tab it looks like the Splint mail, Half-plate and Plate are missing from the list. Further you can create shields with armor potency rules which isn't how shields work.

To Reproduce
Steps to reproduce the behavior:

1. Create a lootsheet
2. Go to Create Item
3. Select Armor
4. Look at Base Item

Expected behavior
That you be able to make all types of armor and that shields wouldn't be on the list since they can't have runes.

Screenshots

Version Information:

• FoundryVTT 0.7.9
• Pathfinder 1.11.10.4003
• Toolbox 1.5.1

Additional context
Add any other context about the problem here.

PF2E Token tooltips
Darkling n 0057

Possible feature for the toolbox.
A token tool tip.

I've noticed there are several modules that add token tool tips but in my experience they either:

1. don't work in pf2e
2. are bundled with things that don't work with pf2e
3. they're annoying to configure

---

I don't actually think they're that useful myself but they seem like a popular feature, so a PF2e specific one might go down well.

If I try and add permanent items to the loot sheet you've added, I get the following error message:

This doesn't appear to happen with every possible level/number combination, but triggers e.g. for roll 2 2nd level items.

On the pf2e toolbox lootapp sheet the buttons to roll for random loot start at 4th level on the consumables list. I have uninstalled and reinstalled the module, as well as the base module, and turned off all other modules, but the bug has persisted. All the other lists are intact.

when loading the world I created, an error immediately crashes in the console. I use the PF 2e system

Describe the bug
Can't access the Configure Loot section of the pf2etoolbox loot sheet. Further existing loot sheet in my other game

To Reproduce

1. Create game/load in Toolbox by itself.
2. Create a Loot sheet, set it to the PF2eToolbox loot sheet.
3. Click on Configure Loot

Expected behavior
Should be bringing up the tabbed sections of useful tools like random treasure objects and creating properly priced magical weapons.

Screenshots

When I try to set a loot sheet to your version of the sheet I noticed this error:

When loading a existing loot sheet in my other game I get this error:

Version Information:

• FoundryVTT [e.g. 0.7.9]
• PF2E Toolbox [e.g. 1.7.1]
• Pathfinder 2e [1.13.2.5430]

Additional context

• Scroll Generator
• Random scroll roller
• Magic Weapon / Material Weapon
• Magic Armor / Material Armor

Describe the bug
When there is a lot of items in the loot sheet and you want to configure, there is no vertical scrollbar.

To Reproduce
Steps to reproduce the behaviour:

1. Create a loot sheet.
2. Place a bunch of different consumables (I believe it happen with other items, but I was creating a potion shop)
3. Check configure loot, the vertical scrollbar vanishes.

Expected behavior
The vertical scrollbar continued to be shown.

Screenshots

Version Information:

• Browser Firefox version 80.0.1
• FoundryVTT 0.6.6
• PF2E Toolbox 1.5.2

https://discordapp.com/channels/170995199584108546/697845559435853865/779465686928982026

Something like Grippli Späher or Charau-ka Schlächter. 😄 Tokens were named Charau-ka_Schlächter_01.png etc

Import from my current game into Toolbox

Tested with no mods (other than libwrapper just in case).

https://discordapp.com/channels/170995199584108546/697845559435853865/755895247829074041

Describe the bug
Prepared spellcasting slots disappear and are replaced by spellbook spells.

To Reproduce
Steps to reproduce the behavior:

1. Create a brand new npc
2. Use creature builder and give a spellcasting level of anything other that none
3. Add any prepared spellcasting type
4. Add a spell of any level
5. Close the character sheet
6. Open the character sheet

Expected behavior
Not hide all the prepared spells spells.

Screenshots

Version Information:

• Firefox Developer Edition 90.0b12 64-bit
• FoundryVTT [e.g. 0.8.8]
• PF2E Toolbox [e.g. 1.7.5]
• Activated Systems & Modules w/ Versions
  • too many

Additional context
Reported in base system as well may be base system related but is only reproduce able by using toolbox features.

Hey, I'm the author of the Hero Lab import tool. It was brought to my attention that my module's button disappeared from the character sheet title bar. After testing a bunch of modules, it turns out its this module that breaks it. It also breaks GM Notes module by preventing the button from being displayed.

I haven't looked too deeply yet, as I'm about to run a game, but this broke recently. I'm not sure if the issue lies in my code or in yours.

Describe the bug
The NPC Scaler isn't doing anything.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...' - When I import a creature from the compendium Bestiary
2. When I right-click the creature and scale it from "3 to 6"on
3. Scroll down to '....' - N/A
4. See error - There is no error message. There simply are no changes to the NPC.

Expected behavior
For there to be changes to the monster's/NPC's stats.

Screenshots
If applicable, add screenshots to help explain your problem.

Version Information:

• Browser [e.g. Chrome, Safari] version [e.g. 22]
• FoundryVTT v0.7.9
• PF2E Toolbox v1.12.0.5014
• Activated Systems & Modules w/ Versions - I have about 60... One of them is :PF2E Proficiency Without Level for NPCs." And the new PF2e module has a Proficiency Without Level setting and lets us "flatten" monster stats. Perhaps that's the culprit?

Additional context
Add any other context about the problem here.

Support relic creation inside the item creator

Describe the bug
NPC quick roller table is not showing

Version Information:

• Firefox 82.0
• FoundryVTT 0.7.5
• Pathfinder 2E 1.10.14.2141
• PF2E Toolbox 1.5.5

Since the latest update, 'Creature Builder' on the NPC sheet, as well as the 'Scale to level' and 'Flatten NPC' context menus are displayed twice.

Attached is a fix I did in bundle.js to check for duplicates. Obviously the right solution is to find out why its getting added twice ahead of time but in the meantime if anyone wants to use the attached go ahead.
bundle.zip

https://discord.com/channels/170995199584108546/697845559435853865/870866449944690758

No errors in the console

Most monsters with area damage have their area damage abilities scaled very weirdly. On some creatures like the sea drake it scales it with strike dmg instead of the area dmg table but with others it scales even weirder such as an adult magma dragon. I don't know if it is possible to have the module recognize area damage properly but I thought I would bring it up.

Describe the bug
When using flatten proficiency to subtract level from attacks you get the correct value on the attacks themselves (-level) but incorrect on the experimental version of the strikes, which subtracts level a second time. This is caused by the loop which reduces the base attack value in addition to adding a custom "Proficiency without Level" penalty to the NPC, which only the experimental strikes use and which causes the level to be subtracted a second time.

To Reproduce
Steps to reproduce the behavior:

1. Enable Flatten Proficiency in settings.
2. Choose an NPC with a level other than 0 in the actor tab.
3. Check strike values (i.e. a Grizzly Bear, a level 3 NPC, has +11 to strike with normal rules).
4. Right click and select "Flatten NPC".
5. Check strike values again...normal attack values will be +8 (11 base - 3 level) and experimental strike value will be +5 (11 base - 3 level from adjustment - 3 from Proficiency without Level modifier).

Expected behavior
Ideally both experimental strikes and normal strikes would work at the correct values when the creature is flattened. NOTE: I implemented a basic fix for my own use, code modification is below if you're interested (although it's not necessarily the best solution).

Screenshots
Normal View:

Flattened View (with bug):

Note that the experimental strikes are 3 lower than the normal strikes.
With my "fix":

Version Information:

• Electron browser (replicated on Chrome since it's a mechanics issue).
• FoundryVTT 0.7.9
• PF2E Toolbox 1.5.8
• Tested with all other modules deactivated as part of debugging.

Additional context
In my own version of the code I modified the buttons.unshift() functions for Flatten NPC in the following manner (the parts I removed are in comments here):

        name: 'Flatten NPC',
        icon: '<i class="fas fa-level-down-alt"></i>',
        condition: (li) => {
            const id = li.data('entity-id');
            const actor = game.actors.get(id);
            return actor.data.type === 'npc' && !hasModifier(actor);
        },
        callback: async (li) => {
            const id = li.data('entity-id');
            const actor = game.actors.get(id);
            const level = parseInt(actor.data.data.details.level.value);
            actor.addCustomModifier('all', modifierName, -level, 'untyped');
            // let itemUpdates = [];
            // for (let i = 0; i < actor.data['items'].length; i++) {
            //     const item = actor.data['items'][i];
            //     if (item.type === 'melee') {
            //         const oldAttack = parseInt(item.data.bonus.value);
            //         const newAttack = oldAttack - level;
            //         const attackUpdate = {
            //             _id: item._id,
            //             ['data.bonus.value']: newAttack,
            //             ['data.bonus.total']: newAttack,
            //         };
            //         itemUpdates.push(attackUpdate);
            //     }
            // }
            // await actor.updateEmbeddedEntity('OwnedItem', itemUpdates);
        },
    });

I did not include the second function because I removed the exact same block for both.

This fix works for me because I only use the experimental rolling method. I also tried changing the value of the modifier to 0 and only editing the strikes directly, but this removes all other level scaling (AC, saves, etc.). I'm not sure if this is a recent change in the Pathfinder 2e Foundry module that is causing this or if it's a long term bug and people just aren't messing with the option.

I do know that the core PF2e module does not support NPC scaling for proficiency without level, making that option of limited use. And ideal version for me would be a check box that would let me flatten or unflatten all NPCs automatically but I'll have to do some more research to find a solution for that.

Allow rolls on the PC sheet to be alt clicked to perform a blind roll

Describe the bug
Creature builder is no longer appearing on the menu

To Reproduce
Steps to reproduce the behavior:

1. Update to 0.8.6 Foundry, 2.0.2.5814 PF2E, and 1.7.2 Toolbox.
2. Open a NPC sheet/create a NPC sheet.

Expected behavior
You should see the creature builder when it is enabled.

Screenshots

Version Information:
Foundry 0.8.6
PF2E 2.0.2.5814
Toolbox 1.7.2

Additional context