dlanger / inlinestyler Goto Github PK

View Code? Open in Web Editor NEW

114.0 114.0 23.0 46 KB

A simple CSS inliner for generating HTML email messages.

Home Page: http://pypi.python.org/pypi/inlinestyler

License: BSD 3-Clause "New" or "Revised" License

Python 99.86% Makefile 0.14%

inlinestyler's People

Contributors

Stargazers

Watchers

inlinestyler's Issues

0.2.1+ no longer supports stylesheets in data URIs

It is possible to embed CSS inside the <style> element using the data: URI scheme. Like this:

<link rel="stylesheet" href="data:text/css,EMBEDDED_CSS_GOES_HERE">

This worked in 0.2.0, but doesn’t work in 0.2.1 with the move from urllib.urlopen() to python-requests.

It’d be nice to get this working again, though it’s arguably a requests issue.

I took a quick at requests, but I couldn’t determine if they have support for RFC 2397 (which defines the data: scheme).

I suggest leaving this bug open until either of us the time to investigate RFC2397 support in python-requests.

Silence warnings

Hi!

First of all - thanks for this really nice and helpful library!

It's not a bug, rather a feature request.

I'm getting tons of warnings like those:

WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.
WARNING	Property: Unknown Property name.

Is there a way to silence them? I couldn't find any verbose option.

Thanks!
Daniel

update pip package

Hey Daniel,

would you mind updating the package in the pip repository?
There's still the version that depends on django.

THX! :-)

Broken Python3 compatibility

Updating from 0.2.1 to 0.2.2 breakes on Python 3.4

File "/env/lib/python3.4/site-packages/inlinestyler/utils.py", line 17, in inline_css
    converter.perform(document, html_message, '', encoding=encoding)
File "/env/lib/python3.4/site-packages/inlinestyler/converter.py", line 62, in perform
    self.convertedHTML = etree.tostring(document, method="html", pretty_print=True).encode(encoding)
AttributeError: 'bytes' object has no attribute 'encode'

Version 0.2.2+ kills href attribute for link

Hello!

I use inlinestyler for preprocessing mustache-templates for emails.
Initial template has this link: <a href="{{config.url}}">Home</a>

And inline_css method encodes href: <a href="%7B%7Bconfig.url%7D%7D">Home</a>
After that mustache can't handle this template.

Version 0.2.1 doesn't have this issue. 0.2.2 and 0.2.3 - have

Crashes when bootstrap 3 css is included.

This code crashes with a NotImplemented exception.

from inlinestyler.utils import inline_css


html = """"

<!doctype html>
<html lang="en">
<head>

    <title>Charter 00144</title>
    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.css"/>
</head>"""

print inline_css(html)

Generated HTML has self-closing tags: disliked by GMail

When certain HTML tags are turned into self-closing versions (e.g. <title />), GMail considers the entire HTML as invalid and will not display it.

A quick workaround is to set method="html" in the etree.tostring call.
On a more philosophical note, I'm not certain if the HTML standard allows or disallows self-closing tags.

Empy line in stdout when using inline_css

I am using inlinestyler in one of my scripts. I got a new empty line each time I call my script, although I do not print anything. I found out that it happens when I use inline_css.

Why do we print here?:

https://github.com/dlanger/inlinestyler/blob/master/inlinestyler/converter.py#L41

Add background-size and other new CSS3 tags

I'm using some background-size styles and inliner spawns some sentry logs about it as this property isn't in the CSV file. Looking at https://www.campaignmonitor.com/css/ this and some other CSS3 tags are supported by something. Would be nice to expand the table of known CSS properties.

IOError: Too many open files

Hi,
I have been getting the following error:
IOError: Too many open files: '/usr/local/lib/python2.7/dist-packages/inlinestyler/css_compliance.csv'

I was running this in a loop (5000+) and that's when this happened.

Add PyPi classifers to indicate Python 3 support

Does this module currently support Python3?

It would be good to update the supported platforms list on the PyPi record so it's explicit if there's support there. Will be testing this out soon in any case, so will update this ticket if it's not known.

SSLError 'bad handshake'

I'm getting this fetching a css from anazon cloudfront

44 venv/local/lib/python2.7/site-packages/inlinestyler/converter.py in perform
raise IOError('The stylesheet ' + element.get("href") + ' could not be found') ...

If I curl the url causing the issue straight from the machine everything is fine.
Even with openssl:
openssl s_client -connect d1q7usoul9xakv.cloudfront.net:443 -CApath /etc/ssl/certs/
Start Time: 144489408
Timeout : 300 (sec)
Verify return code: 0 (ok)

I fixed the issue with a hack, but I don't think is perfect:
In converter.py

Before
css_content = requests.get(csspath).text

After:
css_content = requests.get(csspath, verify=False).text

Can you please let me know if there is a better way to sort out this issue?

lxml v5 breaks the lib

When updating lxml > 5 I've got AttributeError exception:

 'CSSSelector' object has no attribute 'evaluate'

 matching = CSSRelSelector.evaluate(document)

in this line: https://github.com/dlanger/inlinestyler/blob/master/inlinestyler/converter.py#L30

!important is not expanded

having a css like:
display: none !important;
will not add a style="display: none !important;" attribute to elements.
The !imporant part is omitted.
But it is useful: https://stackoverflow.com/questions/4013670/gmail-is-ignoring-displaynone

dlanger / inlinestyler Goto Github PK

inlinestyler's People

Contributors

Stargazers

Watchers

Forkers

inlinestyler's Issues

Recommend Projects

Recommend Topics

Recommend Org