Giter VIP home page Giter VIP logo

1pass's People

Contributors

dlokesh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

1pass's Issues

in `pbkdf2_hmac_sha1': no implicit conversion from nil to integer (TypeError)

$ 1pass --key mail.google.com
Enter your master password:  ********

/usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/decrypt.rb:26:in `pbkdf2_hmac_sha1': no implicit conversion from nil to integer (TypeError)
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/decrypt.rb:26:in `derive_pbkdf2'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/decrypt.rb:45:in `decrypt_pbkdf2'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/encryption_key.rb:27:in `unlock'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/encryption_key.rb:11:in `block in unlock'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/encryption_key.rb:11:in `collect'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/encryption_key.rb:11:in `unlock'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/keychain.rb:16:in `unlock'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/1pass.rb:18:in `load'
    from /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/bin/1pass:34:in `<top (required)>'
    from /usr/local/bin/1pass:23:in `load'
    from /usr/local/bin/1pass:23:in `<main>'

This is because iterations is nil in this function as shown below:

$ 1pass --key mail.google.com
Enter your master password:  ********

From: /usr/local/lib/ruby/gems/2.3.0/gems/1pass-0.1.2/lib/decrypt.rb @ line 26 Decrypt.derive_pbkdf2:

    24:     def self.derive_pbkdf2(password, salt, iterations)
    25:               require 'pry'; binding.pry
 => 26:         key_and_iv = OpenSSL::PKCS5.pbkdf2_hmac_sha1(password, salt, iterations, 32)
    27:         {key: key_and_iv[0,16], iv: key_and_iv[16..-1]}
    28:     end

[1] pry(Decrypt)> iterations
=> nil
[2] pry(Decrypt)> c

I have 1Password 6.3.1 on a Mac and my Ruby is:

$ ruby --version
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin14]

and my 1pass version:

$ gem list 1pass

*** LOCAL GEMS ***

1pass (0.1.2)

My 1Password keys are supposedly using 10,000 iterations:

$ cat ~/Dropbox/Library/Application\ Support/1Password/1Password.agilekeychain/data/default/encryptionKeys.js | jq '.list[] | {level: .level, iterations: .iterations}'
{
  "level": "SL5",
  "iterations": 100000
}
{
  "level": "SL3",
  "iterations": 100000
}

[Bug]: Testing new bug

Name: undefined
Email: undefined
Internal Tool: sadhak
Component: demand

Reporting new issue

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.