dn-m / math Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 1.0 109 KB

Helpful mathematical tools for music and graphics

License: MIT License

Swift 100.00%

math's Introduction

dn-m

Application targets for the dn-m project.

math's People

Contributors

Stargazers

Watchers

Forkers

ericsites

math's Issues

Move IntervalRelation to Structure

Then, nest within Interval.

Move RangeProtocol to Structure

Audit quadratic.swift compilation time

Similar to #37, there is a strangely long compilation time for quadratic.swift.

Remove Vector2 as it is already implemented in dn-m/Graphics/Geometry

Audit Scale.swift compilation time

It currently takes a strangely long time to compile Scale.swift, particularly given this file only contains two functions. This is felt downstream when building projects with Math as a dependency.

Conditionally import Glibc instead of assuming Darwin

Currently, there are four instances of importing Darwin:

-Sources/Math/LinearRegression.swift
-Sources/Math/Functions.swift
-Sources/Math/DoubleExtensions.swift
-Sources/Math/Quadratic.swift
-Sources/Math/Scale.swift

These are always for trivial functions like pow(_:_:). In order to serve Linux, conditionally import Glibc.

Move Bitwise from Structure

Now that we don't need the bitwise operations to manage InvertibleOptionSet (which is now taken care of by InvertibleEnum via the derived allCases), we can lift Bitwise up to the Math level, rather than having it nestled within Structure (which felt strange).

Use Built-in Random

With SE-0202: Random Unification Swift 4.2 brings a well-designed, safe, and flexible random number generation API.

Either utilize this new API within our RandomProducing protocol, or remove the protocol entirely.

Note that Swift 4.2 is not yet released.

Let compiler synthesize Equatable for free

Reimplement Rational: Hashable conformance with hash(into:)

Using .hashValue is deprecated. This causes warnings to pop up not just in the Math module, but in all downstream modules, as well.

Rename PowerSequence to PowerOfTwoSequence

Add a free function:

func powersOfTwo <T: FixedWidthInteger> (coefficient: T = 2, max: T = T.max, overshooting: Bool = false) -> PowerOfTwoSequence<T>

[Swift 5] Use BinaryInteger.isMultiple(of:)

Currently, there exists here BinaryInteger.isDivisible(by:), upon which .isEven and .isOdd are implemented.

With SE-0225, BinaryInteger.isMultiple(of:) will exist in the stdlib. Use this instead, for the reasons used in the review.

This will only be applicable as of Swift 5.