The dnbtestdata from dnbbank

dnbtestdata's People

Contributors

Stargazers

Watchers

dnbtestdata's Issues

Is prod data used to generate test data? And is that ok?

Just out of curiosity I browsed the list of last names and found my name on the list. Being a customer of DnB I couldn't help but think that this list is generated from your list of customers. If it was, is that ok in a post GDPR world? If not, how did you generate or retrieve these names?

Gender is slightly off for some people

Arne is female .. or is he?

$ create_people.py -n 1
[
  {
    "ssn": "01037843751",
    "firstName": "Arne",
    "lastName": "Edvardsen",
    "dateOfBirth": "1978-03-01",
    "gender": "Female",
    "nationality": "Norwegian",
    "address": {
      "street": "Evensengropa 00",
      "postalCode": "8187",
      "city": "Haugland",
      "country": "NO"
    },
    "phoneNumber": "92395941",
    "email": "[email protected]",
    "idType": "passport"
  }
]

I made a branch and tried to make a PR, but it seems I lack permissions*. So, here's a new _NorwegianName for models/person/elements/name.py that does not always select male names:

class _NorwegianName:
    fake = Faker('no_NO')

    @classmethod
    def generate_random_first_name(cls, gender):
        if gender == gender.MALE:
            return cls.fake.first_name_male()
        elif gender == gender.FEMALE:
            return cls.fake.first_name_female()
        else:
            raise Exception()

    @classmethod
    def generate_random_last_name(cls):
        return cls.fake.last_name()

*: Permission error:

$  git push --set-upstream origin not-all-arnes-are-female
remote: Permission to DNBbank/dnbtestdata.git denied to cloveras.
fatal: unable to access 'https://github.com/DNBbank/dnbtestdata.git/': The requested URL returned error: 403

Recommend Projects