dnncommunity / dnn.iframe Goto Github PK

When using a URL the module thinks is invalid, and the checkbox is checked, and settings are saved.

Re-open the settings, and make a settings change. Example: modify the CSS styles.

When trying to save, you are told the URL is invalid, and not allowed to save your settings

If you want to save, you must un-check the box to disable validation, and re-check it. Then you are allowed to save.

Am I missing something or is there no release and upgrade package with the latest releases?

Install Stops after clicking next on step 4 of 5 , the progress bar goes about half way , stops and pauses, then an ! appears with no message.

Describe the bug

Error: UserReg - FIGU in a Nutshell is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Value cannot be null. Parameter name: source ---> System.ArgumentNullException: Value cannot be null. Parameter name: source at System.Linq.Enumerable.Count[TSource](IEnumerable`1 source) at DotNetNuke.Modules.IFrame.UI.IFrame.get_Source() at DotNetNuke.Modules.IFrame.UI.IFrame.Page_Load(Object sender, EventArgs e) --- End of inner exception stack trace -

To Reproduce

Steps to reproduce the behavior:

1. Go to 'https://creationaltruth.org/Home/Website-User-Registration'
2. See error

Expected behavior

IFrame should appear with selected pdf file displayed instead error shows up.

I just upgraded from IFrame 03.02.03 to 04.05.00 and the upgrade was successful. However, upon visiting a page with an instance of the IFrame module on it, it would throw an exception as follows:

\DesktopModules\IFrame\IFrame.ascx.vb(58): error BC30560: 'Controller' is ambiguous in the namespace 'DotNetNuke.Modules.IFrame'.

From there, I decided to look at the DLLs in the bin folder and noticed they had not changed upon upgrade. Therefore, I removed them and performed a "Repair" install on the module. That fixed it and no new DLLs are even used in this module anymore it seems. ;-)

Describe the bug

iFrame instances with parameters no longer appear to have any parameters (on Parameters tab) although they still exist in database (IFrame_Parameters table).

To Reproduce

1. Go to an iFrame module which had parameters defined
2. Access 'Edit Options'
3. Check Parameters tab

Expected behavior

Pre-existing parameters still to be there and operable.

Screenshots

Error log

Attempting to re add a parameter fails (but could be because it already exists?) with:

Error: is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Exception has been thrown by the target of an invocation. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object. at DotNetNuke.Modules.IFrame.Components.ParametersInfo.get_PortalInfo() --- End of inner exception stack trace --- at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments) at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) at System.Reflection.RuntimePropertyInfo.GetValue(Object obj, Object[] index) at PetaPoco.Database.PrepareExecuteInsert(String tableName, String primaryKeyName, Boolean autoIncrement, Object poco, PocoData pd, List1 names, List1 values, IDbCommand cmd) at PetaPoco.Database.ExecuteInsert(String tableName, String primaryKeyName, Boolean autoIncrement, Object poco) at PetaPoco.Database.Insert(Object poco) at DotNetNuke.Data.RepositoryBase`1.Insert(T item) at DotNetNuke.Modules.IFrame.Components.ParametersController.AddParameter(ParametersInfo parameter) at DotNetNuke.Modules.IFrame.UI.IframeOptions.UpdateParameterButton_Click(Object sender, EventArgs e) --- End of inner exception stack trace ---

Additional context

This is on DNN 9.4.1 with iFrame 8.1.2 - but I believe it started at DNN 9.4.0 with iFrame 8.1.1 (Ok at DNN 9.3.2, iFrame 8.1.1)

@EPTamminga - the VS project files seem to be missing on this project. Can you please advise? Thanks!

We need new issue templates for each issue type.

We need to add a pull request template to be consistent with the other DNN Community repos.

DNN 90202
trying to install
DotNetNuke.Modules.IFrame.08.01.02.pa

StartJob Reading files

Info File App_LocalResources\IFrame.ascx.resx read successfully
Info File App_LocalResources\IFrameOptions.ascx.resx read successfully
Info File App_LocalResources\SharedResources.resx read successfully
Info File bin\DotNetNuke.Modules.IFrame.dll read successfully
Info File DNN_IFrame.dnn read successfully
Info File Documentation\License.html read successfully
Info File Documentation\ReleaseNotes.html read successfully
Info File IFrame.ascx read successfully
Info File IframeOptions.ascx read successfully
Info File images\icon_iframe_16px.png read successfully
Info File images\icon_iframe_32px.png read successfully
Info File Module.css read successfully
Info File Providers/DataProviders/SqlDataProvider\03.02.00.SqlDataProvider read successfully
Info File Providers/DataProviders/SqlDataProvider\04.03.00.SqlDataProvider read successfully
Info File Providers/DataProviders/SqlDataProvider\08.00.00.SqlDataProvider read successfully
Info File Providers/DataProviders/SqlDataProvider\UnInstall.SqlDataProvider read successfully
EndJob Reading files done.
StartJob Reading Installation Manifest file
Info Reading Package Manifest - Module - DNN_IFrame
Failure A dependent component is not installed - System.Data.SqlClient.SqlColumnEncryptionEnclaveProvider

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

1. Install DNN.IFrame 08.01.01 in DNN 09.04.01
2. Add IFrame module to a page
3. Edit Options and Update
4. See errors on-page and in MANAGE > Admin Logs

Expected behavior

No errors.

Screenshots

Error log

Error Number 1

10/11/2019 19:29:59
General Exception
host 
DNN 09.04.01 
AbsoluteURL /Default.aspx DefaultDataProvider DotNetNuke.Data.SqlDataProvi 
AbsoluteURL:/Default.aspx

DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke

ExceptionGUID:cfaad374-9d68-40b1-bafb-3045ba10a6ea

AssemblyVersion:

PortalId:-1

UserId:-1

TabId:-1

RawUrl:

Referrer:

UserAgent:

ExceptionHash:11leUp3OBtTle2lQkWbW7E1Kj40=

Message:Invalid column name 'ModuleController'. Invalid column name 'ModuleInfo'. Invalid column name 'PortalController'. Invalid column name 'PortalInfo'.

StackTrace:

   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
   at System.Data.SqlClient.SqlDataReader.get_MetaData()
   at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted)
   at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
   at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry)
   at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)
   at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method)
   at PetaPoco.Database.<ExecuteReader>d__149`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at DotNetNuke.Common.Utilities.DataCache.GetCachedDataFromRuntimeCache(CacheItemArgs cacheItemArgs, CacheItemExpiredCallback cacheItemExpired)
InnerMessage:

InnerStackTrace:

Source:.Net SqlClient Data Provider

FileName:

FileLineNumber:0

FileColumnNumber:0

Method:

Error Number 2

10/11/2019 19:29:59
Module Load Exception
host 
DNN 09.04.01 
ModuleId 380 ModuleDefId 122 FriendlyName IFrame ModuleControlSource Deskt 
ModuleId:380

ModuleDefId:122

FriendlyName:IFrame

ModuleControlSource:DesktopModules/IFrame/IFrame.ascx

AbsoluteURL:/Default.aspx

DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke

ExceptionGUID:137a9ff5-0ec8-4938-a477-daccc3772a41

AssemblyVersion:9.4.1

PortalId:0

UserId:1

TabId:33

RawUrl:/iFrame-Test

Referrer:http://dnn941.loc/iFrame-Test

UserAgent:Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36

ExceptionHash:TwWAxm98R9QTkOUFMYeFJzEpL7E=

Message:Value cannot be null. Parameter name: source

StackTrace:

InnerMessage:Value cannot be null. Parameter name: source

InnerStackTrace:

   at System.Linq.Enumerable.Count[TSource](IEnumerable`1 source)
   at DotNetNuke.Modules.IFrame.UI.IFrame.get_Source()
   at DotNetNuke.Modules.IFrame.UI.IFrame.Page_Load(Object sender, EventArgs e)
Source:

FileName:

FileLineNumber:0

FileColumnNumber:0

Method:

Additional context

Fresh install of DNN 09.04.01

I'm attempting to install this on DNN 9.1.1 and I'm getting this error:

StartJob Reading files Info File .gitignore read successfully Info File App_LocalResources\EditIFrame.ascx.resx read successfully Info File App_LocalResources\IFrame.ascx.resx read successfully Info File App_LocalResources\IFrameOptions.ascx.resx read successfully Info File App_LocalResources\SharedResources.resx read successfully Info File Components\IFrameBase.cs read successfully Info File Components\ParametersController.cs read successfully Info File Components\ParametersInfo.cs read successfully Info File DNN_IFrame.dnn read successfully Info File Documentation\License.html read successfully Info File Documentation\ReleaseNotes.html read successfully Info File IFrame.ascx read successfully Info File IFrame.ascx.cs read successfully Info File IFrame.ascx.designer.cs read successfully Info File IFrame.csproj read successfully Info File IframeOptions.ascx read successfully Info File IframeOptions.ascx.cs read successfully Info File IframeOptions.ascx.designer.cs read successfully Info File images\icon_iframe_16px.png read successfully Info File images\icon_iframe_32px.png read successfully Info File LICENSE read successfully Info File Module.css read successfully Info File packages.config read successfully Info File Properties\AssemblyInfo.cs read successfully Info File Providers/DataProviders/SqlDataProvider\03.02.00.SqlDataProvider read successfully Info File Providers/DataProviders/SqlDataProvider\04.03.00.SqlDataProvider read successfully Info File Providers/DataProviders/SqlDataProvider\08.00.00.SqlDataProvider read successfully Info File Providers/DataProviders/SqlDataProvider\UnInstall.SqlDataProvider read successfully Info File README.md read successfully EndJob Reading files done. StartJob Reading Installation Manifest file Info Reading Package Manifest - Module - DNN_IFrame Info Reading Component Manifest - Config Info Reading Component Manifest - Cleanup Info Reading Component Manifest - Cleanup Info Reading Component Manifest - Script Info Found valid path (Providers\DataProviders\SqlDataProvider) for 03.02.00.SqlDataProvider. Info Found valid path (Providers\DataProviders\SqlDataProvider) for 04.03.00.SqlDataProvider. Info Found valid path (Providers\DataProviders\SqlDataProvider) for 08.00.00.SqlDataProvider. Info Found valid path (Providers\DataProviders\SqlDataProvider) for Uninstall.SqlDataProvider. Info Reading Component Manifest - Module Info Module Manifest read successfully Info Reading Component Manifest - Assembly Failure File specified in the dnn could not be found in the zip file: - **C:\websites\Evoq\Install\Temp\1ugfykzm\bin\DotNetNuke.Modules.IFrame.dll** Info Reading Component Manifest - File Info Found valid path () for DNN_IFrame.dnn. Info Found valid path () for IFrame.ascx. Info Found valid path () for IFrameOptions.ascx. Info Found valid path () for Module.css. Info Found valid path (App_LocalResources) for IFrame.ascx.resx. Info Found valid path (App_LocalResources) for IFrameOptions.ascx.resx. Info Found valid path (App_LocalResources) for SharedResources.resx. Info Found valid path (Documentation) for License.html. Info Found valid path (Documentation) for ReleaseNotes.html. Info Found valid path (images) for icon_iframe_16px.png. Info Found valid path (images) for icon_iframe_32px.png. Info Found valid path (Providers\DataProviders\SqlDataProvider) for 03.02.00.SqlDataProvider. Info Found valid path (Providers\DataProviders\SqlDataProvider) for 04.03.00.SqlDataProvider. Info Found valid path (Providers\DataProviders\SqlDataProvider) for 08.00.00.SqlDataProvider. Info Found valid path (Providers\DataProviders\SqlDataProvider) for Uninstall.SqlDataProvider.

This URL use to work fine using the iFrame module on DNN 7. I tried it on the DNN 9.1.1 and I am getting an invalid URL error. We use links like this to show a Google map on pages.

https://www.google.com/maps/embed?pb=!1m18!1m12!1m3!1d3192.788816874289!2d-76.29352088440305!3d36.847533472732984!2m3!1f0!2f0!3f0!3m2!1i1024!2i768!4f13.1!3m3!1m2!1s0x89ba980c600a4aad%3A0x7d2f74977acdd0af!2s150+Granby+St%2C+Norfolk%2C+VA+23510!5e0!3m2!1sen!2sus!4v1512680540910

Hi guys,

I faced an issue when i wanted to install the module on an dnn-website with a standard other language,
can i just add the additional resx files made for the other languages, or is there an other way?

Thanks in advance, else its a very handy module

i'm trying to embed a url to website built on top of DNN using iFrame module(DNN.IFrame 08.00.02) but it says that the url is not valid. when i tried embedding the same url using former versions of iFrame(4.4.0), it worked fine. This is the url i'm trying to embed "https://platform.remix.com/map/994739e?latlng=43.10473,-77.4392,

z10.5". Thanks in advance!

Description

A feature policy enables and disables certain web platform features on the web site and those that are embedded. The attribute "allow" in the iframe tag may override this policy.

Example:

feature-policy: vibrate 'self';
...
<iframe src="https://somewhere.else" allow="vibrate">

Solution

A module setting to define the "allow" value.

Hi, I've find out that the validator algorithm does not accept port defined in URL.
Ex.: http://localhost.com:8080/

This regex should make it work as intended
http(s)?://([\w-]+.)+[\w-]+(:\d+)?(/[\w- ./?%&=,!+]*)?

I've also find out that the validation does occour also if the check-box is flagged.
To reproduce this last issue:

1. Define an invalid URL (with port number)
2. Check the 'Ignore source validation' checkbox
3. Update and exit
4. Enter again in edit mode, the box is flagged
5. Update and exit and notice the URL validator behaviour

Thank you.

Describe the bug

Refuses to connect

To Reproduce

Steps to reproduce the behavior:
Go through settings, indicate url and dimensions save site refuses to connect.
replaced original URL with Google.com and also refuses to connect
Tried another site worked but auto vertical sizing did not work.
the above was using new install dnn v9.02 however, all of the above worked fine on dnn v8.0.4
iframe version 8.1.1

No event errors