The encryption/encoding in coder.go are a mess. Rework to make it more clear.

If possible, at streaming support, especially for file download.

Should be able to tunnel via SOCKS5 on server.

Issues

MakeCampaign() in pkg/campaign/campaign.go uses scrypt.Key() with a fixed salt and a N (cost parameter) that's way too small.

Solution

According to the scrypt docs, N should be 32768 as of 2017 (or about 100ms to derive the hash). So as of 2021, N should be 65536. The salt should be random and at least 8 bytes long. To create the salt consider using something like the function below, as seen here.

import(
	"crypto/rand"
	"errors"
)

func GetSalt(n int) ([]byte, error) {
	if (n < 8) {
		return nil, errors.New("The salt must be at least 8 bytes long.")
	}
	b := make([]byte, n)
	_, err := rand.Read(b)
	return b, err
}

Currently there are two or three windows APIs used:

• arch_windows.c: Reflexxion system calls stubs (direct syscalls)
• inject/: from go-inject, to perform process injection
• syscalls/: from sliver, to perform sliver related stuff like donut shellcode injection

At least merge inject/ and syscalls/. Preferable replace with direct syscalls in pure go, if possible.