dod38fr / config-model-tk-ui Goto Github PK

Currently, a value modification is done in 2 steps:

• the "store" button on the right side store the modified value from the widget to the configuration tree in memory
• then the configuration tree is saved to configuration file on demand or when quitting (after a user confirmation)

It would be handy in some case to have an auto-save mode (configurable with a menu or a check button) to save directly to file when a value is stored.

This mode can use on_change_cb parameter to register a call-back that will call Config::Model::TkUI::save.

In wizard, when clikcing on delete to remove an entry with warning, the reload method is called on MainWindow. This causes an exception

Hi Dominique,

another thing DUCK found:

/home/abe/pkg-perl/git/packages/libconfig-model-tkui-perl
E: debian/control: Homepage: http://config-model.wiki.sourceforge.net: ERROR (Certainty:certain)
   Curl:0 HTTP:404 No error

https://github.com/dod38fr/config-model-tk-ui/blob/master/dist.ini says:

homepage = https://github.com/dod38fr/config-model-tkui/wiki

But that gives a 404, too.

I noticed the tkui vs tk-ui, but https://github.com/dod38fr/config-model-tk-ui/wiki doesn't exist either.

Would you be so kind to have a look at these things, too?

TIA!

Some common key binding like ctrl-q ctrl-s would be useful to improve usability

Step to reproduce:

• select a leaf value
• copy the value (menu Edit->copy)
• select another value
• paste the value (menu Edit->paste)

The leaf view widget (on the right side) is not updated immediately.

Steps tp reproduce:

• run cme edit-dpkg-patch xxx
• add a Debian bug entry using URL copied from browser (e,g https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768073)
• tktree shows a warning
• open edit value and clieck on apply fix
• hash element is opened by tktree
• hash element shows a warning sign (should be empty)
• hash value of bug shows no warning sign (which is correct)

Need to remove the shown warning sign

This would improve usability of GUI for list parameters that often have one element (e.g. alias in /etc/hosts)

When I run "cme edit dpkg" or similar, the Tk GUI editor font is very tiny on my 3200x1800 laptop screen. Is there any way to adjust this?

Currently the menu entry "reload" reloads the tree on the left side (a Tk::Tree) using data loaded in memory.

Another menu entry to reload from configuration data would be helpful.

Notes:

• need to check for unsaved changes before reloading though
• may need to create a new instance (See Config::Model::Instance) to reload new data
• this offers the possibility to keep the old instance around if user wants to go back...

How to reproduce:

• run perl -Ilib t/config-model-ui.t i
• double-click on "a_long_string"
• add random text
• hit

Hitting should create a new line in the text window.
Unfortunately, hitting close the text editor and selects an item in the tree list on the left.

The problem is: the keystroke is used by the Tk::HList widget as a select command. The binding should go to the Tk::Text widget instead.

The GUI of the left side should give a visual clue about the content of a hash or list when the item
is closed (i.e. with the '[+]' sign).

Possible ideas:

• use a different font (light) when the element is empty
• indicates the nb of element (ie. (0) (1)or (4) ... )

The current button "show only custom values" is fine, but is not practical to explore the values of a systemd configuration: all values are loaded from system files, are stored in a sub layer and are shown as default value. As a consequence, enabling "show only custom values" hides these values so a config like network-manager.service appears to be empty.

list of nodes are shown like:

[+] 1
[+] 2
[+] 3

this is not helpful to find what's inside.

Model should support a way to specify what to display in the list above so that user knows where to click to find the data he's interested in. Something like a surrogate key used in DB.

Systemd has a gazillion parameters and finding the right one can take some time.

The current search mechanism does not help because systemd documentation is also searched: the search returns a lot of false positives.

The UI needs a way to filter the parameters using a pattern (or a substring)

Reproduce:

• cme edit ssh
• click on "show only custom value" check button (top tight)
• open one host
• all values are shown, should show only custom values

After upgrading Config-Model from 2.136 to 2.137 t/config-model-ui.t fails like this:

ok 49 - test always_warn 43
not ok 50 - warn test always_warn 2 44
#   Failed test 'warn test always_warn 2 44'
#   at t/config-model-ui.t line 177.
# found warning: Warning in 'always_warn': Always warn whenever used
# expected to find warning: (?^:always)
# expected to find warning: (?^:always)
ok 51 - test remove always_warn 45
ok 52 - test warn_unless 46
not ok 53 - warn test warn_unless 47
#   Failed test 'warn test warn_unless 47'
#   at t/config-model-ui.t line 187.
# found warning: Warning in 'warn_unless': value should match regexp 'foo'
# expected to find warning: (?^:warn_unless)
# expected to find warning: (?^:warn_unless)
ok 54 - test fix warn_unless 48

From Config-Model-2.137 Changes:

2.137 2019-12-01
[...]  
    * Value: do not store warnings from computed value
[...]
    * Value: provide has_warnings along has_warning