dofinity / pelecard Goto Github PK

I guess that t() function is from Drupal.
It would be nice to remove Drupal dependency for people who use this package with other CMS or plain PHP.

Script:

$terminal = 'XXXXXXXXX';
$user = 'XXXXXXXXX';
$password = 'XXXXXXXXX';

$PelecardTransactionId = 'XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX';
$PelecardStatusCode = '000';
$ConfirmationKey = 'XXXXXXXXXXXXXXXXXXXXXXXXXX';
$Total = 100;

$PaymentResponse = new \Pelecard\PaymentResponse(
    $PelecardStatusCode, $PelecardTransactionId, '', '', $ConfirmationKey, $Total
);

$payment = new \Pelecard\PelecardPayment();
$payment->setPaymentResponse($PaymentResponse);
$transaction = new \Pelecard\PelecardTransaction(
    $terminal, $user, $password, $PelecardTransactionId
);
$clearerName = $transaction->getClearerName();

Output

Fatal error: Uncaught Error: Call to undefined function Pelecard\t() 
in \vendor\dofinity\pelecard\src\Pelecard\PelecardTransaction.php:178

From offical documentation:

QAResultStatus

Allows us to simulate good/error response for transaction.
Example:
To get a success response we will send 000
To get false response we will send the status code we want to simulate

There is no way to set this parameter in \Pelecard\PaymentRequest class.

i see there is no documentation for how to use this library, so can you please make documentation on this?
I'm sorry i have to create an issue because there is no option like comments here.

Official manual contains Appendix B – Error Code List section. It seems to me that Pelecard API returns only english error messages even when payment page has been configured with hebrew locale.

Suggested solution

Hardcode hebrew error messages from official manual into external PHP class. I can submit PR, it's almost ready if nobody have other ideas.

My implementation looks like:

use Pelecard\PelecardPaymentStatus;

$status = new PelecardPaymentStatus('010', 'he');
$status->getMessage();
// output:
// תוכנית הופסקה עפ"י הוראת המפעיל (ESC) או COM PORT לא ניתן לפתיחה (WINDOWS).

Option to change timeouts would be great.

5 and 10 seconds isn't optimal for all servers.