dolbyio / comms-sdk-cpp Goto Github PK

With this piece of code:

#include <dolbyio/comms/sdk.h>
#include <cstdio>

int main() {
  auto cppsdk = dolbyio::comms::sdk::create(token, [](auto&&) {});

  cppsdk->conference()
      .add_event_handler([](const dolbyio::comms::audio_levels&) {})
      .on_error([](auto&&) {});

  cppsdk->session()
      .open({})
      .then([sdk = cppsdk.get()](auto&&) {
        return sdk->conference().demo(
            dolbyio::comms::spatial_audio_style::disabled);
      })
      .on_error([](auto&&) {});

  while (getchar() != 'q') {
  };
}

The application will crash on exit instead of exiting cleanly.

managing audio_level to create a vumeter requires you to create a thread and constantly poll volume level apis
https://api-references.dolby.io/comms-sdk-cpp/api/sdk/conference.html?highlight=level#_CPPv4N7dolbyio5comms8services10conference20get_all_audio_levelsEv
https://api-references.dolby.io/comms-sdk-cpp/api/sdk/conference.html?highlight=level#_CPPv4N7dolbyio5comms8services10conference15get_audio_levelERKNSt6stringE

it would be better to have a configurable event so the sdk can manage this for me.
for example:
set the event interval get_all_audio_levels(int interval)
register callback virtual async_result<event_handler_id> add_event_handler(event_handler<dolbyio::comms::audio_level> &&callback)=0

Got this error when trying to launch desktop_app:
dyld[92874]: Library not loaded: '/Users/dolbyvoice/builds/dDLzDfbp/1/voxeet/cpp/sdk/ext-lib/macos/ffmpeg/lib/libavcodec.58.dylib'

I set the LD_LIBRARY_PATH pointing to the sdk-release/lib where it does have that library.