donien / ansible-collection-icinga_contrib Goto Github PK

It would be nice to be able to supply custom graphs.ini files. Since providing own dashboard definitions in form of files is already possible, it might be reasonable to bundle those definitions with custom graphs.ini files.
(Thinking of Icinga for Windows for example)

We could read those files, parse them and merge them with icingaweb2_modules.grafana.config.graphs to make using existing configurations easier (no need to retype/convert to YAML).

Alternatively we could concatenate the rendered template with those graphs.ini files to create the actual graphs.ini that will be deployed.

We should change the way modules are handled a little.

We could add a default git url to each known module. When also setting git as the default source users only need to define the name of a module as a key to icingaweb2_modules in order to install the module.
Modules like mapDatatype would benefit since no configuration is needed anyway.

Of course we'd need to shuffle some code around to do so.

The key icingaweb2_modules.grafana.config.graphs is not passed to the template when deploying graphs.ini.
Instead _module.graphs is passed which effectively is icingaweb2_modules.grafana.graphs, e.g. missing the config part.

https://github.com/Donien/ansible-collection-icinga_contrib/blame/f2a7d1d9da3cb7cb5a52e774ca8fb5bca8a6ae42/roles/icingaweb2_modules/tasks/configure_grafana.yml#L64

Currently the installation from git creates module/git directories with permissions

drwxrwxrwx 9 root     root       4096 May 29 19:33 grafana

which allows normal users to temper with the installation.

We need to change this to be in line with other modules.

drwxr-xr-x 6 root     root       4096 May 29 18:14 icingadb