doomemacs / themes Goto Github PK

(setq doom-enable-bold t
     doom-enable-italic t

     doom-one-brighter-modeline t ;; doom one specific
     doom-one-brighter-comments t);; commands
(add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)

this is my current setting
however comments are not hightlighting

When I try to install the theme from package-lsit-package, it fails with the message:

package-compute-transaction: Package ‘font-lock+-0’ is unavailable

Thanks for your work 👍

It would be nice to have pos-tip support
There is an example code

   `(pos-tip-foreground-color ,foreground)
   `(pos-tip-background-color , background)

This is the screenshot which doom-one theme has issue that some org-mode headlines are not colored.

And some org-mode faces like org-priority are not customized.
Hope you can add support to all org-mode faces from customize-group org-faces.

Without doom-buffer-mode, the doom-one theme's background is too dark (my screenshots don't show this, which may be misleading) and there isn't enough contrast between background and modeline. This is an unreasonable default for users.

Fix this future me!

I've been using doom-theme and it's been BY FAR the best theme I've used in vim or emacs (nice work, this is awesome!)

I have experienced one issue: the line width for org-level-1 makes the font do weird things when you move your cursor through it (I've attached an animated gif):

I tested by removing this from my local copy ((:line-width 4 :color ,current-line)) and I get what I expect:

I don't really know what's going on here, but I was wondering if you experienced it as well.

I've added the following to my init.org to override it temporarily and as a measure to help anyone else who may experience it in the meantime:

#+BEGIN_SRC emacs-lisp
(custom-set-faces
  '(org-level-1 ((t (:line-width 1))))
)
#+END_SRC

I am probably doing something wrong, and error is on my part, so sorry for that in advance.
When I copy all files from repo to my theme sourced directory and try load-theme it gives
me the next error message:

Cannot open load file: No such file or directory, doom

So does it mean I need few more packages to install that aren't mentioned in description or just dash?

Great theme 👍

I saw in this issue that someone also had a transparent modeline, I've followed the instructions you gave and added a core-modeline.el file to my .emacs.d.

But still nothing, I assume I'm missing a way to tell spacemacs to use my custom modeline file?

I have enabled dired-x and what were nice colors before turned into a more funky version ;)

Hi! First of all thanks for the theme, I simply love it :)
Would it be possible requesting a color scheme based on Nova for vim? https://trevordmiller.com/projects/nova
If you don't have the time for it, I could work on a PR for adding it following this basic color list described here https://github.com/trevordmiller/nova-colors/blob/master/src/index.js
What do you think?

As the title described.
Here is the idea: https://github.com/wasamasa/eyebrowse#quick-tutorial

Hi,

Thanks for good theme! I have only one issue with default emacs - inactive modeline has the same color as background, making it difficult to visually distinguish.

Hello !

I've been looking you're package for some time now on twitter, and decided to give a try: I love it ! I will definiltly switch from spacemacs-theme to doom-light-one. Even though it is still a little be less designed and exhaustive.

As an example: rainbow delimiters are not honoured. I always fall back to the unmatched face. According to your code, it should be blue on the screenshot, but it's red.

Do you think it is possible to support Gnus faces ?

When I try to install doom-themes from MELPA stable I get an error:

M-x package-install RET doom-themes RET
Package ‘font-lock+-0’ is unavailable

Hi,

Thank you for the excellent theme, however i am facing a background color issue when i open emacs in ITerm or Terminal. Emacs is getting loaded with a blue background. Emacs version is 25.1. Not sure if this is an issue with the theme or some emacs customization issue.

Multiple cursors selection works and multiple regions are highlighted whereas adding new cursors don't show up. The cursors are there just not highlighted.

Very nice themes !
Do you plan to support the one light version ?

Many thanks for those awesome themes :)

Is changing vc-modified face to grey an intentional change? The grey color is incredibly hard to pick out in the fringe, whereas the previous yellow color stood out much better. Thanks!

Thanks for the great colors! I really like the level 1 and 2 org mode headings. At first I couldn't figure out why I wasn't getting the background color across the whole line. Then I discovered the org-fontify variables. You might suggest setting these in the readme.

(setq org-fontify-whole-heading-line t
      org-fontify-done-headline t
      org-fontify-quote-and-verse-blocks t)

edit: add org-fontify-quote-and-verse-blocks variable

They are out of date.

• Update neotree screenshots (with (setq doom-neotree-file-icons 'simple) and new variable-pitch labels)
• Update full screenshot for doom-one (a lot has changed)

Currently doom theme defines things like:

     ;; Custom (doom)
     `(doom-modeline-buffer-path       ((,c (:foreground ,white :bold ,bold))))
     `(doom-modeline-buffer-project    ((,c (:foreground ,fg))))
     `(doom-modeline-buffer-modified   ((,c (:foreground ,blue))))
     `(doom-modeline-buffer-major-mode ((,c (:foreground ,white :bold ,bold))))

     `(doom-modeline-highlight     ((,c (:foreground ,blue))))
     `(doom-modeline-panel         ((,c (:foreground ,black :background ,blue))))
     `(doom-modeline-bar           ((,c (:background ,blue))))
     `(doom-modeline-eldoc-bar     ((,c (:background ,yellow))))

     ;; Powerline/Spaceline
     `(spaceline-highlight-face    ((,c (:inherit doom-modeline-panel))))
     `(powerline-active1           ((,c (:inherit doom-modeline-panel))))
     `(powerline-active2           ((,c (:inherit doom-modeline-highlight))))
     `(powerline-inactive1         ((,c (:inherit mode-line-inactive))))
     `(powerline-inactive2         ((,c (:inherit mode-line-inactive))))

However, since the doom-modeline-panel (all doom-modeline-* faces) don't exist, the spaceline/powerline faces end up referencing a face that does not exist. This causes the modeline to be entirely uncolored, like:

I think the faces need to be created somewhere, as evaling the custom-theme-set-faces s-exp doesn't create them. This is also necessary since your custom modeline does not exist in an installable package, so it's not marked as a dependency for this theme.

The header is hard to read, and the date is inconsistent with the header face.

Screenshot:

Hi,
using the neotree integration, i've got icons like in the screenshots for folders, but no icons for files.
Any idea ?

The ediff-odd-diff-B (A, B, and C) faces are using light grey as a background, which is very difficult to read.

Additionally, the highlighted changes (green ones) are a bit too bright to read when looking at a particular change.

Here's a screenshot showing what I'm talking about:

Hi,

I find it quite annoying to have the left-fringe and right-fringe background colors different than the main bg defined in the theme.

Screenshots:

The first 2 images show left fringe background color and right-fringe background color. The third one however shows how line highlight color is the same as both fringe background colors. I think we can just keep the same color for current line if we just unify both fringes with the main bg.

Wish i could be as good as you are with elisp, i would have posted a PR, but am getting there so maybe i can get to help in the near future.

Thanks alot!

Hello!

First of all, this is more of a question than an issue, sorry for that.

I like the thin line git gutter indicators so I tried implementing them in my emacs config. I noticed that on my emacs the fringe is drawn after the line numbers, whereas in your screenshot the thin lines are drawn on the left of the line numbers.

I find this behavior quite uncomfortable, so my question is, how do I make the lines appear on the left of the line number?

Here is a quick comparison:

I don't know if this is through the theme or I am not setting something properly, but when I insert a new parenthesis (have smartparens mode), and start inserting characters, the blue highlight stays put making text hard to read:

• It is fine if I move my cursor and then edit, the highlight disappears.
• Another theme that I use does not have this problem so I am not sure what emacs settings I need to change.

Thanks!

I use doom-molokai and it works for most buffers, but when I open multiterm, doom-one is used instead.

Henrik,

Definitely the best theme I've ever used. I've seen in your screenshots, that your .emacs contains indentation highlighting: https://github.com/hlissner/.emacs.d/blob/master/core/core-ui.el#L126-L174. It's most beautiful.

At first I wanted to extract it and inject it into my own emacs config, but I think it should be a feature that comes together with doom-one.

Also, not sure about the def-package! and add-hook! stuff, should be your own emacs lisp aliases, I have to read more.

This is caused when installing doom-themes from Melpa with all-the-icons.

I had to set it manually

(use-package doom-themes
  :config
  (load-theme 'doom-one t)
  (require 'doom-neotree)
  (setq  doom-neotree-folder-size 120))

Thanks for the great theme, I'm using it daily and never looked back.

The minor inconvenience is I have my own style for modeline\spaceline and every time I update doom theme it gets overridden.
Please add a configuration option to exclude modeline styling.

Hey,

some colours, .e.g the link, breakpoint (bright green line) seem off in jdee-mode; see below.

hello i have this:

(use-package doom-themes
    :ensure t
    :init
    (load-theme 'doom-molokai t)
    :config
    (add-hook 'find-file-hook 'doom-buffer-mode)
    (add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)
    (validate-setq org-fontify-whole-heading-line t
                   org-fontify-done-headline t
                   org-fontify-quote-and-verse-blocks t)
    (when (display-graphic-p)
      (require 'doom-neotree)
      (validate-setq doom-neotree-file-icons nil)))

when launch emacs, work fine, but in emacsclient -c dont work,

i eval this expression (display-graphic-p) and return t

Thanks

As of the refactor changes, I'm now seeing Multi-Term instances register the following message:

"error in process filter: Invalid face: unspecified"

Added a PR #36 for including Jabber.el support into your great doom theme for emacs

Hi there, I was enjoying the screenshots from your configuration and I'd like to try the theme out, but it's not available on MELPA, is there any chance you'd be interested in pushing it there?

Currently colors (esp. the blue) for RPM spec files look off and are hard to read (see below). I guess this mode is not use that much, maybe when I have some free time I could look into fixing this myself.

Hi,

I got this in m .emacs.d
setq org-hide-leading-stars t

With version 20170316.1237 from melpa it works fine after the last update it look like this

Do you have an idea?

Thorsten

Hi,

I'm using spacemacs. When I try to load doom-one in the 'dotspacemacs-themes variable, there's no problem. But when I do the same with doom-vibrant, it is treated as an unrecognized package and goes to install (which of course doesn't work). Do you have any advice about how to fix this? Thanks.

Wondering if there's a way to get rid of this. Here's a question I opened on StackExchange.

Hello,

__________________
|        |        |
|________|        |
|        |        |
|        |        |

When having multiple buffers open in horizontal split, the modeline for the top buffer isn't very
differentiable from the bottom buffer. Which is supposed to be the case given that the modeline should be the part which tells the top from the bottom buffer. However, the colors used for modeline when it's inactive makes it blend in the two open buffers making it a little hard to tell what you have in terms of layout.
So the question is:
Is it possible to add a visible border around inactive modeline for split buffers?

Would love to see the theme extended into Org-mode's agenda view.

The current color used in font-lock-comment-face is so dim
that one can barelly read any comment in a source file, please
consider improving this.

I have two bugs or I use something wrong.

First with this part: when I move between my frames, "doom-buffer-mode" is not change.

  ;; brighter source buffers
  (add-hook 'find-file-hook 'doom-buffer-mode)
  ;; brighter minibuffer when active
  (add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)
  ;; The temporary buffers ediff spins up aren't dimmed. You can fix this with:
  (add-hook 'ediff-prepare-buffer-hook 'doom-buffer-mode)

Second with neotree: something's wrong with the icons:

First of all let me thank you for this awesome theme!

It looks like the two faces colliding here are swiper-line-face which inherits from highlight and swiper-match-face-2 inheriting from isearch. Personally I think it makes more sense to change swiper-line-face to something darker but I don’t have any strong opinion here or a good suggestion on which face would make sense.

1cfecf5 enabled a blue cursor by default. Unfortunately this makes the cursor invisible if it is on the left parantheses and show-paren-mode is enabled. See the attached image where the cursor is on the left parenthesis.

It looks like the face responsible is show-paren-match. I don’t have any clever suggestions on how to fix this apart from either changing the cursor back to white or finding a pretty color for show-paren-match that doesn’t collide.

show-smartparens-mode suffers from the same problem but its faces inherit from show-paren-match so this should fix both.

To make org-mode support better.
Hope to support face org-indent:

(set-face-attribute 'org-indent nil
                    :inherit 'org-hide
                    :background (face-background 'doom-default)
                    :foreground (face-background 'doom-default)
                    )

@hlissner,

After one day of work, I will definitely keep this theme, and hopefully, contribute a bit.

I have a question though:

With:

(require 'doom-neotree)  

The neotree is most beautiful: no fringe or fringe coloured as expected, however, major-modes for files are not showing as opposed to:

;; (require 'doom-neotree)  

Where major-mode icons are rendered as expected, but the fringe (or whatever margin) is messed up.

Is there any way to combine these two excellent features ?

Many thanks !

• ju

Someone may install another plugin named doom, which provides a conflicted package named doom.el. In case of an unexpected loading order, e.g., the later is loaded first, the doom themes are not loaded
at all.

Attached please find my patch to fix this issue.

0001-rename-doom-base.patch.txt