Giter VIP home page Giter VIP logo

adblock's People

Contributors

dependabot[bot] avatar dothq-robot avatar ejaz4 avatar enderdev avatar todo-actions[bot] avatar trickypr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

adblock's Issues

Settings do not apply

Describe the bug
Saving settings doesn't apply settings changes until you restart the extension or browser.

To Reproduce
Steps to reproduce the behavior:

  1. Go to twitter.com
  2. Observe that it is broken by the social media blocker
  3. Go to the settings, disable social media list and save the settings
  4. Go to twitter and observe that it is still broken
  5. Disable then re-enable the extension
  6. Observe that twitter works

Expected behavior
Settings should reapply when the save button is clicked.

Desktop (please complete the following information):

  • OS: MacOS, Windows
  • Browser: Firefox
  • Addon Version: 0.1.0pre4

" />

<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Dot Shield</title>
</head>
<body>
<!--


This issue was generated by todo based on a `` comment in c4a083a. It's been assigned to @trickypr because they committed the code.

}}

TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
SHA: ${{ github.sha }}
REF: ${{ github.ref }}
prettier:


This issue was generated by todo based on a `` comment in c4a083a. It's been assigned to @trickypr because they committed the code.

>

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Dot Shield</title>
</head>
<body>


This issue was generated by todo based on a `` comment in c4a083a. It's been assigned to @trickypr because they committed the code.

Dot Shield blank on Dot Browser New Tab Page

Describe the bug
Dot Shield UI is mostly blank on the Dot Browser NTP (aka Firefox NTP).

To Reproduce
Steps to reproduce the behavior:

  1. Launch Dot Browser
  2. Go to about:newtab or open a new tab.
  3. Click on Dot Shield

Expected behavior
Dot Shield UI would be visible.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Desktop (please complete the following information):

  • OS: Windows NT 10.0
  • Browser: Dot Browser 87.0
  • Version: 0.1.0pre6

Additional context
I have only tested this with the version of Dot Shield bundled with Dot Browser.

.",

adblock/package.json

Lines 8 to 11 in c4a083a

"prettier": "prettier --write .",
"dev": "env webpack --config webpack/webpack.dev.js --watch",
"build": "rimraf dist && env webpack --config webpack/webpack.prod.js && env webpack --config webpack/webpack.prod.js",
"generate": "node scripts/generate"


This issue was generated by todo based on a `` comment in c4a083a. It's been assigned to @trickypr because they committed the code.

Check the whitelist to see if youtube has been whitelisted

Note that google really doesn't want ads blocked on youtube, hence why
the default adblock behavior doesn't work properly. Instead we need to create
a custom blocker that stops ads from being displayed. A really simple bodge
is to just click the skip button instantly and seem like we have properly skipped
the ad. The skip button ad is currently .ytp-ad-text.ytp-ad-skip-button-text


This issue has been automatically created by todo-actions based on a TODO comment found in src/backend/sites/youtube.ts:1. It will automatically be closed when the TODO comment is removed from the default branch (main).

')

const { merge } = require('webpack-merge')
const TerserPlugin = require('terser-webpack-plugin')
const common = require('./webpack.common.js')
module.exports = merge(common, {
mode: 'production',


This issue was generated by todo based on a `` comment in c4a083a. It's been assigned to @trickypr because they committed the code.

Make it clear when a site is being blocked

Is your feature request related to a problem? Please describe.
When a website like twitter is broken (intentionally) due to a list, but I am not told.

Describe the solution you'd like
Display a screen on broken sites telling you:

  • That it has been blocked
  • What filter list has been blocked
  • An option to disable that filter list
  • An option to whitelist it temporarily

Cosmetic filters are substandard

Describe the bug
Whilst cosmetics work, they do not compare to that seen in ublock origin.

To Reproduce
Steps to reproduce the behavior:

  1. Install ublock origin
  2. Visit https://www.cnet.com/ with ublock origin enabled
  3. Disable ublock origin and reload
  4. See the increased amount of blank space

Expected behavior
A similar output to ublock origin.

Screenshots
Dot shield
Dot shield output

uBlock origin
uBlock origin output

Desktop (please complete the following information):

  • OS: Manjaro
  • Browser: Dot
  • Version: nightly

Additional context
This may have something to do with our filter lists

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.