Actual:
public TestDBContext()
{
}
Expected:
public TestDBContext()
{
if (!created)
{
Database.EnsureCreated();
created = true;
}
}

Currently when I scaffold on an empty project, I receive the following read me text...

Couple of things:

• I think this should reflect the new Startup class setup of Configure, ConfigureServices to make it more clear...
• Also should StaticFiles middleware be registered before MVC?

Scaffolding has generated all the files and added the required dependencies.

However the Application's Startup code may required additional changes for things to work end to end.

Add the following namespace usings if not already added:

using Microsoft.AspNet.Routing;
using Microsoft.Framework.DependencyInjection;

Add the following code to the end of Configure method in your Application's Startup class if not already done:

            // Set up application services
            app.UseServices(services =>
            {
                // Add MVC services to the services container
                services.AddMvc();

            });

            // Add MVC to the request pipeline
            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller}/{action}/{id?}",
                    defaults: new { controller = "Home", action = "Index" });

                routes.MapRoute(
                    name: "api",
                    template: "{controller}/{id?}");
            });

            // Add static files to the request pipeline
            app.UseStaticFiles();

One catch is in the new DbContext scenario, we should either modify the startup code (ideal but hard) or at least show a readme that the newly created context should be registered in the startup. Is this a must fix for CTP3?

K gen controller -name Person1Controller -m Person -dc PersonContext -f

ACTUAL: Views are generated in Views/Person folder.
EXPECTED: All view to be generated under : Views/Person1 folder.

K gen Views -m Person -dc PersonContext

Views should generate all the Views (Create, delete, details, edit, Index) etc

Execute command >>K gen controller -m Person -dc TestDBContext -views.

F5 and try clicking on delete

k gen view MyView -m Person -dc PersonContext

Expected error message: something like, TemplateName is missing.

Actual: A file matching the name .cshtml not found within any folder withing any of the folders:
c:..\Scaffolding|...\MS.Framework.CodeGenerators.MVC\Templates

After running K gen command..

We should get some logging like:

K gen controller -m Person -dc PersnContext
Added controller 'Conroller\PersonController.cs'
Added database context file 'Model\PersonCOntext'
Added View \Views\Person\Create.cshtml
.
.
.

https://github.com/aspnet/Scaffolding/blob/dev/src/Microsoft.Framework.CodeGeneration.Core/IModelTypesLocator.cs#L9

This code needs to be more generic not assuming roslyn anywhere. There should be a POCO type that is used in the interface and a roslyn implementation that can turn ITypeSymbol into the POCO type.

Hi,
I just updated the repository clone, added to a custom scaffolders solution and tried recompiled, but I receive several errors

3>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AspNet\Microsoft.Web.AspNet.targets(143,5): error : Initiate build in the design time host failed with the following error: Could not load file or assembly 'a1bdf404-2a84-4219-84c6-6f06386d4d7a$Microsoft.Framework.Runtime.Roslyn' or one of its dependencies. Invalid pointer (Exception from HRESULT: 0x80004003 (E_POINTER))
6>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AspNet\Microsoft.Web.AspNet.targets(143,5): error : Initiate build in the design time host failed with the following error: Could not load file or assembly '8147ab57-b6e5-4219-9b53-c2a54be0e337$Microsoft.Framework.Runtime.Roslyn' or one of its dependencies. Invalid pointer (Exception from HRESULT: 0x80004003 (E_POINTER))

5>D:\Sorgenti\VNext\Scaffolders\ScaffoldingSourceRoot\Microsoft.Framework.CodeGeneration.Common\CommonUtilities.cs(36,52): ASP.NET 5.0 error CS0012: The type 'ImmutableArray<>' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Collections.Immutable, Version=1.1.33.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
5>D:\Sorgenti\VNext\Scaffolders\ScaffoldingSourceRoot\Microsoft.Framework.CodeGeneration.Common\CommonUtilities.cs(36,52): ASP.NET Core 5.0 error CS0012: The type 'ImmutableArray<>' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Collections.Immutable, Version=1.1.33.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

and so on

The views contains @Url.Content while is no longer required. should this be removed to use simple ~/address ?

2 things need to happen for this:

• We need changes to make the scaffolding packages to package content (templates)
• Code changes necessary to get the template folder locations from nuget package location

We should add support similar to:
http://blog.stevensanderson.com/2011/03/28/scaffolding-actions-and-unit-tests-with-mvcscaffolding/

EXPECTED the generated file nameto be Person1Controller.cs. It is Currently Person1.cs
[Note that this happens only when you pass a model parameter as well]

K Gen >> This should list all the Scaffolders that are available.
Something like:
/* Here is the list of scaffolders that you have. Try K gen --help for more options */
Bug

K gen- help/ k gen --help /K gen -? should provide some generic help on KGen.

Example: try Kgen View -? or K gen controller -? for more specific help.

Command:
D:\school\MVC6\MVC6>k gen view create create1.cshtml.cshtml -m Person -dc Person
ContextTest

ACTUAL:
System.InvalidOperationException: There was an error running the GenerateCode me
thod: View file D:\school\MVC6\MVC6\Views\Person\create.cshtml exists, use -f op
tion to overwrite
at Microsoft.Framework.CodeGeneration.ActionInvoker.b__1()
at Microsoft.Framework.Runtime.Common.CommandLine.CommandLineApplication.Exec
ute(String[] args)
at Microsoft.Framework.CodeGeneration.ActionInvoker.Execute(String[] args)
at Microsoft.Framework.CodeGeneration.Program.Main(String[] args)

EXPECTED: The message to be like:
There was an error running the GenerateCode method: View file D:\school\MVC6\MVC6\Views\Person\create.cshtml exists, use -f option to overwrite

K gen view Test1.cshtnl create -m Person

ACTUAL:
This generates file named Test1.cshtml.cshtml file.

EXPECTED:
This command to generate Test1.cshtml file.

Currently when I scaffold a controller, I see the following...we can change all the references to new HttpStatusCodeResult(404); byreturn HttpNotFound(); instead...

// GET: Person/Details/5
public IActionResult Details(System.Int32? id)
{
    if (id == null)
    {
        return new HttpStatusCodeResult(404);
    }

    Person person = _db.Person.Single(m => m.Id == id);
    if (person == null)
    {
        return new HttpStatusCodeResult(404);
    }

    return View(person);
}

Currently when I scaffold a controller, the generated views have the Layout explicitly set to null like below...

@model IEnumerable<WebApplication7.Models.Person>

@{
    Layout = null;
}

Since the layout could possibly be set by _ViewStart.cshtml, we could just avoid this explicit setting enabling the views to take the styling etc. provided by the layout that the viewstart provides...

In the generated controller, we need to use short type names like int? for method parameters.

ACTUAL: C:\school\EmptyTest2\Src\EmptyTest2>k gen controller -m Student -dc StudentConte
xt
There was an error running the GenerateCode method: There was an error creating
a DbContext :(3,7): error CS1001: Identifier expected
(3,7): error CS1002: ; expected
(3,7): error CS1022: Type or namespace definition, or end-of-file expected
(3,8): error CS0116: A namespace cannot directly contain members such as fields
or methods
(3,24): error CS1001: Identifier expected
(3,24): error CS1514: { expected
(3,25): error CS1022: Type or namespace definition, or end-of-file expected
(28,6): error CS1513: } expected

EXPECTED: It to work w/o the namespace name.

EXPECTED: Contents to be arranged in this fashion:

@HTML.ValidationSummary()
@HTML.HiddenFor()

The datacontext does not exists in this case.
The above command complains that A type with name "TestViewDbContext" does not exist. Should it generate one?

https://github.com/aspnet/Scaffolding/blob/dev/src/Microsoft.Framework.CodeGenerators.Mvc/Templates/ViewGenerator/Create.cshtml#L66

Having a int based key is pretty common. Is there a reason why this is restricted to guids?

K gen controller -m Person -dc new Context

ACTUAL:

Specify --help for a list of available options and commands.
TODO: Error: Unexpected argument 'Context'

EXPECTED: Error message to be like:

Error: Unexpected argument 'context. Try K gen controller --help command,

I tried scaffolding on an Empty project and following is the read-me that gets generated

Remove the following REST style route as currently we do not support REST style from conventional routing and expect users to use attribute routing instead..

routes.MapRoute(
name: "api",
template: "{controller}/{id?}");

SaccfoldingReadMe.txt

Scaffolding has generated all the files and added the required dependencies.

However the Application's Startup code may required additional changes for things to work end to end.

Add the following namespace usings if not already added:

using Microsoft.AspNet.Routing;
using Microsoft.Framework.DependencyInjection;

Add the following code to the end of Configure method in your Application's Startup class if not already done:

            // Set up application services
            app.UseServices(services =>
            {
                // Add MVC services to the services container
                services.AddMvc();

            });

            // Add MVC to the request pipeline
            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller}/{action}/{id?}",
                    defaults: new { controller = "Home", action = "Index" });

                routes.MapRoute(
                    name: "api",
                    template: "{controller}/{id?}");
            });

            // Add static files to the request pipeline
            app.UseStaticFiles();

If the templates are copied into user's project directory and modified there, scaffolding should pick up the templates from that location.

Hi all,
Has been planned support to integrated download source from github repositories and add packages to npm, bower and grunt config files when writing scaffolders? I seen several yeoman generators (mean.io) that start downloading files grom github: the main advantage in hosting sources in github is that I can see changes when a new version is uploaded.

When user provides a non-existing DbContext, we should bail out with a better error message when app does not reference EF package.

1. K gen controller -m Person -dc PersonContext -L layoutPage.cshtml
   -L, should imply use layout(-ul)
2. K gen controller -m Person -dc PersonContext

When there is NO UL or L falg psassed. Then e should set layout to Null.

1. K gen controller -m Person -dc PersonContext - ul

Set the layout page to empty in this case.

K gen action -n NewAction -c HomeController

1. This should generate NewCtion in HomeController.
2. This should add a View in Views/Home/NewAction.cshtml

Contents generate din MVC5 and MVC6 are different for Person Model.

public class Person
{
    public int PersonId { get; set; }

    public string Name { get; set; }

    public bool BoolProperty { get; set; }
}

Scenario description:

1. I create a Controller by name Person1 based off a model Person w/o Views. This will Create Person1Controller.
2. Now, I want to generate Views. These have to go to a specific folder Vises\Person1.
3. The only Option I have now is to go to Views\Person1 and then do K gen. But K gen is NOT supported here :-).

OR

We can give
K gen View create -m Person -dc PersonContext -outputFolder "View\Person1"

Hi,
I would like to debug to understand better how it works, but I don't userstand very well how can I start it so I can debug with vs.
Selection the .CodeGeneration project and debug tells me that there are not generators installed.
I created a webapp application, I added the reference in the project.json using
"Microsoft.Framework.CodeGenerators.Mvc": ""
so I suppose is trying to use the local package in the solution.
If I try to run K gen .... I'm not able to debug it.
Am I missing something?

Luca

K gen view -? should provide Template Name options that can be used
Example:
Arguments:
ViewName
TemplateName [list/create/delete/edit/details]

Pranav tried this on his machine and it's throwing a weird error that 'object' does not have a property 'NamespaceName' - need to see if it repros consistently.

Actual: There was an error running the GeneratedCode: Scaffolding will not be able to add a new DBContext if the application does not refrence ENtityFramework.SqlServer pachage, add a dependency to that package and try scaffolding again.

Expected: This dependency to be added automatically as the command is run.

Right after scaffolding a model or vm, when the create or edit forms are submitted successfully and request is redirected to the Index view, there is no success message displayed.

In Ruby (sometimes) on Rails, there is a div id='notice' in the default layout which displays the status of the previous transaction and scaffold complements its existence by saying flash[:notice] = "#{model_name} successfully created", where flash[:notice] is roughly equals to ViewBag["notice"].

Please consider introducing similar pattern to vNext.

Thanks!

When scaffolding creates partial views, the generated content is not properly indented. This is because there is no equivalent of T4's PushIndent (http://msdn.microsoft.com/en-us/library/microsoft.visualstudio.texttemplating.texttransformation.pushindent.aspx) for our custom razor host, we will need to implement it to correct the formatting of the generated templates.

1. Add a model Person to default starter web.

   public class Person
   {
   public int Id { get; set; }
   public string lastname { get; set; }
   }

2. Do K gen controller -m Person -dc Personctxt.

3. This generated controller and Views

4. Verify the contents in Views\Create.cshtml file
   ACTUAL: Look at the contents in view\create.cshtml file. This has an ID label added. We did not generate this in Dev12.

EXECTED: The Id to be not there:

@

Current implementation for controller uses the app name of model type as the assembly name (This is not right in the scenario where you are running k gen on a TestWebApp but the model type is in different assembly). Should fix this.

Run command: k gen view create1.cshtml.cshtml create -m Person -dc Perso
nContextTest
ACTUAL: Added View : \Views\Person\create1.cshtml.cshtml
EXPECTED: The file name to be create1.cshtml, in "Added View: \Views\Person\create1.cshtml" message.