doubi88 / slideshowwallpaper Goto Github PK

Currently, the same image can be selected multiple times, which leads to errors. Either every image should be selectable only once, or all code should consider the possibility of the same image being present twice (Especially removing an image from the list)

Hi @Doubi88,
Thanks for your work and your free app. I'm happy to see a game changer on the playstore instead of the full ad apps.

If you agree, I would like to suggest a redesign of the image_list and image_list_entry. I can start by creating a mockup of this new interface and, after your validation, developing it.

Julien

Great app first and foremost. Much appreciated👍🏽.

Would love to see dimming wallpapers option and a fade and or otherwise transitions for the app.
Good day 😌

Let the user move the images in the selection, so the selection order can be changed.

I tried your app today, and it's really nice. There's only one quite big issue. The background service takes too much RAM. On my device it takes more than 140MB, with 30 images selected. Would it be possible to make it work without a background service? At least, make it use less. It's too much for such a simple live wallpaper.
I use a Nokia 6.2, with stock Android 11.

Android has a built in limit of 512 grants to Uris an app can have. If someone wants to select more images, it should ask, if they want the app to copy the images to its app folder, so it has access to more. The images should be shrinked to a resolution fitting for the screen size, so it doesn't bloat the memory up.

Anti aliasing has an impact on performance of wallpaper scrolling.

The method StartActivityForResult is deprecated. The new API should be used for that.

I get an error after adding 2748 images, exit the images menu, then re-enter and the images only show "error reading file".
I get just a plain black background in preview and when used as the wallpaper.

I just started using the app and already love it! Great job on creating such a useful tool <3

There is an issue I ran into though. The "scaling up to fit" option is creating some stepping/pixelation artifacts. I'm suspecting it has to do with a lack of anti-aliasing but I'm not sure.

Running on a Google Pixel 6 on GrapheneOS, android 13. It has a display resolution of 1080 x 2400 which is smaller than all the examples.
I'll attach some screenshots that might show the effect, especially in the circular shapes:

Original resolution 1536 x 3072:

Original resolution 6252 x 3517:

Until #19 is implemented, the limit of grants the app has should be displayed and it should prevent adding new images, if the limit is reached.

First of all, thanks for the amazing application! It works perfectly except the issue I'm writing about below.

When I go into the preview and try to set-up the wallpaper, Android gives me 2 choices, either set Slideshow Wallpaper as a "Home screen" background, or as a "Home screen and lock screen" background, and when I choose the latter, the changes only apply to my Home screen.

There may be no corellation, but built in miui applications show a third "Set as Lock screen" option too. That might worth chenking out.

Device details:
Xiaomi Pad 5 Pro MIUI V14.0.4.0.TKYCNXM CHINA Stable
MIUI Optimization ON

Add an information screen as last entry in the settings screen, that displays the license information and a link to this GitHub page.

Add the ability to create multiple slideshows to select from. To select the slideshow to use, the following items should be available:

• Select one slideshow directly
• Randomly select one of multiple (Is related to the next point)
• Switch the slideshow at specific intervals or times of day

Further research: How can we add the ability to select different slideshows for home screen and lock screen? Ideas:

• Provide two Live Wallpaper definitions in the manifest (Might be confusing)
• Dynamically create a live wallpaper for each slideshow (Is that possible?)
• Select which slideshow to use on home screen and lock screen separately inside the app (Requires set wallpaper permission)

Just a feature suggestion, or maybe my launcher doesn't work well with the app?

I can't seem to apply the slideshow wallpaper in the lock screen, it always seem to apply to only allow for applying to the launcher or setting it for both. I just don't want a slideshow wallpaper in my home screen.

I think the selectable time intervals are too many, and some of them don't make sense. This is not a photo slideshow app, but a live wallpaper. Intervals of seconds don't make sense when using the phone, unless someone has the screen activated just to watch the wallpapers changing, which is not the case under normal everyday use a the phone. On the contrary, some esential longer intervals, like hours and a day, are missing. So, I'd suggest the following ones:

1. 10 secs
2. 30 secs
3. 1 min
4. 5 mins
5. 15 mins
6. 30 mins
7. 1 hour
8. 6 hours
9. 12 hours
10. 24 hours (1 day)

While using white color background images, the text such as time or battery life at the top cannot be seen, as it hadn't adapted to a darker font color, such as grey or black for better visibility.

The time between images should be more flexible. One Idea is a time selection dialog like https://developer.android.com/develop/ui/views/components/pickers.

Currently, the options are:

1. Home screen
2. Home screen and lock screen

But the one I need is missing:

3. Lock screen only

Add selectable transitions. When the displayed image changes, this should happen with the user selected transition.

There is no bug. I just want to express my gratitude.

It should be possible to open the image, that is currently displayed, in the gallery. This could happen with the following actions (Still to be determined):

• Some kind of tap on the background, but not only one tap or a long press, because these are used for interacting with the home screen itself. Maybe a double tap?
• A widget that opens the image (Perhaps also displaying some info about the current image)

It should be possible to add the images of a complete folder, instead of having to select every image inside that folder individually.

On some devices, the app crashes, when an image is selected. Stack trace from Google Play report:

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5068)
  at android.app.ActivityThread.handleSendResult (ActivityThread.java:5109)
  at android.app.servertransaction.ActivityResultItem.execute (ActivityResultItem.java:51)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:140)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:96)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2096)
  at android.os.Handler.dispatchMessage (Handler.java:107)
  at android.os.Looper.loop (Looper.java:264)
  at android.app.ActivityThread.main (ActivityThread.java:7605)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:492)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:980)
Caused by java.lang.SecurityException:
  at android.os.Parcel.createException (Parcel.java:2071)
  at android.os.Parcel.readException (Parcel.java:2039)
  at android.os.Parcel.readException (Parcel.java:1987)
  at android.app.IUriGrantsManager$Stub$Proxy.takePersistableUriPermission (IUriGrantsManager.java:280)
  at android.content.ContentResolver.takePersistableUriPermission (ContentResolver.java:2428)
  at io.github.doubi88.slideshowwallpaper.preferences.imageList.ImageListActivity$$ExternalSyntheticApiModelOutline0.m$1
  at io.github.doubi88.slideshowwallpaper.preferences.imageList.ImageListActivity.takePermission (ImageListActivity.java:157)
  at io.github.doubi88.slideshowwallpaper.preferences.imageList.ImageListActivity.imagePickerCallback (ImageListActivity.java:113)
  at io.github.doubi88.slideshowwallpaper.preferences.imageList.ImageListActivity.$r8$lambda$3oK7HuwK2ks8rItJ_NMaL_ZFMTU
  at io.github.doubi88.slideshowwallpaper.preferences.imageList.ImageListActivity$$ExternalSyntheticLambda5.onActivityResult
  at androidx.activity.result.ActivityResultRegistry.doDispatch (ActivityResultRegistry.java:414)
  at androidx.activity.result.ActivityResultRegistry.dispatchResult (ActivityResultRegistry.java:371)
  at androidx.activity.ComponentActivity.onActivityResult (ComponentActivity.java:845)
  at androidx.fragment.app.FragmentActivity.onActivityResult (FragmentActivity.java:164)
  at io.github.doubi88.slideshowwallpaper.preferences.imageList.ImageListActivity.onActivityResult (ImageListActivity.java:124)
  at android.app.Activity.dispatchActivityResult (Activity.java:8113)
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5061)
Caused by android.os.RemoteException: Remote stack trace:
  at com.android.server.uri.UriGrantsManagerService.takePersistableUriPermission (UriGrantsManagerService.java:328)
  at android.app.IUriGrantsManager$Stub.onTransact (IUriGrantsManager.java:139)
  at android.os.Binder.execTransactInternal (Binder.java:1038)
  at android.os.Binder.execTransact (Binder.java:997)

On some devices, the activity to set the live wallpaper is not available. In this case, either an error Message should be shown or an alternative activity should be opened (research if there exists one)

Add a share option for images, so they can be added from outside.

On Android 14 (CalyxOS runing on Pixel 5) it doesn't prompt for files permissions and it doesn't show all folders. I can only select from Downloads, Camera or Screenshot albums.

I'd like to pick pictures from other folders.

Great idea, BTW. I've just watched it on fdroid and immediately installed it.

It would be nice. ;)

If an image from the slideshow has been deleted:

• when the slideshow tries to set that image as wallpaper, it ends up being solid black
• if I try to remove that image from the slideshow in the app, the app crashes