doubledoordevelopment / torchtools Goto Github PK

View Code? Open in Web Editor NEW

3.0 4.0 2.0 107 KB

Right click with any tool to use the "place" action with the next slot in your hotbar.

Home Page: Doubledoordev.net

License: BSD 3-Clause "New" or "Revised" License

Java 100.00%

torchtools's People

Contributors

Stargazers

Watchers

Forkers

mikelydeamore joosera

torchtools's Issues

Server Crash/Overflow loop

This just started happening recently on my server. The console gets spammed with the following and then it eventually crashes. I've provided the full crash log as well (pastebin)

 [Server] INFO at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:100) ~[ForgeEventFactory.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler_5_TorchTools_playerInteractEventHandler_PlayerInteractEvent.invoke(.dynamic) ~[?:?]
08.01 17:18:20 [Server] INFO at net.doubledoordev.torchtools.TorchTools.playerInteractEventHandler(TorchTools.java:117) ~[TorchTools.class:?]
08.01 17:18:20 [Server] INFO at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:428) ~[mx.class:?]
08.01 17:18:20 [Server] INFO at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:100) ~[ForgeEventFactory.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler_5_TorchTools_playerInteractEventHandler_PlayerInteractEvent.invoke(.dynamic) ~[?:?]
08.01 17:18:20 [Server] INFO at net.doubledoordev.torchtools.TorchTools.playerInteractEventHandler(TorchTools.java:117) ~[TorchTools.class:?]
08.01 17:18:20 [Server] INFO at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:428) ~[mx.class:?]
08.01 17:18:20 [Server] INFO at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:100) ~[ForgeEventFactory.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler_5_TorchTools_playerInteractEventHandler_PlayerInteractEvent.invoke(.dynamic) ~[?:?]
08.01 17:18:20 [Server] INFO at net.doubledoordev.torchtools.TorchTools.playerInteractEventHandler(TorchTools.java:117) ~[TorchTools.class:?]
08.01 17:18:20 [Server] INFO at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:428) ~[mx.class:?]
08.01 17:18:20 [Server] INFO at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:100) ~[ForgeEventFactory.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.ASMEventHandler_5_TorchTools_playerInteractEventHandler_PlayerInteractEvent.invoke(.dynamic) ~[?:?]
08.01 17:18:20 [Server] INFO at net.doubledoordev.torchtools.TorchTools.playerInteractEventHandler(TorchTools.java:117) ~[TorchTools.class:?]
08.01 17:18:20 [Server] INFO at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:428) ~[mx.class:?]
08.01 17:18:20 [Server] INFO at net.minecraftforge.event.ForgeEventFactory.onPlayerInteract(ForgeEventFactory.java:100) ~[ForgeEventFactory.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:146) ~[EventBus.class:1.7.10-1614.UNOFFICIAL]
08.01 17:18:20 [Server] INFO at java.lang.ClassLoader.checkPackageAccess(ClassLoader.java:500) ~[?:1.8.0_65]
08.01 17:18:20 [Server] INFO at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_65]
08.01 17:18:20 [Server] INFO java.lang.StackOverflowError
08.01 17:18:20 [Server] ERROR Exception caught during firing event net.minecraftforge.event.entity.player.PlayerInteractEvent@3765a1b:
08.01 17:18:20 [Multicraft] Skipped 10382 lines due to rate limit (30/s)

Pastebin / full crash log:
http://pastebin.com/QrbzurP3

Liquid Dupe

Right clicking a tool with a bucket in the right click slot places the liquid, but does not empty the bucket, effectively duping the liquid inside.

Doesn't update the inventory when right clicking

I just tried right clicking in mp and it showed that i still had the block there but it also placed it and then when i switched to the slot it updated

Suggestion: blacklisting tools in the config

For when you have something that the mod counts as a tool, but you don't want it to place blocks when right clicking.
A good example is the Chisel from the mod with the same name. When you right click with it, its GUI opens as usual, but it also places a block.

Bug: Bibliocraft (possibly others)

Bibliocraft has toolracks, if I rightclick tools to put them in there, it will often not work with this mod installed. I think those are tile entities? Maybe it's a good idea to only use the tool if the target is a block, not a tile entity? Or some kind of config or blacklist for TARGETTED blocks.

Config for slots

gnomeknows @ Curse:

This mod could explode with possibilities with a small config file. Just make it a simple right click action for whatever "torch" slot instead of explicitly placing a torch and allow ppl to map one slot to another, or render it nil to avoid wackiness. Like:

slot1 = slot7

slot2 = slot2

etc... So right clicking when using slot1 performs a right click action for whatever item is in slot 7 and slot2 does a normal right click and so on. Anyways, just an idea, mods great on its own as well.

Don't right click a hopper.

http://pastebin.com/wQxf6K3s

Make the default for disableTE true

TorchTools breaks literally every mod that provides some kind of "right-click block with tool" functionality. Examples are Railcraft's Crowbar, JABBA Barrels, Storage Drawers, Bibliocraft.

There is a dupe glitch related to this, as the comment on the config mentions even. I don't see how it's sensible to have the default still be 'false'.

When do you ever place torches against tile entities anyways? You usually use this mod when mining. For the rare occasions where you want to place something against a tile entity, it's not worth it having all those other things broken.

Honestly removing the option altogether and never screwing with the tile entity right click would be my step of action, but please consider at least making the default value of this option true.

Crash on right click with tool in slot 1

Repeatable crash when right click with a tool in slot 1, and the block to place is not in slot 9.
I assume it loops it backwards to find the first available block giving an out of bounds exception.

Crash log: http://pastebin.com/aXwD3nY9

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.