It seems cache is handled by a md5 of all the content.
So before checking the cache, all file are readed, parsed, concatened. And finally a md5 is done (can be long on so much long datas if many CSS are combined).
At each HTML server query the process is made again.

Do you think it could be improved ? I get two ideas for this:

1- The more easy to implement
I thing by checking modification dates and make a md5 of this (a concat of all last modification dates of the files). And after if not cached we parse the content of the file (it will make 2 access to each files, one for checking last modification date and another for content, but maybe will be faster in the end as when it will be cached just the date will be checked).

2- Maybe this one need a more complex rewriting
I guess the included cache in mrclay/minify is not used actually ? (as it seems some cache technics are implemented, see here please: https://github.com/mrclay/minify/blob/master/docs/CookBook.wiki.md). Maybe we could rely one those ? (but for this i think we should change the way it work by using the htaccess combination, see the github homepage of the projet, they talk about http://example.org/min/?f=min/quick-test.css).

If minify is used, the following code will be generated by the plugin (for example):
<script type="text/javascript" async="false" src="/website/var/tmp/minified_javascript_0ea1ea04310d23b1aec1c1b43e9dc116.js"></script>

This does cause the following error in HTML Validation (W3C):
Bad value “false” for attribute “async” on element “script”.

The HTML 5 specification does accept something like this:
<script type="text/javascript" async src="/16.js"></script>
But it does not allow the opposite.

I'm not sure how to fix that without loosing the valid async functionality.

Thanks again for this great plugin : )

Just one problem when testing it:
This line https://github.com/dpfaffenbauer/pimcore-minify/blob/master/lib/Minify/Plugin.php#L15 send an error as the file doesn't exist.

By commenting it, all seems to work (as autoload is handled by composer).
So maybe it could be removed from the code ?

Hello,
the minifying system works, thanks. But it does add a // ma to every page in my tests.

I could not find it in the code so I'm unsure what is causing this issue.
Any support would be great.

I successfully installed this plugin in Pimcore and it seems to work. I do see a lot of minified_javascript files in my /tmp directory. But the website iteself does not change, it does still have the uncompressed .JS files in the source code.

Am I missing something?

There are no minified_css files in /tmp although there are .CSS files used in the layout.