Giter VIP home page Giter VIP logo

workflowgui's Introduction

Hi ๐Ÿ‘‹

I am Dominik, founder and architect of @CoreShop and @Pimcore Most Valuable Pimconaut (MVP) 2018.

I do develop mainly for Pimcore related Open Source Projects. Mainly I develop CoreShop, the Open Source eCommerce Platform for Pimcore.

I am also CEO of @cors-gmbh where we focus on developing the most modern and advanced Pimcore Projects.

Dominik's GitHub stats

workflowgui's People

Contributors

dpfaffenbauer avatar jjonas-gcs avatar kkirsz avatar ppi-buck avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

workflowgui's Issues

Action editing broken in last plugin version.

In the last plugin version (fresh download on github):
If you create a new action "my_new_action" and directly save the workflow (without editing the action). Next you close the workflows tab and reopen it. And go in editing the action, there will be many empty transition added:

workflow1

Next, remove all those empty transition and save the workflow again. Close again the Workflows tab and reopen it. Try to edit again the action, a JS error is sent:
TypeError: events[eventKey].splice is not a function here https://github.com/dpfaffenbauer/pimcore-WorkflowGUI/blob/master/static/js/workflow/item.js#L625

workflow2

The foreach, send more eventKey than just array (with console.log i found it send all object method, like _reverse....).

I don't know if the two problem are related (multiple empty line for transition, and events parsing).

I made the test on firefox last stable version/windows 7 (but i don't think it is browser related).

If it can help, here is the wokflowmanagement.php generated:
workflowmanagement.zip
As it can be seen many object method have been added (flatten, intersect, clone...).
And i have seen that at the first save the action php config is minimal with just filled fields, but after two save those are added:

                "additionalFields" => [

                ],
                "users" => [

                ],
                "notificationUsers" => [

                ],
                "events" => [

                ]

During your test closing the general Workflows tab must be close and after reopened (it seems if not closed, action can be edited, like if it was in memory...).

Feel free to ask me any further information.
Thanks.

Display error while taking workflow action in object after update version

I updated Pimcore 5.1.3 to Pimocre5.4.2. My workflowgui and workflow module is working fine in Pimcore 5.1.3 but after update , I am taking action from one state to another state, it got this error -:

error performing action on this element
An exception occurred while executing 'SELECT id,type FROM users WHERE id in () AND id > 0 AND type IN ('role','rolefolder')': SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND id > 0 AND type IN ('role','rolefolder')' at line 1

but after refresh page , state changes

New feature: preconfigured custom report or dedicated panel

I found that using custom report we can list state/status, filter them (drilldown rocks for this!) and make workflow even more interesting as we can filter object by state/status.
It is just an idea, but maybe such custom report could be automaticaly configured by the plugin ?

Here is an example (just for objects and not totally optimized, just to get the idea)

customreportcreation

customreport

If using native Pimcore custom report is not the "good" way, maybe a dedicated panel "Workflow report" could be added to the plugin.

By the way, "state" are not displayed anywhere ? (status are on the object toolbar). Maybe I will ask or make a PR on Pimcore for this.

Transistion is broken.

In the last version of the plugin, transition is broken.
Generated workflow php config use strange name instead of status name.

        "transitionDefinitions" => [
            "globalActions" => [

            ],
            "PimcoreWorkflowTranstionDefinitionsTo-3" => [
                "validActions" => [
                    "valider_info_initiales" => NULL
                ]
            ],
            "PimcoreWorkflowTranstionDefinitionsTo-4" => [
                "validActions" => [
                    "valider_media" => NULL
                ]
            ]
        ],

PimcoreWorkflowTranstionDefinitionsTo-3 and PimcoreWorkflowTranstionDefinitionsTo-4 are not configured status. I need to replace them manually by ("initial" and "media" in my use case).

If it can help, here is the generated config php file (this is the same than the bug on action edition):
workflowmanagement.zip

Thanks.

Failed to install in PIMCORE 5

Hi @dpfaffenbauer ,

I'm trying install it using composer, and already enable it on the admin site.
But it seems the pimcore cannot detect the assets and controller from this bundle

Here i provide the screenshot :
image

image

I'm using PIMCORE 5.1.2, do i have miss something when install it ?

Thanks

Some small bugs

Another really great plugin of you! I tested it and it is really usefull to make easily workflow rules.

I just noticed some small problems. Here they are:

  • In "Actions" panel, editing an action : we can only choose one "Users" and one "Notification Users". And they cannot be blancked/erased after. I think making the two field multiselect should handle this.
    I think I will open an issue on Pimcore for a new feature: possibility of using "role" too (so creating new user will be automatically targeted to the actions possible for him).

  • In "Actions" panel, editing an action : for event, if they are empty (no method filled) they should not be injected in the PHP workflow configuration as it brings an error "Invalid callback provided" when running the action on the object panel.
    See this code generated by your plugin in the PHP workflow configuration file:

"events" => [
	"before" => [
		"before",
		""
	],
	"success" => [
		"success",
		""
	],
	"failure" => [
		"failure",
		""
	]
]

If it is manually removed in the configuration file, it work well, but at every save it come back.
Maybe it is a problem which need to be corrected on the Pimcore core too.

  • In "Actions" panel : the delete button is not visible (last stable Pimcore 4.4.2 just released today) - Just tested on Firefox last stable version on W7 desktop.

  • Transition definition panel: I think it is not "State" but "Status" the colum label (for Transition to).

As you can see they are just small problems, and everything other work really fine!
Thanks again to share this with us.

BUG: saving an action with a success event-callback doesn't correctly add the code

Hey Dominik,

just found a bug in your extension.
When you save an action that has a success-callback configured inside the GUI it produces wrong code in the corresponding file.

GUI before saving
image

Code
image

Which in the GUI results to after a reload
image

If I remove the first line in the [events][success] - Array it works just fine.

Thanks for providing this extension anyways! It makes understanding and setting up workflows much much easier!

Cheers,
Basti

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.