Giter VIP home page Giter VIP logo

Comments (5)

DragonBe avatar DragonBe commented on July 19, 2024

Thank you for reporting this failure.

Yes, there's a limit on requests you can do on the soap service but it's not documented how many request can be made in what time period.

Let me see what I can do about it.

from vies.

jonathanmaron avatar jonathanmaron commented on July 19, 2024

I was actually more concerned that an uncaught SoapFault is thrown. Surely, the SoapFault should be caught by DragonBe\Vies\Vies, and a DragonBe\Vies\ViesException should be thrown?

I would have thought it is easier for the end user to try and catch only one specific exception in his/her application logic, than for a DragonBe\Vies\ViesException and a SoapFault.

Or am I the only one who would implement it that way?

What do you think?

from vies.

DragonBe avatar DragonBe commented on July 19, 2024

@jonathanmaron You're absolutely right. Well, the issue is created and marked as bug. If I can free up some time, I will fix it in the upcoming days.

from vies.

jonathanmaron avatar jonathanmaron commented on July 19, 2024

Fixed in #18

from vies.

jonathanmaron avatar jonathanmaron commented on July 19, 2024

To differentiate between exceptions caused by local code, and those from the back-end service VIES, it make sense to have two exceptions. The new example "examples/checkVatBatch.php" shows why this is important.

from vies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.