Giter VIP home page Giter VIP logo

Comments (2)

DragonBe avatar DragonBe commented on June 16, 2024

Hi @jonathanmaron,

Caching is a good idea, but I don't think it's the goal of this package to provide integrated cache as everyone implements their own cache.

What I suggest is that you within your app implement cache for a TTL of 1 day on the validation response of this VIES service. Example below.

// We instantiate the VIES service (or use DI)
$vies = new DragonBe\Vies\Vies();

// We create a unique cache key based on the country code and VAT number
$cacheKey = $countryCode . $vatNumber;

// Cached data is an array formed by $cacheKey and the VAT validation result
$cacheHit = [$cacheKey => false];

// Our cache routine
if (false === ($cacheHit = $this->getCache()->load($cacheKey))) {
    try {
        $validationResult = $vies->validateVat($countryCode, $vatNumber);

        // Since the cache also returns false on a cache miss, we need to be creative
        // storing the result.
        $this->getCache()->save($cacheKey, [$cacheKey => $validationResult]);
    } catch (SoapException $soapException) {
        $this->getLogger()->crit($soapException->getMessage());
    }
}

return $cacheHit[$cacheKey]; // returns true or false

I hope this makes sense for you. Let me know if it doesn't.

from vies.

jonathanmaron avatar jonathanmaron commented on June 16, 2024

Thanks for the update. I think that a cache is very important, but you are right, it can be implemented one level higher in the application logic. Thanks for the sample code. :-) Jonathan

from vies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.