Comments (11)
krzaczek
commented on July 19, 2024
1
At this moment the library only supports 8 digit numbers (https://github.com/DragonBe/vies/blob/master/src/Vies/Validator/ValidatorCZ.php#L44)
I will implement 9 and 10 digit numbers .. maybe tomorrow or next week.
from vies.
DragonBe
commented on July 19, 2024
1
Ok, tagged 1.0.7 and 2.0.1 with updated CZ validation rules. Thank you @jakejanson for reporting the issue and @krzaczek to come up quickly with an update. You both are heroes in my book, thanks a bunch! 🙇
from vies.
jaburjak
commented on July 19, 2024
1
@krzaczek wow, that was fast. Thank you!
@DragonBe this was my first OSS bug report, I hope I did well 😅 Anyway, thanks for this amazing library!
from vies.
krzaczek
commented on July 19, 2024
Hi,
That is true:
'CZ'+8-10 digits
Source: https://en.m.wikipedia.org/wiki/VAT_identification_number
I need to find a checksum algo for 9 and 10 digits to be able to implement it.
pawel (at) mobile
… On 17 Aug 2017, at 17:51, Jake Janson ***@***.***> wrote:
Hello. According to the source code of the class DragonBe\Vies\Validator\ValidatorCZ, a Czech VAT ID must be 8 digits long, but thatʼs wrong. Our law states that a VAT ID consists of the prefix “CZ” and one of the following:
for individiuals: their personal identification number, or other general identificator if specified by a special law
for companies and other legal entities: their taxpayer identification number
in case the entity doesnʼt have a general identificator assigned, the tax administrator can assign a custom identificator
Example: CZ699004237 is a valid VAT ID, but this library marks it as invalid.
Iʼm afraid that there is no way of strictly checking the formal validity of the VAT ID before submitting it to VIES. I personally have seen only VAT IDs that are (excluding the “CZ“ prefix) 8, 9 or 10 digits long, but I could not find any legal evidence that indicate these are the only valid formats.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from vies.
krzaczek
commented on July 19, 2024
Found it: http://85.81.229.78/systems/DKVIES/-%20Arkiv/Algoritme%E6ndringer/VIES-VAT%20Validation%20Routines-v15.0.doc
pawel (at) mobile
… On 17 Aug 2017, at 17:51, Jake Janson ***@***.***> wrote:
Hello. According to the source code of the class DragonBe\Vies\Validator\ValidatorCZ, a Czech VAT ID must be 8 digits long, but thatʼs wrong. Our law states that a VAT ID consists of the prefix “CZ” and one of the following:
for individiuals: their personal identification number, or other general identificator if specified by a special law
for companies and other legal entities: their taxpayer identification number
in case the entity doesnʼt have a general identificator assigned, the tax administrator can assign a custom identificator
Example: CZ699004237 is a valid VAT ID, but this library marks it as invalid.
Iʼm afraid that there is no way of strictly checking the formal validity of the VAT ID before submitting it to VIES. I personally have seen only VAT IDs that are (excluding the “CZ“ prefix) 8, 9 or 10 digits long, but I could not find any legal evidence that indicate these are the only valid formats.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from vies.
DragonBe
commented on July 19, 2024
On the EU VIES FAQ pages I found a link to more information, unfortunately Google makes a bit of a mess out of it. But maybe it will make more sense to all of you.
The document you provided offers the same as what's being implemented: 8-10 numeric values. Can you offer me a unit test (or other form of test) to see where it fails? I can't seem to reproduce it.
from vies.
krzaczek
commented on July 19, 2024
For example CZ7103192745 - this is a valid VAT number and it's successfully validated by VIES - but the library will return false since it's longer than 8 digits
from vies.
krzaczek
commented on July 19, 2024
@DragonBe I have created a patch for version 1.0.x. Can You create a 1.0 branch from tag 1.0.6 - I'll send a pull request.
https://github.com/krzaczek/vies/tree/1.0
from vies.
DragonBe
commented on July 19, 2024
crap, should have used the command line… merged into master 🤦♂️
Reverting changes and merging it into 1.0 branch… hang on
from vies.
DragonBe
commented on July 19, 2024
Fixed my sleepy PR acceptance, all is good to go.
Will tag it as 1.0.7 and forward your changes on 2.0 branch
from vies.
DragonBe
commented on July 19, 2024
@jakejanson you're welcome, glad you like this library.
from vies.
Related Issues (20)
- Validation of Irish VAT ID failed for valid VAT ID HOT 7
- Making VIES package more inclusive
- Missing BG checksum validation for foreign natual persons
- VIES_EU_COUNTRY_LIST Visibility HOT 1
- Package upgrade to composer 2.0
- Ensure this package can be installed with Composer 2.0
- Implementing a Symfony constraint based on this library HOT 2
- Remove support for the United Kingdom ("GB") HOT 16
- Add support for United Kingdom (Northern Ireland) ("GB-NIR") HOT 7
- Support php8
- Validation failed for valid VAT numbers HOT 8
- 32 Bit Support HOT 1
- The service moved to SSL endpoint. HOT 1
- use of ::VIES_EXCLUDED_COUNTRY_CODES
- ValidatorLV results inconsistent with official EU validation
- heartbeat is not working anymore HOT 12
- Cannot populate CheckVatResponse after using `toArray`
- Optional Argument Validation Fails for ® HOT 2
- Heathbeat check always false HOT 1
- GetAddress non getting separated city, zip
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vies.