Comments (6)
@mato61 I looked at it and the solution seemed simple enough to fix quickly so I did. I'll be releasing 2.1.6 now.
from vies.
Hey @maffpool, thanks for reporting this issue. I'm currently busy, but let me see if I can find some time this week to look into what caused the failure to validate and fix the issue.
I see it got validated through the original VIES service, so I assume there's a validation rule that's not working correctly. Should be easy to fix.
from vies.
Thanks @DragonBe for answering so quickly !
If you tell me where you find official information about checksums, maybe I could dig into this issue and submit a PR !?
from vies.
Hey @maffpool,
We're basing the structure of a VAT ID on the documentation provided in the FAQ of the official VIES service website, but we have seen it's not always accurate or up-to-date.
Having users across the EU using this package will expose those undocumented changes (like you have reported), so we can just add it to our testcase and update our structure mask.
You can add your example VAT ID to the provider in tests/Vies/ValidatorTest.php
and make it pass by updating the code of the validator src/Vies/Validator/ValidatorBG.php
.
from vies.
Hi @DragonBe , I have problem with VAT ID BG8311046307. Result of validation is false. This VAT ID is validated by http://ec.europa.eu/taxation_customs/vies/vatRequest.html
I use version 2.1.5.
Thanks
from vies.
Hey @mato61,
Thank you for reporting this issue. I've validated the issue through our unit tests and reopened the issue to fix it.
PHPUnit 7.5.0 by Sebastian Bergmann and contributors.
..............................F
Time: 1.69 seconds, Memory: 10.00MB
There was 1 failure:
1) DragonBe\Test\Vies\Validator\ValidatorBGTest::testValidator with data set #3 ('8311046307', true)
Failed asserting that false is identical to true.
/dev/dragonbe/vies/tests/Vies/Validator/AbstractValidatorTest.php:14
/dev/dragonbe/vies/tests/Vies/Validator/ValidatorBGTest.php:15
FAILURES!
Tests: 31, Assertions: 69, Failures: 1.
I won't be able to do any work on it until the beginning of February because of a full agenda. Maybe @krzaczek can have a look at it in the mean time? If not, I will look at this in February.
from vies.
Related Issues (20)
- Validation of Irish VAT ID failed for valid VAT ID HOT 7
- Making VIES package more inclusive
- Missing BG checksum validation for foreign natual persons
- VIES_EU_COUNTRY_LIST Visibility HOT 1
- Package upgrade to composer 2.0
- Ensure this package can be installed with Composer 2.0
- Implementing a Symfony constraint based on this library HOT 2
- Remove support for the United Kingdom ("GB") HOT 16
- Add support for United Kingdom (Northern Ireland) ("GB-NIR") HOT 7
- Support php8
- Validation failed for valid VAT numbers HOT 8
- 32 Bit Support HOT 1
- The service moved to SSL endpoint. HOT 1
- use of ::VIES_EXCLUDED_COUNTRY_CODES
- ValidatorLV results inconsistent with official EU validation
- heartbeat is not working anymore HOT 12
- Cannot populate CheckVatResponse after using `toArray`
- Optional Argument Validation Fails for ® HOT 2
- Heathbeat check always false HOT 1
- GetAddress non getting separated city, zip
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vies.