Meaningful constants about vies HOT 5 CLOSED

Moreover, the listEuropeanCountries function should not return 'EU' as a european country code IMO, regardless of what the constant is called.

from vies.

@Seldaek yes the listEuropeanCountries should not return EU.

We could do this two ways

1. We could leave EU in the list of VIES_EU_COUNTRY_LIST and just update the listEuropeanCountries to not return EU as a "country" by simply filtering the return array.
   or
2. We could remove EU from VIES_EU_COUNTRY_LIST and write a new method to validate requestor prefix (that should return true for all 28 countries and EU

I think we should go with option 1) since probably (don't know why it's not working this way now) VIES will allow to validate EU MOSS VAT numbers in the near future, and we will just need to rewrite the ValidateEU class to make it work.

from vies.

@krzaczek implemented 1) in #87 - it doesn't fix the const naming issue but at least the public API is now fixed which I hope makes it ready to release.

from vies.

@Seldaek Could You fix the PHPCS errors so we could merge it and release it #87 (comment)

from vies.

Closing this issue as PR #87 is now integrated in master code and will be released soon.

from vies.