ValidatorFI::validate returns false for valid FI VAT number about vies HOT 4 CLOSED

@sophiekuehn i'll look at it in the evening

from vies.

hi @krzaczek co-worker of sophie here. I had a quick look already and stumbled across ValidatorFI rules

VAT format: [C1 C2 C3 C4 C5 C6 C7 C8]

Range:
C2 .. C8 Numeric from 0 to 9

Rules:
C8
R = 11 - (7C1 + 9C2 + 10C3 + 5C4 + 8C5 + 4C6 + 2*C7) modulo11
If R = 10 then, VAT number is invalid
If R = 11 then C8 = 0
Else C8 = R

I read it like R=11 AND C8=0 is a valid VAT for Finland, but the code does not reflect this but only the last case ELSE C8 = R
At least that's how I read
return 11 - ($checkval % 11) == (int) $vatNumber[7];
If yo agree I can prepare a PR for this.
Thanks for your efforts :)

PS: forgot to mention that the VAT in question does fulfill the If R = 11 then C8 = 0 case

from vies.

from vies.

Fixed in #96 and tagged as release 2.1.11. Closing this issue now.

from vies.