rename Tax Status about ror_ecommerce HOT 12 CLOSED

I'd ditch the start/end date for simplicity. Is active may be good so one can in fact add a new tax rate for when it changes (rather than edit the old one)

Vat rates do change btw surprisingly often here in Europe.

from ror_ecommerce.

start and finish dates are required to make returns easier. One big issue I had with Spree was it's in-ability to work with returns.

I have a method

tax.at(Order.completed_at)

Thus you can determine the tax that should have been charged at a given time.

I'll look to see the difficulty of changing the name. I will most likely change this but it's a lower priority for now.

from ror_ecommerce.

The idea of having the tax.at is good, no doubt.

For putting things on the "later" list, I made a Wiki page for that and we could close this and add the issue there

from ror_ecommerce.

What about the rename ?

from ror_ecommerce.

I've been lazy on this one. (more scared of missing something) I'll start this now... For some reason I slept 12 hours last night, WOW.

from ror_ecommerce.

This will break old migrations so I'm thinking the best option is to remove old migrations and in the new migration to check for the tax_statuses table.... If the table exists change the name, otherwise create the new table

from ror_ecommerce.

How can it break old migrations ? Don't they get applied first and then the rename should work ?
But if it works all is well.
BTW: how many active installations are there about ? and how do you view upgrades?

from ror_ecommerce.

Lets break the upgrade-ability to a google group talk...

https://groups.google.com/forum/?fromgroups#!topic/ror_ecommerce/RT_Ljc3IPpI

from ror_ecommerce.

If I rename the models the old migrations will break because they require a model named TaxStatus.

from ror_ecommerce.

That can be fixed by declaring the class that is expected inside the migration. (Not pretty but i read it works)

from ror_ecommerce.

Just verifying now...

from ror_ecommerce.

Looks GOOD! I'm out for the rest of the day. Let continue the upgrade talk... I'm hoping we can think of a better process than anything I wrote down. I personally think each has serious problems.

from ror_ecommerce.