Comments (3)
drhenner
commented on September 17, 2024
I was looking for the gem. I'll take a look at your branch. (I still like manually running the site before making changes. It should be OK to remove soon. I'll give you an OK after some manual QA work. (unless you already did the manual QA)
from ror_ecommerce.
drhenner
commented on September 17, 2024
Manually testing looked good. I should probably add better CSS with the error message but that has always looked bad.
Do you want to check in the changes or shall I?
from ror_ecommerce.
denispeplin
commented on September 17, 2024
Checked in.
from ror_ecommerce.
Related Issues (20)
- Would ror_ecommerce work fine under ruby-2.3.1 ? HOT 4
- Update Ruby/Rails requirements in README HOT 1
- Can create a submitted order with total charged not matching items associated with order. HOT 3
- How to use payment gateway in development mode? HOT 5
- Paginate Products HOT 3
- N + 1 queries Shopping::CartItemsController.index HOT 2
- Any other issues ? HOT 1
- where.first can be replaced by find_by HOT 2
- detect should be replaced by find_by HOT 6
- loop update could be update_all HOT 2
- some html label generate code could be changed in products/index.html.erb HOT 4
- count could be size , so that when it's loaded, the size will be faster than count HOT 3
- map().sum could be sum(xx) HOT 1
- Demo Environment Down HOT 2
- NoMethodError (undefined method `[]' for nil:NilClass) when trying to create new Product HOT 2
- Role.all.map could be replaced by pluck
- unused data retrieval
- unused data
- Referral email should be case_insensitive
- A deleted column is still used
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ror_ecommerce.