AMQPParser throw an error: Oversize frame 131318 about amqp-coffee HOT 7 CLOSED

Maybe the event is emitted not by the connection but by the consumer? I may be completely wrong, but you can try that.

from amqp-coffee.

The frame parser was throwing the error so you could watch connection.parser.on 'error' however that is somewhat broken, so I switched it to bubble the error up to the connection

#74

This will be fixed in 0.1.30 which will be published within the next day or two. Thanks for the report!

from amqp-coffee.

Thanks!

from amqp-coffee.

Just making sure - what will happen to the connection to rabbitmq after parser error? The connection will still alive and it's fine to keep working? Or some bad things may happen and reconnection is required?

from amqp-coffee.

This is a good question, because if we receive a oversize frame the server is violating the agreed upon connection tuning parameters. However, we could continue, if the server closes the connection then so be it. I think having a connection option here is the best because there could be a corrupted frame size, which could lead to a out of memory error.

I updated the pull request and added the connection option ignoreOversizeFrames which defaults to false.

from amqp-coffee.

@Vaidas737 I changed my thinking on this a little.

I think the connection needs to be destroyed, and ignoring a oversize frame shouldn't be an option. Here is my reasoning. A oversized from should never exist if it does then the AMQP broker has a bug, or the client has a bug and has interpreted a packet or partial packet incorrectly. To fix that the connection would need to be restarted. If we ignore a oversize frame we have no way of knowing if the data is truly that size and what to do if its not. I think throwing a error and killing the connection is the proper thing to do. So I updated the pr to reflect this, let me know if you disagree

from amqp-coffee.

Sounds good. I'll let you know if I have any issue with it. Thanks!

from amqp-coffee.