drpaulbrewer / decorated-google-drive Goto Github PK

Google Drive REST API documents:

• resumable upload
• handling Drive API Errors

The retry strategy suggested at the end of the resumable upload docs is not implemented in drive.x.upload2

Informational calls by drive.x.<someMethod> to the Drive API might also benefit from a retry strategy. First, some checking with the googleapis.drive source code might be appropriate to ensure we are not re-inventing the wheel.

Consequences: uploads or other calls might fail more often when a Drive server is busy

Fix suggestions:

• retry strategy is suggested by the Google Drive REST API Docs
• npm:promise-retry can do exponential backoff
• A retry for a write has to determine if the file is there already because Google Drive does not
  overwrite the old file with the new one. Drive is happy to have multiple files with the same name,
  but this code should be opinionated and it's a bad outcome worth avoiding.
• md5 might be required to know if the file is correct
• file size does not always match content length, especially for short files

The stream property would need to be replaced with a streamer function yielding a new readableStream

Haven't tested hard enough to hit rate limits and see errors, so other stuff has priority at the moment.

This might not get done for a while.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Google Drive tags binary files with MD5 checksums in the file metadata.

MD5 is not currently checked after file upload, but certainly could be.

trashed: false should be default unless explicitly set to trashed: true

Presently, searches trash and non-trash.

Causing issues with findPath/createPath and possibly others

searcher has been updated to support options.orderBy

Also, setting options.recent to true will override orderBy and return only the most recent file.

At the time of posting, these changes are not reflected in the README documentation.

the orderBy on file search results is hardwired.

It may make a reasonable default, but needs to be more flexible.