For example, in the buyerAgentType column of the output file "trade.csv", I expected "ZIAgent".

This appears properly on cloud simulation, but in web-based simulation the type recorded is "t".

This is also confirmed by examining memory-based logs in a fresh simulation in chrome dev tools.

Hi good day @DrPaulBrewer
I am a graphic designer and I would like to contribute with the project
I can offer a logo that represents the project.
You can receive the logo without any commitment.
I want to contribute because I like to do it.
Thanks for your time.

Cheers!

Lines 741-745 and 835-1316 of this test report

https://travis-ci.org/DrPaulBrewer/single-market-robot-simulator/builds/548964578

An example:

1. simulation with single unit trade, value [1000], costs [1]
   runSimulation with three simulations of 10 periods of single unit trade scenario, asynchronous, realtime 1.5 sec period
   when done should pass same tests as above
   the trade log should have 11 entries, the header row plus 10 trades, exactly 1 trade per period:
   AssertionError: expected 10 to be 11

   • expected - actual
     -10
     +11

   at Assertion.fail (node_modules/should/cjs/should.js:275:17)
   at Assertion.value (node_modules/should/cjs/should.js:356:19)
   at Context.equal (test/index.js:937:45)
   at processImmediate (internal/timers.js:439:21)

Known:

• Running the tests repeatedly, over and over, this will fail in approximately 5-10% of runs.
• This is not something that normally executes during a simulation.
• It is only applicable for "real-time" simulations that are run on a delay and with reference to actual time
  • example: humans could compete with robots over the web on a hypothetical system not yet built
• Currently I have never actually finished and deployed this for any kind of research data production.

To be determined:

• Could this be simply timing related?
• Delays in executing tasks pushed to the internal JavaScript event loop could be difficult to find/debug.
• Does it go away if we increase the length of periods to 30 sec or 1 minute?
• since it is not being used -- remove it?

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 5.0.2 of mocha was just published.

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

These files have caseid label in the header row but empty column in the data rows:

buyorderlog.csv
sellorderlog.csv
reject*csv

Although the agent type if set in config and these setting seem well tested, it would aid in data
analysis and future testing to have the agent type available in order log and trade log files.

A test within the single-market-robot-simulator test suite seems worthwhile.

The snipers are already tested in market-agents, but this didn't catch a mis-match in column names
that unintentionally blocked the previous period highPrice/lowPrice information from the snipers.

As a prerequisite to knowing if certain strategies are behaving correctly, we need to know
the existing market quotes the moment before the agent acts in the market.

Currently, there is no way to obtain this information other than replaying the market data.

I noticed this error on the econ1.net website after I managed to accidentally remove buyerAgentType and sellerAgentType arrays and then tried to run a study that didn't have these required settings.

Notice that this issue has to do with array-valued properties (because .length is implicated).

What I would like it to do: The console error message should explain which required variables are missing

What it did instead: Told me that it couldn't read the length of an undefined variable, without telling me which variable is undefined.

This doesn't impact normal, correct operations.

Morphing code's floating pointing interpolation does not guarantee integers: 13.9999999998

Proposed solution is to apply Math.round() in each of these statements.

The dependency simple-isomorphic-logger was updated from 2.1.0 to 2.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

simple-isomorphic-logger is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

One of the minor tests, described as

deadline: run Simulation sync:true with immediate deadline, request 10 periods of single unit trade scenario only yields one period'

fails intermittently.

The specific part of the test that fails is

it("sim.config.periods should be reduced to 1 period", function () {
S.config.periods.should.equal(1);
});

Example

     AssertionError: expected 2 to be 1
      + expected - actual

      -2
      +1
      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.equal (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/index.js:1019:31)

update esdoc. esdoc may need a plugin.

manual doc push at esdoc website is failing.

Error messages looked like this in Docker container

/work $ node ~/single-market-robot-simulator/build/index.js sim.json
internal/fs/utils.js:657
    throw new ERR_INVALID_ARG_TYPE(
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number (1)
    at Object.writeFileSync (fs.js:1380:5)
    at mainPeriod (/home/node/single-market-robot-simulator/build/index.js:763:8)
    at Simulation.run (/home/node/single-market-robot-simulator/build/index.js:720:9)
    at main (/home/node/single-market-robot-simulator/build/index.js:767:26)
    at Object.<anonymous> (/home/node/single-market-robot-simulator/build/index.js:775:43)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
  code: 'ERR_INVALID_ARG_TYPE'
}

The notes at the end only cite the paper in JEBO.

The data in brief paper is open access and also gives pointers to data and replication details.