Giter VIP home page Giter VIP logo

hotsauce's People

Contributors

pirog avatar reynoldsalec avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

hotsauce's Issues

Travis Build of Hotsauce-Drops-7 Doesn't Work

After tagging a release (7.x-1.0-beta1) on the drupalprojects/hotsauce, an updated build should have been pushed to kalacommitbot's fork of the hotsauce-drops-7 repo.

Although our Travis build came back as a-ok, something must be funky in getting this extra build (which is a handy time-saver for deployment of HotSauce! to all locals). @gremy originally built this and @labboy0276 has helped out in the past; @pirog might want to review now that he has become a Travis expert.

Limit push access to kala-travis from travis build

Right now, when a tagged commit is pushed to hotsauce, the travis script will automatically build a version of hotsauce and commit it to kala-travis's hotsauce-drops-7 account. Anyone can do this, which isn't ideal for our review process.

Our goal should be to not build/commit to kala-travis unless the commit is a pull request being merged into drupalprojects/hotsauce.

Get this updated

Get hotsauce core and residuals up to snuff

Note, I am doing this now and just creating this issue for a PR

Solid documentation

We need to write documentation both for HotSauce! but more importantly for Kalatheme 4.x. THIS IS GOING TO BE SUPER IMPORTANT.

Here are some things we will need for HotSauce!

  1. Project page for d.o
  2. Read Me
  3. How to's for installation and usage
  4. @reynoldsalec other things?

Here are some docs we will need for Kalatheme 4.x

  1. Probably something talking about all the changes
  2. An extensive how-to on how to use all the magix
  3. @bassettsj what else?

max_nesting_level reached in travis build

Error: Maximum function nesting level of '256' reached, aborting! in
/home/travis/build/drupalprojects/drupal/includes/module.inc, line
765

Thought I had fixed this with the following code in the before_script:

Expand max_nesting_level to prevent error

export ADDITIONAL_PATH=php -i | grep -F --color=never 'Scan this dir for additional .ini files'
echo 'xdebug.max_nesting_level=9999' | sudo tee ${ADDITIONAL_PATH:42}/drupal.ini

Y Scroll on Subtheme install

I noticed one UX flaw when installing, I attached a screenshot.

When I select the subtheme the y overflow goes mad tall.

image

Rebase on Panopoly and update to 1.6

We forked panopoly, but after discussions with snopek and populist we think there is great space to forge a mutually beneficial pathway forward. To that end we need to rebase hotsauce so that it is a panopoly subdistro again.

One issue that will need to be decided here is whether we dont include some panopoly features like search and pages, or if we attempt to override them using something like
https://github.com/kalamuna/panopoly_override

@andrewmallis and @reynoldsalec, can you help decide that we should do here?

Panelizer warning/notices

I'm getting the following warning and notice on pages displayed using the node panelizer:
Warning: Missing argument 4 for entity_metadata_taxonomy_access() in entity_metadata_taxonomy_access() (line 797 of /srv/bindings/4d1d7571768d42bdaf394dc726162dc7/code/profiles/hotsauce/modules/contrib/entity/modules/callbacks.inc).

Notice: Undefined variable: entity_type in entity_metadata_taxonomy_access() (line 798 of /srv/bindings/4d1d7571768d42bdaf394dc726162dc7/code/profiles/hotsauce/modules/contrib/entity/modules/callbacks.inc).

Not sure if this is related to #17

Also getting these notices about kalatheme on the same panelized pages:
Notice: Undefined index: devices in theme_kalatheme_kalacustomize_render_region() (line 26 of /srv/bindings/4d1d7571768d42bdaf394dc726162dc7/code/profiles/hotsauce/themes/kalatheme/styles/kalacustomize/kalacustomize.inc).
Notice: Undefined index: pane_style in theme_kalatheme_kalacustomize_render_region() (line 27 of /srv/bindings/4d1d7571768d42bdaf394dc726162dc7/code/profiles/hotsauce/themes/kalatheme/styles/kalacustomize/kalacustomize.inc).

Everything seems fine in terms of functionality though, as far as I can tell.

Pull .info dependencies and additional metadata into package.json

reynoldsalec
Owner
reynoldsalec commented on Apr 25
To avoid the issues of keeping our package.json file up-to-date with our app's .info file, we should have an automated process to pull those dependencies into package.json. Could probably also pull some basic metadata (Drupal version etc) into package.json as well.

Any other relevant stuff in .info that we need to transfer?
reynoldsalec
Owner
reynoldsalec commented on Apr 26
The App Manifest project works pretty well, may have some code to steal from there: https://drupal.org/project/app_manifest

Use Panopoly Behat Scripts

Let's leverage the Panopoly behat scripts in our Travis build. Will probably need to...

*Add panopoly_test module
*Run a travis-ci.sh script in our .travis.yml
*Adapt the Panopoly travis-ci.sh script to Hotsauce's needs (correct the Panopoly paths, any other incompatibilities)

Add Kalatheme 4.x dependencies

Kalatheme Wish List

  • views_bootstrap
  • magic
  • speedy
  • icon (most important)
  • views_responsive_grid
  • elements

@bassettsj,

Since we are now going to rely on other contrib modules to provide functionality that was in Kalatheme a la views plugins and libraries handling we are going to want to include those dependencies in hotsauce.

Can you list the dependencies here and any outstanding issues for those modules that may be blockers? ie if the bootstrap libraries module does not allow for 1 library for 1 theme.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.