dsilabs / zoom Goto Github PK

$ vi web/sites/default/site.ini
should be:
$ vi web/sites/localhost/site.ini

Otherwise following the documentation you will attempt to connect with dummy credentials.

Current behaviour:

When no helper matches {{some_variable}} in a template, the output HTML contains the input string; {{some_variable}}

Expected behaviour:

When no helper matches {{some_variable}} in a template, the output HTML contains an empty string in its place. Template variables should universally support a default keyword argument, such that {{helperless_variable default="default value"}} outputs default value.

It is not always the case that the register app will be visible - meaning the group permissions for the guest group do not include the register app. If the register app is not visible then the test-register webtest will fail.

This is an old issue but surfaced just recently with the addition of logic to check before including the basic Zoom apps in a Site.

See config.py, line 128. Need to check if the site config exists before getting the section in the conditional of line 128.

The implementation is the same... what should the clickandwait actually be doing?

In my OS X environment I can't utilize the Display() function as it relies upon pyvirtualdisplay which doesn't run properly in OS X.

Instead the combination of installing Selenium on my Mac, Chromedriver, and Chrome Canary. Setting the following chrome options will allow the Chrome browser to run headless (without using the Display()):

• options.add_argument('window-size=800x841')
• options.add_argument('headless')

Need to extend webtest.py to set the above options and skip Display() for when the environment is OS X.

In the default theme the main menu and the system menu are both located at the top of the window and should be the same height, but they are currently slightly different.

The collection URLs in the admin/activity log are rendered incorrectly. They are rendered using helpers which means that the URL is only finally constructed when it is displayed in the admin app - which means it uses the admin app as it's current app, which is wrong. It should point to the app for the collection that was doing the logging. This issue is only causing problems when collection URLs are used in apps that are not the app where the collection is implemented, but it should really just render the correct URL when the log entry is created so no rending takes place later on.

When I ran the zoom tests for the first time on my local, I ran into issues where I didn't have the correct test users in place, nor the test databases. This highlighted an issue with the tests in that some tests are utilizing 'zoomuser' as a test users and others are utilizing 'testuser'. Ideally we modify the tests and use a single test user.

Similarly, some tests expect a test database to exist called 'zoomdata' and others expect 'zoomtest'.

since commit 7d1dca3 a view with this fails:

def thumb(self):
    """test"""
    import os
    filename = os.path.abspath('activity.png')
    image = open(filename, 'rb').read()
    response = Response(image)
    response.headers['Content-type'] = 'image/png'
    return response (edited)

AppProxy assigns it's .method attribute when it is constructed however the method may be an expensive operation and is only needed when the app is actually to be used. Rather than load the app module (and incurring the costs of doing so including paying for any operations or having to deal with exceptions being raised) it would be better to do a lazy load of the .method attribute and pay the price only if the app needs to be used.

I have not looked into specifically what "instance" is, but something like this works on the web and fails from tests or the command line:

from zoom.fields import PulldownField
f = PulldownField('Type', options=[('',''),('One',1),('Two',2)])
f.edit()

error is:
AttributeError: '_thread._local' object has no attribute 'parts'