dsoskey / cogwork-librarian Goto Github PK

It would be nice to have some way to submit a query from the query editor. Maybe I missed it, but I've been clicking on "scour the library" a lot and I'd like to not do that. Maybe Shift+Enter goes to the next line in the editor and Enter submits? Ctrl+Enter would also work well if you want to keep multi-line editing nice.

Is your feature request related to a problem? Please describe.
while CogLib's query runner runs offline, images are still loaded from scryfall. this means offline searches need a local image source. at the bare minimum, local should support full card text rendering.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Some quick math about storage requirements
medium quality image: ~93KB
number of unique prints: ~80k and rapidly growing
number of oracle cards: ~28k and growing slower than prints

estimated oracle size: 2.5 GiB
estimated print size: 7.2 GiB

I sometimes go through ignoring cards quickly and accidentally ignore cards I don't want to, it would be great to have a way to un-ignore cards?

If you're multiple pages into a search and then submit another query the page index/scroll position stays the same. This can often result in staying on an empty page because the new query matches fewer cards. It would be nice to jump to the very start of the new search when a query is submitted.

Describe the solution you'd like

• tag filters in local syntax supported
• users should be able to look at known scryfall tags

Limitations

• No known public tagger API. this can be worked around with a web scraper, though that's going to be more costly to build than calling an API would be

user feedback

"exposing" scryfall tagger tags to the user. at least, idk, the top 25 or 50 of 'em. some kind of drop down list? because a rules-text search sometimes doesn't gather all cards that function in similar ways due to a wording that you didn't think of
usually right now, i go to a specific card in normal scryfall, then click to see its scryfall tagger entry, to find out the name of a relevant tag, like otag:cycle-dual-tapland, or otag:tribal-share, and then i go back to scryfall to use that tag with other search terms

Describe the bug
types are matching on includes for all inputs, but they should be able to recognize real types too.

To Reproduce
Steps to reproduce the behavior:

1. Run t:rat
2. see pirates in search

Expected behavior
t:rat should return rats only

Describe the solution you'd like
User quote:

A thing I've missed in scryfall is searching for multi equality (power=toughness=mv) vs (power=toughness power=mv)

Describe alternatives you've considered
these queries are currently possible, but this syntax would make the queries more concise.

Open questions

• how does this interact with value expressions? should the first expression always be a filter?
• how many operators are allowed per query?
• which operators are allowed?

Cards disappear and re-appear from my saved cards list when I do one of the following:

1. Type a card into the saved cards list
2. Switch to another tab or window without pressing enter or clicking elsewhere on the page.
3. Switch back to the window or tab with cogwork librarian. The card will now not appear on the saved cards list.
4. Click on any part of the page outside of the saved cards list. The card will now appear on the saved cards list.
5. Click on the card in the saved cards list. The card will now not appear.

I can repeat steps 4 and 5 with the same behavior.

1. Type a card into the saved cards list.
2. Delete some or all of the text from that card's name.
3. Click on any part of the page outside of the saved cards list. The card's full name will now appear on the saved cards list.
4. Click on the card in the saved cards list. The card will now not appear.

Similar to the first method, I can repeat steps 3 and 4 with the same behavior. Notably, if I instead click on another card in the saved cards list rather than elsewhere on the page, the bug no longer occurs and the text I have typed or deleted will be saved.

Windows, Firefox 123.0.1