Giter VIP home page Giter VIP logo

Comments (1)

makaveli2P avatar makaveli2P commented on June 26, 2024

Hey, I saw this issue and was trying to understand the codebase.

Is there a reason for 30 days per month for interval purposes.

//! only used for interval comparison/ordering purposes, in which case a month counts as 30 days
static constexpr const int64_t DAYS_PER_MONTH = 30;

can it be considered to have DAYS_PER_MONTH as an average of the DAYS_PER_YEAR and MONTHS_PER_YEAR

static constexpr const int64_t DAYS_PER_MONTH = DAYS_PER_YEAR/MONTHS_PER_YEAR;

The interval calculation would be 365 days

int64_t days = duckdb::Interval::DAYS_PER_MONTH * interval_value.months + interval_value.days;

from duckdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.