dumbmatter / indexeddb-getall-shim Goto Github PK

Hi,

When using your library, I noticed that the values returned by the getAllKeys method when used on an index returned the key of the records, instead of returning the primaryKey like it seems to be implemented on all modern browsers.

Let me know your thoughts

Hello,

Maybe I am blind, but I could not find how to use this with my angular app.

I did
yarn add indexeddb-getall-shim

and then I imported it in my app.module:

import "indexeddb-getall-shim";

Is this supposed to be enough? I am still getting this error with Microsoft Edge 44.19041.1.0 when startiing my app:

Isn't this the error IndexedDB-getAll-shim is supposed to fix?
I also tried including it in the scripts part of my angular.json, but to no avail...

What am I missing?

Cheers

Hi,

I have a case that the polyfill doesn't correctly patch when I use it with webpack.
I have a test case here. The problem is here :
typeof window === "undefined" ? GLOBAL : this
this doesn't point to window object

Thanks for fixing this
testcase.zip

At the usage section, the instructions suggest to save as a dev dependency. Shouldn't it be a production dependency though?