Logging of storage operations about vichuploaderbundle HOT 7 OPEN

I'd rather avoid adding a new dependency.
Let's go with the new event.

from vichuploaderbundle.

You can easily add a listener for the exception and perform whatever you want (logging, etc.)

from vichuploaderbundle.

@garak how? It seems to me it is just swallowed... :)

from vichuploaderbundle.

Sorry, I misread, you're right.
I think the method should throw the same CannotWriteFileException thrown by the doUpload method.
By the way, the previous exception should be passed.

from vichuploaderbundle.

@garak no problem :) This would require a try catch in UploadHandler wouldn't it? So that the exception is caught there and an event emitted? If the exception is thrown all the way then that would be a BC break - no?

from vichuploaderbundle.

On second thought, it's better to keep it like it is now.
The handler expects an exception for the upload and doesn't expect it from the remove.

Maybe you can exploit a combination of pre-remove and post-remove events to reach your goal.
Otherwise, redefining your own storage is always a possibility.

from vichuploaderbundle.

I would like to politely disagree. Debugging config errors etc in a storage handler is impossible the way it is setup now with silent fail.

The simplest solution would be a PR where the StorageHandlers get a logger and log each execption. This surfaces the error but does not change the overall behavior of the system. IMHO the other option is to let the UploadHandler catch the exception and emit an event.

from vichuploaderbundle.