Comments (8)
What's the case when Content-Disposition is online?
from vichuploaderbundle.
What's the case when Content-Disposition is online?
It simply means that the browser tries to open the file inside the browser and if he can't he is still going to download it.
I overwrote your form template and simply removed the download attribute and it works as expected (even when not setting the header/ direct download link)
from vichuploaderbundle.
So, it seems that the default template works fine with the default headers. If you want something different, overwriting the template is enough.
I don't see any issue here.
from vichuploaderbundle.
So, it seems that the default template works fine with the default headers. If you want something different, overwriting the template is enough.
I don't see any issue here.
My issue is that the download Attribute is unnecessary.
It works as expected without it and without it the standard header gets actually respected as expected.
from vichuploaderbundle.
You already solved it with the custom template. Is there anything else you need?
from vichuploaderbundle.
You already solved it with the custom template. Is there anything else you need?
I thought this change can be applied directly here.
As I think this is a general improvement/"bug" fix
from vichuploaderbundle.
The whole point is about what the average user expects to get. The current implementation suits it.
A custom implementation is still possible.
So, I don't see the need for improvements or fixes.
from vichuploaderbundle.
The current experiene does not change.
The user would still get what they expected but okay if you are not open to this change this disscussion is pointless
from vichuploaderbundle.
Related Issues (20)
- Problem during reading with flysystem HOT 4
- Invalid Schema error while installing the bundle on Symfony 7 HOT 1
- The option "required" does not exist ? HOT 3
- Installation instructions are outdated HOT 2
- Document how to get s3 URL HOT 2
- Issue with VichUploader: unsupported MIME type "image/jpeg" HOT 7
- Install dose not register in bundle.php HOT 1
- Problem with delete when using multiple mappings on one entity HOT 1
- Using pure Annotation Does not Upload the actual file. @Vich\UploadableField HOT 3
- File injection on load not working reliabely with lazy ghost objects
- How to use metadata with VichUploader HOT 9
- The attribute reader should not trigger an exception for other attributes HOT 3
- Form type lazy load support HOT 3
- publicUrl method check looks for wrong exception.
- Autowire services that implement NamerInterface HOT 3
- Logging of storage operations HOT 7
- Define default upload destination HOT 2
- Build is broken HOT 1
- Capture HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vichuploaderbundle.