Giter VIP home page Giter VIP logo

Comments (8)

garak avatar garak commented on August 27, 2024

What's the case when Content-Disposition is online?

from vichuploaderbundle.

DenuxPlays avatar DenuxPlays commented on August 27, 2024

What's the case when Content-Disposition is online?

It simply means that the browser tries to open the file inside the browser and if he can't he is still going to download it.

I overwrote your form template and simply removed the download attribute and it works as expected (even when not setting the header/ direct download link)

from vichuploaderbundle.

garak avatar garak commented on August 27, 2024

So, it seems that the default template works fine with the default headers. If you want something different, overwriting the template is enough.
I don't see any issue here.

from vichuploaderbundle.

DenuxPlays avatar DenuxPlays commented on August 27, 2024

So, it seems that the default template works fine with the default headers. If you want something different, overwriting the template is enough.

I don't see any issue here.

My issue is that the download Attribute is unnecessary.
It works as expected without it and without it the standard header gets actually respected as expected.

from vichuploaderbundle.

garak avatar garak commented on August 27, 2024

You already solved it with the custom template. Is there anything else you need?

from vichuploaderbundle.

DenuxPlays avatar DenuxPlays commented on August 27, 2024

You already solved it with the custom template. Is there anything else you need?

I thought this change can be applied directly here.
As I think this is a general improvement/"bug" fix

from vichuploaderbundle.

garak avatar garak commented on August 27, 2024

The whole point is about what the average user expects to get. The current implementation suits it.
A custom implementation is still possible.
So, I don't see the need for improvements or fixes.

from vichuploaderbundle.

DenuxPlays avatar DenuxPlays commented on August 27, 2024

The current experiene does not change.
The user would still get what they expected but okay if you are not open to this change this disscussion is pointless

from vichuploaderbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.