dxomg / vpsbot Goto Github PK

There is pretty good library to handle config file. it is better to use them for environment as you don't have to modify the code and when you push updates upstream, people can upgrade their bot without needing to redo their config file every time

https://docs.python.org/3/library/configparser.html seems like a good config parser (hense the name haha)

This line should be as config, not hardcoded ^^

Hardcodding command in python and in any other language is really bad practice.. because you should not expect that the user use the system exactly as you do and because bad actor can use it at their advantage to bypass some security. do some ctf and you will find a lot of these exemple...

The best way is to find a lib that handle that for you (you could do syscall too but honestly, that's quite a leap in difficulty)
for instace you can use that https://github.com/lxc/python3-lxc You can check the code... there is some python interface to use and in the background it uses lxclib which handle lxc directly

same should exist for docker tho

You should not remove that file!! this is really not the way as this file is really used by a lot of application.

Imo you should let the user handle the problem with known host by themself... they just have to do ssh-keygen -R <ip> and it's done....
but if you really want to, i'm pretty sure ssh have an option to bypass known_host check. should be something like StrictHostKeyChecking . so you do ssh -o StrictHostKeyChecking=no

I see you use some documentation, which is really good. but if you want to be even gooder, you can follow the PEP 257.

This is just minor improvement

The token could also be in config for ease of use

Python projects should have a requirements.txt for all the dependencies and to manage easier your venv.

https://learnpython.com/blog/python-requirements-file/

path like that sould be local and not global...
this could also be in config file. se by default to local then different installation would put their config file wherever they want

so by default I think you should do

filelocation=./myfiles/

and use it on every path possible