Giter VIP home page Giter VIP logo

Comments (6)

pugovic avatar pugovic commented on July 23, 2024

@jjroelofs When installing the dxpr_lightning profile

for branch 2.x received such error https://i.imgur.com/M5gTBId.png

for branch 1.x received this error https://i.imgur.com/HdWBRs8.png

For testing, the project was used https://github.com/dxpr/lightning_dxpr_project

For the 2.x (8) branch, everything was quite simple, there was simply no dxpr_gridstack module dependency in the composer.json file
which is used in the dxpr_logistics_demo child module. After adding the dependency, the error disappeared.
4+ installations was passed , because each error in profile case required repeating the installation again.

For the 1.x (9) branch, the core code was examined and it turned out that optional configs of module are installed at the end of the profile installation. docroot / core / lib / Drupal / Core / Config / ConfigInstaller.php https://i.imgur.com/hxeLtAC.png

https://i.imgur.com/VgeRbAX.png

Installed 5 times,

I also want to note that in d9 the profile tasks (which appear at the end of the profile installation) are not considered to be the profile installation, therefore the module configurations were imported in a normal order and there was no such error docroot / core / lib / Drupal / Core / Config / ConfigInstaller.php Differs from d8 https://i.imgur.com/Imd2Fc3.png

from lightning_dxpr.

jjroelofs avatar jjroelofs commented on July 23, 2024

@pugovic I think this is already fixed, can you still reproduce it? with the latest Lightning DXPR code? Maybe the client has an old installation with old code.

from lightning_dxpr.

pugovic avatar pugovic commented on July 23, 2024

@jjroelofs This is not fixed, because the pr #11 waited for code review. This pr has been well tested. But if you want i will do it anyway.

from lightning_dxpr.

jjroelofs avatar jjroelofs commented on July 23, 2024

@pugovic the 1.x branch is deprecated and the 2.x branch does not depend on dxpr_gridstack anymore, so I think the root cause of the problem is now fixed, and we don't need these changes anymore. correct?

from lightning_dxpr.

pugovic avatar pugovic commented on July 23, 2024

@jjroelofs If branch 1.x is deprecated then yes the bug has already been fixed

from lightning_dxpr.

pugovic avatar pugovic commented on July 23, 2024

The task is already done because: the 1.x branch is deprecated and the 2.x branch does not depend on dxpr_gridstack anymore,

from lightning_dxpr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.