dxpr / lightning_dxpr Goto Github PK

Hi there :) I'm the Lightning maintainer at Acquia, and I see that this appears to be an actively maintained sub-profile of Lightning. I thought I would drop in to inform you that Lightning is going to reach its end of life in November 2021 (see https://www.acquia.com/blog/acquia-lightning-eol-2021-acquia-cms-future), and therefore this package will probably need to drop its Lightning dependency and decouple the sub-profile by then. There is some documentation on how to do that available at https://github.com/acquia/lightning/wiki/Uninstalling-Lightning#decoupling-a-sub-profile-from-lightning. Please let me know if I can be of any assistance!

On june 3rd Acquia Lightning released 5.0.0-beta2, it's probably stable enough to start developing our 2.x branch on for testing.
Bootstrap basetheme seems to be a bit problematic, I hope it's fixed before the weekend:
https://www.drupal.org/project/bootstrap/issues/3096963#comment-13664874

https://github.com/dxpr/dxpr_builder/issues/1338

1. Divider element page not showing correctly for anonymous users
2. Tabs element loading with wrong active tab before init
3. Section page failing anonymous visual regression testing due to parallax sections

Related issue: https://www.drupal.org/project/drupal/issues/1650930

So that we can see why crashes happen in selenium screenshots

Related:

• https://www.drupal.org/project/issues/moderation_dashboard?categories=All
• https://github.com/dxpr/dxpr_maven/issues/707
• https://github.com/dxpr/dxpr_maven/issues/717

Due to the overrinding of dxpr_builder.settings from the dxpr_qa_demo module.

From client:

To do this on dxpr demo.

Create a custom block:
Home > Administration > Structure > Block layout Custom block library +Add custom block type
Add Field
Choose either: (Reference) File, (Reference)Image > Add label > Save and continue
The Upload destination options are missing. It's a required field without an illegal choice warning. You can't save or make changes. You can back out bot not change the field settings.

Note: The older version of Glazed with a different administration theme also does this. An older version of the default (on Drupal 8.7.7) lightening works fine. I can't find any issues like this on drupal.org. I'm not sure what to do.

@dench0 if you need more info please ask the client directly in the ticket system: https://app.dxpr.com/hc/tickets/4178/custom-block-file-field-image-field-missing-upload-destination-option

jurriaan 11:08 PM
@hoat Le we recently had a failure of lightning_dxpr_project builds because we made a little mistake on the composer.json of its child-repo: https://github.com/dxpr/lightning_dxpr
is is possible you copy the PR tests with have on lightning_dxpr_project to lightning_dxpr so that we can validate our build against composer 1.x and 2.x?

Hoat Le 22 hours ago
I could add a trigger to validate lightning_dxpr_project (2.x) when there is new commit from lightning_dxpr (2.x), is that ok @jurriaan? (edited)

Hoat Le 22 hours ago
do you want to validate lightning_dxpr_project against the https://github.com/dxpr/lightning_dxpr 1.x branch?
🔴
1

jurriaan 22 hours ago
@hoat Le ok, so I rely on an email to be notified of the triggered check? or will it show somewhere in github UI?

jurriaan 22 hours ago
the lightning_dxpr 1.x branch is not used anymore, the 2.x branch is

jurriaan 22 hours ago
you can skip the 1.x branch

Hoat Le 21 hours ago
the trigger is automatic

Related:

• hiqdev/asset-packagist#146
• https://github.com/dxpr/dxpr_builder/issues/874
• https://ryanszrama.com/blog/04-18-2022/replace-asset-packagist-custom-package-repositories
• https://www.drupal.org/project/lightning_media/issues/3275867
• https://www.drupal.org/project/lightning_media/issues/3275871

Solution: increment version number of dxpr/lightning dependency which will depend on a patched version of lightning_media

After solving #37 we're facinga new concurrency problem in parallel testing. When Multiple tests in parallel open the media browser, PHP is overwhelmed with requests to resize the images in the library.

Some of those images are 6000x4000px, so the first thing we try is to resize the images.

As Lightning will be EOL soon this profile will not be useful as starter site and we probably only continue to use it in QA testing because we have the QA demo site included in this profile.

We were having QA problems due to HTML changes between Claro and Gin, we should reinstate Claro since it makes more sense to QA test on a Drupal core admin theme.

Related:
#23

https://github.com/dxpr/dxpr_maven/issues/15

Before making the suggested change we should verify that it indeed fixes the test failure in dxpr_maven

The node form often causes problems with the HTML generated by our layout builder. Also, people get confused if they add images with CKEditor and they won't work work in the front-end if DXPR Builder is enabled.

We should still fix bugs that arise in the node form like #14 because sometimes the node form is needed for debugging. But the default body/node form in lightning_dxpr should switch to hide the body field.

Please test that creating content still works OK after this change.

@mhmelshaaerdxpr I would like you to be reviewer on this PR and test that the fix works OK that @dench0 creates. This will involve creating a fresh installation based of his feature branch.

related: https://github.com/dxpr/dxpr_maven/issues/348

Last Wednesday we updated the DXPR Builder settings config file in the QA Demo module that toggles on the new config for Notifications. When updating the file we made a mistake that disabled the media library.

I noticed this error during a demo yesterday. It's not just on the node form of drag and drop pages, also basic pages. Found a similar bug report here: https://www.drupal.org/project/webform/issues/2973530

"Uncaught Error: [CKEDITOR.resourceManager.load] Resource name "fakeobjects" was not found at "/1608448582/docroot/libraries/fakeobjects/plugin.js?t=qlmmrp".
at CKEDITOR.resourceManager. (ckeditor.js?v=4.15.0:257)
at d (ckeditor.js?v=4.15.0:253)
at Array.n (ckeditor.js?v=4.15.0:253)
at y (ckeditor.js?v=4.15.0:253)
at HTMLScriptElement.CKEDITOR.env.ie.d.$.onerror (ckeditor.js?v=4.15.0:254)"

link provided by packagist: https://packagist.org/about#how-to-update-packages

https://getcomposer.org/allow-plugins

Composer added a backwards-incompatible feature.

Related:

• dxpr/lightning#1

Lightning's core patches are and will not be updated to work with Drupal 9.3.0 because Lightning is deprecated by Acquia.

Related issue: https://www.drupal.org/node/3143958

Suggested solution: fork Lightning and prevent it from installing 9.3.0

When installing this distro we fail with the following message:

my_drupal9_project_qa_demo |  [info] dxpr_qa_demo module installed.
my_drupal9_project_qa_demo |
my_drupal9_project_qa_demo | In ContainerBuilder.php line 1032:
my_drupal9_project_qa_demo |
my_drupal9_project_qa_demo |   [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]
my_drupal9_project_qa_demo |   You have requested a non-existent service "default_content.importer".
my_drupal9_project_qa_demo |
my_drupal9_project_qa_demo |

It's happening since today so I'm guessing it's due to Drupal 9.2.0 release.

Can you look into this and suggest/implement a fix, workaround, or patch for contrib projects.

While installing the dxpr_lightning with demo logistics content,client gets:

An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: /core/install.php?rewrite=ok&profile=lightning_dxpr&langcode=en&id=2&op=do_nojs&op=do StatusText: OK ResponseText: Symfony\Component\Serializer\Exception\UnexpectedValueException: Type http://drupal.org/rest/type/block_content/drag_and_drop_block does not correspond to an entity on this site. in Drupal\hal\Normalizer\ContentEntityNormalizer->getTypedDataIds() (line 281 of /var/www/dxpr-demo.nfi-llc.com/web/docroot/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php).

So
When I have done the installation for the 2.x branch I got this error

but
when I have done the installation for the 1.x branch I got this error do

(like client has shown to us)

related task https://dxpr.monday.com/boards/454831816/pulses/690729079

So it is needed to be fixed

Because the QA demo module overrides dxpr_builder.settings with a copy that doesn't include the notifications setting.

related: https://github.com/dxpr/dxpr_builder/issues/752