dyangcoding / jointelementinspector Goto Github PK

it would be interesting that we could filter children with item type

1 start new intent from open file activity and sent intent flag as FLAG_ACTIVITY_SINGLE_TOP
Updata: sent flag as FLAG_ACTIVITY_CLEAR_TOP and it works.

2 using onActivityResult in main, setResult in open file
issue: pass data to viewpager cause problem, later check it out

1 make all kind of data private, which been created (capture photos) or modified (write xml) from this app, and data should deleted when user uninstall app

2 xml file shoul also come from internal storage

3 so some aspect should be redesigned to fill the goals

should make tabwidth suitable to screen width and change font

1 recyclerView.setHasFixedSize(true), this do improve the profermance, only for the case that all item of view has fixed width and height.

2 recyclerView.setItemViewCacheSize(20);
recyclerView.setDrawingCacheEnabled(true);
recyclerView.setDrawingCacheQuality(View.DRAWING_CACHE_QUALITY_HIGH);
Not sure about this

3 set OnClickListener once in onCreateViewHolder() and call through an interface a listener outside of the Adapter, passing the clicked view. don't create extra objects all the time. Already done

4 by updateing adapter, consider do not collect all items all the time, take advantage of the following methods may help, not tests
adapter.notifyItemRangeInserted(rangeStart, rangeEnd)
adapter.setHasStableIds(true);
adapter.notifyItemRemoved(position);
adapter.notifyItemChanged(position);
adapter.notifyItemInserted(position);
this requires that data which to be served has unique ids.

maybe use onActivityResult to set path for photos

1 permission to access camera
2 permission to access external storage
3 and more if needed

suggesstion: onSaveInstanceState and onRestoreInstanceState

1 Bad practice: create onClickListener in onBindViewHolder, listener would bind to ervery object which been loaded here. each item in a recycler can be bound lots of times
bad for performace and GC

2 uses interface customItemClickListener for better performace and bind it in viewHolder

3 bind listener on Viewholder, make it possiable so that card view could perform onclick

after opening file, load stl and add weld points do not work always