e-commit / doctrine-entities-generator-bundle Goto Github PK

Given the following property

    #[ORM\Column(type: 'datetimetz_immutable', nullable: false)]
    protected ?DateTimeInterface $date;

generated output will be:

    public function setDate(?\DateTimeImmutable $date): self
    {
        $this->date = $date;

        return $this;
    }

    public function getDate(): ?\DateTimeImmutable
    {
        return $this->date;
    }

(note that typehint is \DateTimeImmutable, not \DateTimeInterface)

While this is technically correct from Doctrine's point of view, it will be better to prefer interface as typehint, especially when it is explicitly used in property's type.

It is possible that entity can have readonly properties. Example cases:

• entity data comes from materialized view
• field value comes from generated column
• field value set elsewhere outside entity, e.g. with custom UPDATE queries, or from other app sharing this db
• property is set in constructor for a new entity and persisted forever in that state

A readonly access modifier becomes useful here to enforce that no modifications are allowed. But with it, generated setter methods are invalid.

Generator should omit setter methods for fields, embeddeds and to-one associations, if a property is readonly.

#[ORM\Embedded]
protected MyEmbed $obj;

Results in:

In EntityGenerator.php line 114:
Warning: Undefined array key "obj"

It seems that embeddables are not supported currently, but neither are they skipped, and it fails here: